-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat:after RemoveTrivialFilters call RemoveEmptyUnionBranches to prune empty union branches.
#26349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sopel39 PTAL |
1b71de0 to
435cb6c
Compare
wendigo
reviewed
Aug 6, 2025
core/trino-main/src/test/java/io/trino/sql/planner/TestLogicalPlanner.java
Outdated
Show resolved
Hide resolved
435cb6c to
fd3cdf5
Compare
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
Contributor
|
@kasiafi ptal |
fd3cdf5 to
7a149e0
Compare
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
|
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
martint
reviewed
Oct 22, 2025
core/trino-main/src/test/java/io/trino/sql/planner/TestLogicalPlanner.java
Outdated
Show resolved
Hide resolved
kasiafi
reviewed
Nov 3, 2025
core/trino-main/src/test/java/io/trino/sql/planner/TestLogicalPlanner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/TestLogicalPlanner.java
Outdated
Show resolved
Hide resolved
RemoveTrivialFilters call RemoveEmptyUnionBranches to prune empty union branches.
…e empty union branches.
7a149e0 to
db6a5e5
Compare
Contributor
Author
|
@kasiafi @chenjian2664 PTAL |
kasiafi
approved these changes
Nov 6, 2025
Member
|
Merged. Thank you @Max-Cheng! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #21506
Minimising Reproduction:
Additional context and related issues
Should callRemoveEmptyUnionBranchesafterRemoveTrivialFiltersPrune empty union branches.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( x ) Release notes are required, with the following suggested text: