Add some more meaningful names to distinct Bootstrap instances #27203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate Bootstrap instantiations across multiple plugins/connectors to include descriptive name prefixes (access, catalog, auth, groups, resource-group) for clearer context and debugging. Class diagram for updated Bootstrap instantiationsclassDiagram
class FileBasedSystemAccessControl {
+create(config, context)
// Bootstrap now instantiated with name prefix: "io.trino.bootstrap.access." + getName()
}
class ExampleConnectorFactory {
+create(catalogName, requiredConfig, context)
// Bootstrap now instantiated with name prefix: "io.trino.bootstrap.catalog." + catalogName
}
class FileAuthenticatorFactory {
+create(config)
// Bootstrap now instantiated with name prefix: "io.trino.bootstrap.auth." + getName()
}
class FileGroupProviderFactory {
+create(config)
// Bootstrap now instantiated with name prefix: "io.trino.bootstrap.groups." + getName()
}
class LdapAuthenticatorFactory {
+create(config)
// Bootstrap now instantiated with name prefix: "io.trino.bootstrap.auth." + getName()
}
class SalesforceAuthenticatorFactory {
+create(config)
// Bootstrap now instantiated with name prefix: "io.trino.bootstrap.auth." + getName()
}
class FileResourceGroupConfigurationManagerFactory {
+create(config, context)
// Bootstrap now instantiated with name prefix: "io.trino.bootstrap.resource-group." + getName()
}
class DbResourceGroupConfigurationManagerFactory {
+create(config, context)
// Bootstrap now instantiated with name prefix: "io.trino.bootstrap.resource-group." + getName()
}
class Bootstrap {
+Bootstrap(name, ...modules)
}
FileBasedSystemAccessControl --> Bootstrap
ExampleConnectorFactory --> Bootstrap
FileAuthenticatorFactory --> Bootstrap
FileGroupProviderFactory --> Bootstrap
LdapAuthenticatorFactory --> Bootstrap
SalesforceAuthenticatorFactory --> Bootstrap
FileResourceGroupConfigurationManagerFactory --> Bootstrap
DbResourceGroupConfigurationManagerFactory --> Bootstrap
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
ksobolew
commented
Nov 4, 2025
Comment on lines
45
to
+47
| // A plugin is not required to use Guice; it is just very convenient | ||
| Bootstrap app = new Bootstrap( | ||
| "io.trino.bootstrap.catalog." + catalogName, |
Contributor
Author
There was a problem hiding this comment.
I know this in "only" an example, but it should show this as a best practice
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
wendigo
approved these changes
Nov 4, 2025
Contributor
Author
Hmmm, I don't think that's me... |
Contributor
wat |
wendigo
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to d01c5ac.
Additional context and related issues
This "invents" some more bootstrap name prefixes, specifically
io.trino.bootstrap.auth.andio.trino.bootstrap.resource-group..Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:
Summary by Sourcery
Assign context-specific name prefixes to Bootstrap instances across various plugin factories to improve identification
Enhancements: