Some more cleanups related to ConnectorContextModule

[ksobolew]

Description

Two kinds of commits:

1. Remove duplicate bindings that are already provided by ConnectorContextModule, like Remove duplicate binding of TypeManager in trino-kafka #27178; this should have been part of the original PR, tbh
2. Start using ConnectorContextModule in a plugin; these were missed because they do the bindings inside plugin-specific modules instead of using a common pattern of a module binding them "manually"

Additional context and related issues

ConnectorContextModule was introduced in #27054.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

Summary by Sourcery

Standardize context injection by using ConnectorContextModule across connectors and eliminate duplicate manual bindings in plugin modules

Enhancements:

• Remove redundant manual bindings of TypeManager, NodeManager, and Node from plugin modules
• Inject ConnectorContextModule in all connector factories (memory, faker, tpcds, tpch, cassandra) for consistent context setup
• Simplify plugin-specific modules by relying on ConnectorContextModule for context dependencies

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactor plugin modules to remove redundant context bindings now provided by ConnectorContextModule and update connector factories to include ConnectorContextModule for centralized context provisioning.

Class diagram for updated plugin modules and context binding

classDiagram
    class ConnectorContextModule {
        +ConnectorContextModule(String catalogName, ConnectorContext context)
    }
    class MemoryModule {
        +configure(Binder binder)
    }
    class FakerModule {
        +configure(Binder binder)
    }
    class TpcdsModule {
        +configure(Binder binder)
    }
    class TpchModule {
        +TpchModule(int defaultSplitsPerNode, boolean predicatePushdownEnabled)
        +setup(Binder binder)
    }
    class CassandraClientModule {
        +setup(Binder binder)
    }
    ConnectorContextModule <|.. MemoryModule
    ConnectorContextModule <|.. FakerModule
    ConnectorContextModule <|.. TpcdsModule
    ConnectorContextModule <|.. TpchModule
    ConnectorContextModule <|.. CassandraClientModule

Loading

File-Level Changes

Change	Details	Files
Remove manual context bindings from plugin modules	Eliminate TypeManager, Node, and NodeManager fields and constructors Remove binder.bind invocations for context objects Clean up imports and simplify module classes to only declare connector bindings	plugin/trino-memory/src/main/java/io/trino/plugin/memory/MemoryModule.java plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerModule.java plugin/trino-tpcds/src/main/java/io/trino/plugin/tpcds/TpcdsModule.java plugin/trino-tpch/src/main/java/io/trino/plugin/tpch/TpchModule.java plugin/trino-cassandra/src/main/java/io/trino/plugin/cassandra/CassandraClientModule.java
Inject ConnectorContextModule in connector factories	Replace direct module instantiation with ConnectorContextModule(catalogName, context) Remove context parameters from subsequent plugin Module constructors Update Bootstrap calls to include ConnectorContextModule before plugin modules	plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerConnectorFactory.java plugin/trino-tpcds/src/main/java/io/trino/plugin/tpcds/TpcdsConnectorFactory.java plugin/trino-memory/src/main/java/io/trino/plugin/memory/MemoryConnectorFactory.java plugin/trino-tpch/src/main/java/io/trino/plugin/tpch/TpchConnectorFactory.java plugin/trino-cassandra/src/main/java/io/trino/plugin/cassandra/CassandraConnectorFactory.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[ebyhr]

CI hit #27183

[chenjian2664]

The ConnectorContextModule binds more than just TypeManager :) , but we just want to use ConnectorContextModule right?

[ksobolew]

Yes, we want to use it whenever at least one object from ConnectorContext is passes to the connector.

[chenjian2664]

Thanks