Remove duplicate binding of TypeManager in trino-kafka

[ksobolew]

Description

This binding is already provided by ConnectorContextModule.

Additional context and related issues

ConnectorContextModule was added in #27054.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Summary by Sourcery

Remove redundant TypeManager constructor injections and manual bindings in the trino-kafka plugin modules and delegate TypeManager binding to ConnectorContextModule

Enhancements:

• Drop TypeManager parameter and field from KafkaConnectorModule and ConfluentModule
• Remove manual binding of TypeManager in ConfluentModule
• Simplify KafkaConnectorFactory to use KafkaConnectorModule without passing TypeManager

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR cleans up the trino-kafka connector by removing duplicate TypeManager injections and bindings, relying instead on the existing ConnectorContextModule to provide TypeManager.

Class diagram for updated KafkaConnectorModule and ConfluentModule constructors

classDiagram
    class KafkaConnectorModule {
        +setup(Binder binder)
    }
    class ConfluentModule {
        +setup(Binder binder)
    }
    KafkaConnectorModule --|> AbstractConfigurationAwareModule
    ConfluentModule --|> AbstractConfigurationAwareModule

    %% Removed: TypeManager attribute and constructor parameter from both classes
    %% Removed: binder.bind(TypeManager.class) from ConfluentModule.setup()
    %% KafkaConnectorModule now constructed without TypeManager
    %% ConfluentModule now constructed without TypeManager

    class ConnectorContextModule {
        +TypeManager provided
    }
    KafkaConnectorFactory --> KafkaConnectorModule
    KafkaConnectorFactory --> ConnectorContextModule
    ConnectorContextModule --> TypeManager

Loading

Class diagram for removed TypeManager binding in ConfluentModule

classDiagram
    class ConfluentModule {
        +setup(Binder binder)
        %% TypeManager binding removed
    }
    class TypeManager {
    }
    %% Previously: ConfluentModule had TypeManager attribute and bound it in setup
    %% Now: ConfluentModule does not bind TypeManager
    ConfluentModule ..> TypeManager : (binding removed)

Loading

Class diagram for updated KafkaConnectorFactory module construction

classDiagram
    class KafkaConnectorFactory {
        +create(String catalogName, Map<String, String> config, ConnectorContext context)
    }
    class KafkaConnectorModule {
        +setup(Binder binder)
    }
    class ConnectorContextModule {
        +TypeManager provided
    }
    KafkaConnectorFactory --> KafkaConnectorModule
    KafkaConnectorFactory --> ConnectorContextModule
    ConnectorContextModule --> TypeManager

Loading

File-Level Changes

Change	Details	Files
Remove TypeManager constructor injection and usage in KafkaConnectorModule	Delete TypeManager field and constructor Remove requireNonNull import Update bindTopicSchemaProviderModule call to no-arg ConfluentModule Switch KafkaConnectorModule instantiation to no-arg constructor in factory	plugin/trino-kafka/src/main/java/io/trino/plugin/kafka/KafkaConnectorModule.java plugin/trino-kafka/src/main/java/io/trino/plugin/kafka/KafkaConnectorFactory.java
Eliminate manual TypeManager binding from ConfluentModule	Remove TypeManager field and constructor Remove binder.bind(TypeManager.class) call	plugin/trino-kafka/src/main/java/io/trino/plugin/kafka/schema/confluent/ConfluentModule.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}