Skip to content

Conversation

@ebyhr
Copy link
Member

@ebyhr ebyhr commented Nov 6, 2025

Description

The example failure: https://github.com/trinodb/trino/actions/runs/19131497146/job/54673195949

2025-11-06T10:08:26.7380760Z [ERROR] io.trino.plugin.hive.TestHiveConnectorTest.testSchemaAuthorizationForRole -- Time elapsed: 0.103 s <<< ERROR!
2025-11-06T10:08:26.7384245Z io.trino.testing.QueryFailedException: line 1:1: Role 'authorized_users' already exists
2025-11-06T10:08:26.7419392Z 	at io.trino.testing.AbstractTestingTrinoClient.execute(AbstractTestingTrinoClient.java:138)
2025-11-06T10:08:26.7422409Z 	at io.trino.testing.DistributedQueryRunner.executeInternal(DistributedQueryRunner.java:587)
2025-11-06T10:08:26.7425745Z 	at io.trino.testing.DistributedQueryRunner.executeWithPlan(DistributedQueryRunner.java:576)
2025-11-06T10:08:26.7428543Z 	at io.trino.testing.QueryAssertions.assertDistributedUpdate(QueryAssertions.java:106)
2025-11-06T10:08:26.7430034Z 	at io.trino.testing.QueryAssertions.assertUpdate(QueryAssertions.java:60)
2025-11-06T10:08:26.7432781Z 	at io.trino.testing.AbstractTestQueryFramework.assertUpdate(AbstractTestQueryFramework.java:416)
2025-11-06T10:08:26.7434922Z 	at io.trino.plugin.hive.BaseHiveConnectorTest.testSchemaAuthorizationForRole(BaseHiveConnectorTest.java:797)
2025-11-06T10:08:26.7438022Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
2025-11-06T10:08:26.7440243Z 	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:511)
2025-11-06T10:08:26.7441589Z 	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.tryRemoveAndExec(ForkJoinPool.java:1490)
2025-11-06T10:08:26.7452304Z 	at java.base/java.util.concurrent.ForkJoinPool.helpJoin(ForkJoinPool.java:2248)
2025-11-06T10:08:26.7454484Z 	at java.base/java.util.concurrent.ForkJoinTask.awaitDone(ForkJoinTask.java:499)
2025-11-06T10:08:26.7455628Z 	at java.base/java.util.concurrent.ForkJoinTask.join(ForkJoinTask.java:666)
2025-11-06T10:08:26.7456722Z 	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:511)
2025-11-06T10:08:26.7458028Z 	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1450)
2025-11-06T10:08:26.7459296Z 	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:2019)
2025-11-06T10:08:26.7460534Z 	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:187)
2025-11-06T10:08:26.7461706Z 	Suppressed: java.lang.Exception: SQL: CREATE ROLE authorized_users IN hive
2025-11-06T10:08:26.7462928Z 		at io.trino.testing.DistributedQueryRunner.executeInternal(DistributedQueryRunner.java:594)
2025-11-06T10:08:26.7464275Z 		... 15 more

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Nov 6, 2025
@github-actions github-actions bot added the hive Hive connector label Nov 6, 2025
@ebyhr ebyhr requested review from findepi and wendigo November 6, 2025 13:02
assertUpdate(admin, "CREATE ROLE authorized_users IN hive");
assertUpdate(admin, "GRANT authorized_users TO user IN hive");
String role = "authorized_users" + randomNameSuffix();
assertUpdate(admin, "CREATE ROLE " + role + " IN hive");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't have to be random.
it's enough that it's not reused between this test and testCreateSchemaWithAuthorizationForRole

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but random suffix is safer to reduce copy-paste mistake.

@ebyhr ebyhr merged commit 4236861 into trinodb:master Nov 6, 2025
54 checks passed
@ebyhr ebyhr deleted the ebi/hive-flaky-ci branch November 6, 2025 22:11
@github-actions github-actions bot added this to the 479 milestone Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants