Skip to content

Conversation

@MonkeyCanCode
Copy link
Contributor

@MonkeyCanCode MonkeyCanCode commented Oct 31, 2025

Description

With apache/iceberg#13809, there is an option users can use to enable/disable token exchange as refresh. As not all iceberg REST catalog support token exchange, it is beneficial to have this control available on Trino when dealing with iceberg REST catalogs.

Release notes

## Iceberg
* Add support for disabling token exchange via the `iceberg.rest-catalog.oauth2.token-exchange-enabled` config property. ({issue}`27174`)

@cla-bot
Copy link

cla-bot bot commented Oct 31, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added docs iceberg Iceberg connector labels Oct 31, 2025
@MonkeyCanCode MonkeyCanCode changed the title Token exchange enabled Iceberg catalog: token exchange control Oct 31, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@cla-bot
Copy link

cla-bot bot commented Oct 31, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ebyhr
Copy link
Member

ebyhr commented Oct 31, 2025

@MonkeyCanCode Please avoid removing the Release notes section from the PR description, and make sure to submit the CLA if you haven’t already.

@ebyhr ebyhr force-pushed the token-exchange-enabled branch from d8761a8 to 3ac7c6d Compare October 31, 2025 04:05
@cla-bot
Copy link

cla-bot bot commented Oct 31, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ebyhr ebyhr changed the title Iceberg catalog: token exchange control Add support for token exchange in Iceberg REST catalog Oct 31, 2025
@trinodb trinodb deleted a comment from sourcery-ai bot Oct 31, 2025
@MonkeyCanCode
Copy link
Contributor Author

MonkeyCanCode commented Oct 31, 2025

@MonkeyCanCode Please avoid removing the Release notes section from the PR description, and make sure to submit the CLA if you haven’t already.

Thanks for the quick review. I am sorry for the inconvenience and thanks for helping fixed the description. Yes, I had submit the CLA.

@cla-bot cla-bot bot added the cla-signed label Nov 6, 2025
@MonkeyCanCode
Copy link
Contributor Author

@MonkeyCanCode Please avoid removing the Release notes section from the PR description, and make sure to submit the CLA if you haven’t already.

Thanks for the quick review. I am sorry for the inconvenience and thanks for helping fixed the description. Yes, I had submit the CLA.

@ebyhr CLA check is now passed. Please take a look when you have a chance. Thanks.

@ebyhr ebyhr force-pushed the token-exchange-enabled branch from 32bb83a to 3d75106 Compare November 6, 2025 03:25
@ebyhr
Copy link
Member

ebyhr commented Nov 6, 2025

@MonkeyCanCode Please use rebase instead of merge.

@MonkeyCanCode
Copy link
Contributor Author

MonkeyCanCode commented Nov 6, 2025

@MonkeyCanCode Please use rebase instead of merge.

@ebyhr would you like me to create a rebase branch instead of continue with current one?

@ebyhr ebyhr force-pushed the token-exchange-enabled branch from fcc1b00 to 7d4ba38 Compare November 6, 2025 03:29
@ebyhr
Copy link
Member

ebyhr commented Nov 6, 2025

@MonkeyCanCode Nope, I already fixed.

@ebyhr ebyhr merged commit 55d7887 into trinodb:master Nov 6, 2025
45 checks passed
@github-actions github-actions bot added this to the 479 milestone Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants