-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add support for token exchange in Iceberg REST catalog #27174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
@MonkeyCanCode Please avoid removing the |
d8761a8 to
3ac7c6d
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Thanks for the quick review. I am sorry for the inconvenience and thanks for helping fixed the description. Yes, I had submit the CLA. |
@ebyhr CLA check is now passed. Please take a look when you have a chance. Thanks. |
32bb83a to
3d75106
Compare
|
@MonkeyCanCode Please use |
@ebyhr would you like me to create a rebase branch instead of continue with current one? |
fcc1b00 to
7d4ba38
Compare
|
@MonkeyCanCode Nope, I already fixed. |
Description
With apache/iceberg#13809, there is an option users can use to enable/disable token exchange as refresh. As not all iceberg REST catalog support token exchange, it is beneficial to have this control available on Trino when dealing with iceberg REST catalogs.
Release notes