This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Conversation
…d of keyspace.shard Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Leo Xuzhang Lin <llin@hubspot.com>
Signed-off-by: Leo Xuzhang Lin <llin@hubspot.com>
Signed-off-by: David Weitzman <dweitzman@pinterest.com>
This completes yuananf's work from vitessio#3683 which was split into several diffs and never fully landed. One large benefit of multi-statement support is that the "rewriteBatchedStatements" option in Java's connector-j driver doesn't work without it. There's a bug where connector-j fails to check the server capabilities and assumes multi-statement support. Signed-off-by: David Weitzman <dweitzman@pinterest.com>
Multi-statement support
Signed-off-by: Jitendra Vaidya <jitendra.vaidya@gmail.com>
See also PR 4470 and commit dba155b which introduced a dependency on golang 1.10+. Some docs refer to 1.11+ so I made bootstrap.sh require that. Signed-off-by: Scott Lanning <scott.lanning@booking.com>
require golang version 1.11+
Added the ability to build without tests
Signed-off-by: Jitendra Vaidya <jitendra.vaidya@gmail.com>
Fix docs. Make sure that env.sh does not set VTTOP if already set.
There were a few regressions that got introduced due to recent changes: * MYSQL_FLAVOR got dropped from Dockerfile.mariadb. * New build.env did not get included in the docker builds. * CapabilityClientDeprecateEOF behaves differently for MySQL 5.7 vs older versions: MySQL 5.6 and MariaDB. For 5.7, the capability always comes back true, but it comes back as true or false for other versions. So, I just removed the check. Also removed column length check in one of the tests because they are not consistent across flavors. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
helm: handle Orchestrator during preStop shutdown hook
build: fix broken build for other flavors
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
The error from bootstrap.sh was: "./dev.env: line 23: source: build.env: file not found". I think it broke in commit 157ebf5 . Not sure if this is the right fix, but it worked for me (bootstrap.sh does `source ./build.env`, so it's probably ok). Signed-off-by: Scott Lanning <scott.lanning@booking.com>
fix a bootstrap.sh error
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
helm: bump chart version to 1.0.4
…ated-files Regenerates protobuf files using protoc 3.6.1
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Update comments in functions
Signed-off-by: xichengliudui <liuduidui@beyondcent.com>
Signed-off-by: xichengliudui <liuduidui@beyondcent.com>
Signed-off-by: xichengliudui <liuduidui@beyondcent.com>
Signed-off-by: xichengliudui <liuduidui@beyondcent.com>
Signed-off-by: xichengliudui <liuduidui@beyondcent.com>
…d-txt-file Update the func md txt file
Signed-off-by: xichengliudui <liuduidui@beyondcent.com>
Update the function name in the comment
See vitessio#4551 Signed-off-by: David Weitzman <dweitzman@pinterest.com>
Signed-off-by: xichengliudui <liuduidui@beyondcent.com>
Don't panic in binlogplayer if the vreplication table omits key range
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
…d instead of keyspace.shard" This reverts commit 8ea39c3. Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Someone who accidentally made a huge transaction asked what this error meant: "vttablet: rpc error: code = Aborted desc = transaction 1548379105148705713: in use: for rollback" It's less clear than the typical transaction killed error because the transaction was so large that rolling it back probably took some time. This diff changes the in use reason to "for tx killer rollback" which will hopefully be more clear. Signed-off-by: David Weitzman <dweitzman@pinterest.com>
vreplication: vplayer
Revert "change ClusterAlias in _vt.local_metadata ...
fix comments in tests
Use a more specific "in use" message for the tx killer's rollback
update .go and .py files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr: most of the changes look good,
I'm worry about: vitessio#4463Slack changes
Non-Slack changes
Add group specification to mysql static auth for ACL usage vitessio/vitess#4499: Add group specification to mysql static auth for ACL usage
Route "show tables from " to the named keyspace
glog.MaxSizeas-log_rotate_max_sizeflag vitessio/vitess#4523: Exposeglog.MaxSizeas-log_rotate_max_sizeflagDoc changes
Docker changes