go/mysql: remove excessive []byte(s) conversion#4558
Merged
sougou merged 1 commit intovitessio:masterfrom Jan 29, 2019
quasilyte:patch-1
Merged
go/mysql: remove excessive []byte(s) conversion#4558sougou merged 1 commit intovitessio:masterfrom quasilyte:patch-1
sougou merged 1 commit intovitessio:masterfrom
quasilyte:patch-1
Conversation
`copy` permits using to mix `[]byte` and `string` arguments without explicit conversion. I removed explicit conversion to make code simpler. Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
Contributor
Author
$ git config user.name
Iskander SharipovI'm not sure I want to change it to the form that is used on GitHub, since it's just an alias, not a real addition to a name. Should I close this PR then? |
Contributor
|
I think the DCO plugin doesn't reparse changed commits. Just recreating the PR should fix this. |
Contributor
|
Creation solves the problem. I just tried it |
sougou
approved these changes
Jan 29, 2019
Contributor
|
Since I've verified that you signed, I'll just override the DCO check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copypermits using to mix[]byteandstringarguments withoutexplicit conversion. I removed explicit conversion to make code simpler.
Signed-off-by: Iskander Sharipov quasilyte@gmail.com