Split clone using consistent snapshot#4541
Conversation
Signed-off-by: Andres Taylor <antaylor@squareup.com>
Signed-off-by: Andres Taylor <antaylor@squareup.com>
systay
force-pushed
the
consistent-split-clone
branch
from
4564691 to
1d8fb20
Compare
| }) | ||
| if err != nil { | ||
| log.Error(err) | ||
| log.Errorf("%+v", err) |
There was a problem hiding this comment.
Is this intentional? Or did you change this for troubleshooting?
There was a problem hiding this comment.
I did change it for trouble shooting, but that does not mean that it needs to go back. %+v includes the stacktrace, and I think that always makes sense to log for errors. I'll remove it from here and issue a separate PR with more of these changes.
| "strings" | ||
| "time" | ||
|
|
||
| "github.com/golang/glog" |
There was a problem hiding this comment.
This should instead be vitess.io/vitess/go/vt/log. It allows us to remap the logging functions as needed.
go/vt/worker/split_clone.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func (scw *SplitCloneWorker) disableUniquenessCheckOnDestinationTablets(ctx context.Context) error { |
There was a problem hiding this comment.
I believe this is still questionable. I don't see it used in this PR. Should we remove it until it becomes official?
There was a problem hiding this comment.
Yes please remove it. I think it would be good but it's currently hard to make work.
Signed-off-by: Andres Taylor <antaylor@squareup.com>
…clone * upstream/master: docker: don't chown nonexistent /vt dir mysqlctl: add backup test for rockdb and sdi files Adding a reset of the slave on blank restore Add a special plan type for impossible queries mysqlctl: add MyRocks dir/files to backups Use recommended version combination Remove trailing whitespace
go/vt/worker/split_clone_cmd.go
Outdated
| <INPUT type="hidden" name="keyspace" value="{{.Keyspace}}"/> | ||
| <INPUT type="hidden" name="shard" value="{{.Shard}}"/> | ||
| <LABEL for="useConsistentSnapshot">Use consistent snapshot during the offline cloning:</LABEL> | ||
| <INPUT type="checkbox" id="useConsistentSnapshot" name="useConsistentSnapshot" value="false"><a href="https://dev.mysql.com/doc/refman/5.7/en/glossary.html#glos_consistent_read" target="_blank">?</a></BR> |
There was a problem hiding this comment.
that value needs to be value="true"
Signed-off-by: Andres Taylor <antaylor@squareup.com>
5 participants
No description provided.