Merged
Conversation
Signed-off-by: xichengliudui <liuduidui@beyondcent.com>
xichengliudui
force-pushed
the
Updatefunc
branch
from
7f1f6ba to
76b1a6b
Compare
Signed-off-by: xichengliudui <liuduidui@beyondcent.com>
deepthi
suggested changes
Jan 30, 2019
go/vt/vtgate/executor_select_test.go
Outdated
| executor, sbc1, sbc2, sbclookup := createExecutorEnv() | ||
|
|
||
| // Constant in IN is just a number, not a bind variable. | ||
| // Constant IN is just a number, not a bind variable. |
Collaborator
There was a problem hiding this comment.
the edit is wrong. a clearer way to say this is Constant in IN clause.
Contributor
Author
There was a problem hiding this comment.
What do I need to change?
Signed-off-by: xichengliudui <liuduidui@beyondcent.com>
xichengliudui
force-pushed
the
Updatefunc
branch
2 times, most recently
from
5cfc682 to
2b6dda4
Compare
Contributor
Author
|
@deepthi Is that what you want to see? |
sougou
approved these changes
Jan 30, 2019
Collaborator
|
See #4575 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the context, I'm sure it's wrong