Skip to content

tlstest_test: Go 1.12 / TLS 1.3 fix#4520

Merged
alainjobart merged 1 commit intovitessio:masterfrom
alainjobart:tls
Jan 14, 2019
Merged

tlstest_test: Go 1.12 / TLS 1.3 fix#4520
alainjobart merged 1 commit intovitessio:masterfrom
alainjobart:tls

Conversation

@alainjobart
Copy link
Copy Markdown
Contributor

TLS 1.3 pushes detection of some client-side handshake errors to the time of
the first read. For more details, see:
golang/go#28779 (comment)

Signed-off-by: Alain Jobart alainjobart@google.com

TLS 1.3 pushes detection of some client-side handshake errors to the time of
the first read. For more details, see:
golang/go#28779 (comment)

Signed-off-by: Alain Jobart <alainjobart@google.com>
@alainjobart alainjobart requested a review from sougou as a code owner January 12, 2019 00:10
@alainjobart
Copy link
Copy Markdown
Contributor Author

This fix should work with current go version, and prepare for the next one!

@sougou sougou requested a review from dkhenry January 12, 2019 03:51
Copy link
Copy Markdown
Contributor

@dkhenry dkhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alainjobart alainjobart merged commit b06cf39 into vitessio:master Jan 14, 2019
@alainjobart alainjobart deleted the tls branch January 14, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants