java: Use compatible netty-handler and tcnative-boring-ssl versions#4484
Merged
sougou merged 2 commits intovitessio:masterfrom Jan 26, 2019
Merged
java: Use compatible netty-handler and tcnative-boring-ssl versions#4484sougou merged 2 commits intovitessio:masterfrom
sougou merged 2 commits intovitessio:masterfrom
Conversation
added 2 commits
December 21, 2018 11:33
Signed-off-by: Leo Xuzhang Lin <llin@hubspot.com>
Signed-off-by: Leo Xuzhang Lin <llin@hubspot.com>
Contributor
|
@mpawliszyn / @harshit-gangal ping |
Member
|
It is a minor version upgrade of netty. LGTM. |
harshit-gangal
approved these changes
Jan 25, 2019
sougou
approved these changes
Jan 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the unshaded version of grpc-netty which requires the netty-handler and tcnative-boring-ssl versions to be kept in sync with gRPC.
The recommended version combination for gRPC 1.16.x is:
We ran into some compatibility issues as we are attempting to upgrade our vitess jdbc version.
https://github.com/grpc/grpc-java/blob/master/SECURITY.md#netty
A recommended alternative is to use the shaded version of grpc which will keep all these libraries in sync. Would love to hear the thoughts on that from other vitess java users.
cc @acharis