Add group specification to mysql static auth for ACL usage#4499
Merged
sougou merged 2 commits intovitessio:masterfrom Jan 6, 2019
Merged
Add group specification to mysql static auth for ACL usage#4499sougou merged 2 commits intovitessio:masterfrom
sougou merged 2 commits intovitessio:masterfrom
Conversation
Signed-off-by: Michael Hebelka <michael.hebelka@sharpspring.com>
sougou
reviewed
Jan 3, 2019
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
This looks good. Can you add tests (or enhance existing ones)?
Signed-off-by: Michael Hebelka <michael.hebelka@sharpspring.com>
sougou
approved these changes
Jan 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default table ACL implementation already has a mechanism for allowing access based either on username or groups that the caller is a member of, but it seems that only the LDAP authn mechanism lets us use these groups. This is just a simple change to also allow the static authn method to specify groups to which a user belongs.