Merged
Conversation
Signed-off-by: David Weitzman <dweitzman@pinterest.com>
This completes yuananf's work from vitessio#3683 which was split into several diffs and never fully landed. One large benefit of multi-statement support is that the "rewriteBatchedStatements" option in Java's connector-j driver doesn't work without it. There's a bug where connector-j fails to check the server capabilities and assumes multi-statement support. Signed-off-by: David Weitzman <dweitzman@pinterest.com>
sougou
approved these changes
Dec 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like @yuananf didn't have time to finish landing the from master...yuananf:multi_query_bak, some of which was committed in #3683
This PR is basically the rest of that change plus a test.
As mentioned in the commit description, my primary motivation is to get rewriteBatchedStatements working with the connector-j Java driver for much better batch write performance.