fix(usage): flag unpriced model activity instead of showing $0.00 by maria-rcks · Pull Request #11021 · pingdotgg/t3code

maria-rcks · 2026-09-10T00:44:36Z

The Usage page treated a model with no entry in the rate table as if it cost nothing: the server sets costSource: "unpriced" and counts unpricedRecords, but the client formatted the resulting zero as a literal $0.00 and never showed the unpriced coverage it already receives.

mergeUsage now carries unpricedRecords per model and exports isModelCostUnknown. Web and mobile model rows render "Unpriced" instead of $0.00 when every record for that model lacked rates, and the web cost headline says what share of records the estimate leaves out, so a mixed total reads as a lower bound.

Verified: vitest run packages/shared/src/usageMerge.test.ts 13 passed; vitest run apps/web/src/components/usage/UsagePage.test.tsx 5 passed; vp run --filter @t3tools/{shared,web,mobile,client-runtime} typecheck clean; vp lint on the five changed files clean.

Fixes #5799

UI evidence: verified in the web app against a copy of real usage data. A model whose records all lack rates (<synthetic>) now reads Unpriced with — for share instead of $0.00 / 0.0%, and the cost headline reads 372 sessions · API estimate excludes 0.1% unpriced records. Rows whose provider reported a cost of zero (costSource: providerReported) still show $0.00, which this change does not touch.

Before (main): every rate-less row reads $0.00 / 0.0%.

After (this PR): the rate-less row reads Unpriced and the cost headline names the excluded share.

Done by Claude Opus 5 (1M context) in Claude Code.

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Usage summaries now distinguish models without known pricing from models with zero cost.
- Unpriced models are labeled “Unpriced” or “no known rates” instead of appearing free.
- Token totals remain visible for unpriced models, while cost-share and USD values are shown only when pricing is available.
- Usage percentages and model ordering now accurately include unpriced records.

Models with no entry in the rate table have unknown cost, not zero cost, but the usage page rendered their $0.00 like a real figure and never surfaced the unpriced share the server already reports. Model rows whose records are all unpriced now read "Unpriced", and the cost headline says how many records the estimate leaves out. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

macroscopeapp · 2026-09-10T00:46:23Z

Approvability

Verdict: Approved at 5553634

Macroscope's review found this PR approvable — This is a narrowly scoped usage UI bug fix that distinguishes unpriced activity from genuinely free activity across web and mobile. It only propagates existing metadata and changes presentation, with tests for the merger and web output and no billing, schema, deployment, or infrastructure impact.

^{You can add or adjust custom eligibility rules. Learn more.}

coderabbitai · 2026-09-10T00:48:05Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 9852bd37-7326-467b-aa8a-608aea1c9bbf

📥 Commits

Reviewing files that changed from the base of the PR and between b7b3ef1 and 5553634.

📒 Files selected for processing (5)

apps/mobile/src/features/usage/UsageRouteScreen.tsx
apps/web/src/components/usage/UsagePage.test.tsx
apps/web/src/components/usage/UsagePage.tsx
packages/shared/src/usageMerge.test.ts
packages/shared/src/usageMerge.ts

Limit details: You’ve used all 10 included reviews currently available.

📝 Walkthrough

Walkthrough

Usage aggregation now tracks unpriced records and classifies models without known rates. Web and mobile usage views display these models as “Unpriced” instead of $0.00, while preserving token information for unpriced activity.

Changes

Usage cost quality

Layer / File(s)	Summary
Usage aggregation and classification `packages/shared/src/usageMerge.ts`, `packages/shared/src/usageMerge.test.ts`	Model totals now preserve unpriced record counts. `isModelCostUnknown` identifies models whose records lack pricing. Tests cover aggregation and classification.
Web usage cost display `apps/web/src/components/usage/UsagePage.tsx`, `apps/web/src/components/usage/UsagePage.test.tsx`	The web usage page reports unpriced coverage and labels fully unpriced model rows as “Unpriced” instead of showing `$0.00`. Tests cover rendering and token ordering.
Mobile usage cost display `apps/mobile/src/features/usage/UsageRouteScreen.tsx`	Mobile model rows show “no known rates” and “Unpriced” for models without pricing. Priced models retain existing cost displays.

Estimated code review effort: 2 (Simple) | ~10 minutes

Severity of issue fixed: Medium

Suggested reviewers: juliusmarminge, t3dotgg, stienswout

Merge Risk: ⚪ Minimal · up to 55536

Usage pages now label activity without known rates as Unpriced rather than free and identify partial cost estimates. The change is ready to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 5 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The changes satisfy issue `#5799`. They preserve unpriced record counts, label fully unpriced models as “Unpriced,” and indicate that mixed cost totals are partial lower-bound estimates across web and m…
Out of Scope Changes check	✅ Passed	All changes support the linked issue. The shared usage logic, web and mobile UI updates, and related tests are within scope.
Title check	✅ Passed	The title clearly summarizes the primary change: unpriced model activity no longer appears as $0.00.
Description check	✅ Passed	The description explains the problem, implementation, UI behavior, validation results, linked issue, and before/after evidence. It does not use the template headings or include the checklist, but it p…

Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

shivamhwp · 2026-09-10T22:38:19Z

Note: GPT-6 on behalf of shivam (@shivamhwp).

The model rows are fixed, but #5799 also covers the day breakdown. An all-unpriced day still shows $0.00 in both the provider and total columns, and its provider summary still shows $0.00 with 0.0% of cost. Carry unpriced coverage into those aggregates and distinguish unknown cost from a genuine reported zero there too. Keep partial estimates visibly marked when priced and unpriced records share a row.

Price cache creation as its own estimated component in usage summaries, the model/project/thread breakdowns and the daily thread chart, keeping unknown cache-write cost unavailable rather than zero. Carries the stacked usage work from pingdotgg#9014, pingdotgg#9015, pingdotgg#9016 and pingdotgg#9017, rebased onto main and reconciled with upstream's per-model unpriced flag (pingdotgg#11021). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

The composer shows the active thread's estimated API cost with cache-write, cache-read and fresh-token components. The server attributes transcripts to a thread through current and historical provider sessions and dedicated worktrees, and exposes a filtered usage thread breakdown that clients request only when the environment advertises it. Squashed onto current main; adopts the unpriced-model flag from pingdotgg#11021 in the model totals and the usage summary line. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Merges `upstream/main` at `02297e3db` into the fork, 35 commits from base `0f602b337`. Merge commit, not a rebase. Tracker entry: `docs/fork/upstream-merge-log.md`, 2026-09-11. `170` files landed against `166` in the upstream range; fork delta `756` files. The gap is six named files and reconciles: `ThreadStatusIndicators.test.tsx` and `sandboxControl.placement.test.tsx` landed as fork-test fixes amended into the merge, the three fork documents landed with it, and `PreviewLocalServerCard.tsx` was re-deleted per the inventory's deliberate-deletion list. `duplicate-adds.mjs` and `resolution-check.mjs` are clean — nothing landed as one side whole. ## What upstream shipped, and where it stands on Moatless ### Usable as-is These run on the fork's backend with no further work. - **A compact right-panel surface menu** (pingdotgg#11111) — the add-surface launcher goes from a card grid to keyboard-shortcut rows. This is where the fork's sandbox status badge lives, so the badge was re-stated on upstream's row rather than replayed; see the conflict notes below. - **Multiple-linked-PR badges, simplified** (pingdotgg#11104, pingdotgg#11180, pingdotgg#11101) — a thread with several links now shows the total linked count coloured by aggregate status, instead of naming a primary and counting the extras. This is **live on Moatless**: the backend serves `thread.pullRequests` and reports `threadPullRequests`, so the badge resolves. It is also a behaviour change a user will see, and it is what broke the fork's own badge test — the only thing that caught it. - **Settled threads recede in the sidebar** (pingdotgg#11101) — a settled row dims until hover or focus. Rides the settlement state Moatless already serves. - **Environments in the command palette** (pingdotgg#10722) — searching now returns environments beside threads and projects, with a subtitle. - **A blue/orange diff palette** (pingdotgg#10671) — client-side theme only. - **Question answers folded into tool activity** (pingdotgg#11014) — the chat timeline renders an answer to an agent's async question inside the tool call that asked it, rather than as a separate turn. The client half (`client-runtime/src/work-log/userInput.ts`, `shared/src/toolActivity.ts`, `MessagesTimeline.tsx`) works off data Moatless already sends. The server half is in the third bucket. - **Unpriced model activity is flagged** (pingdotgg#11021) — usage rows with tokens and no price read as unpriced instead of `$0.00`. Shared merge logic over the `server.getUsageSummary` the backend serves. - **Return to picture-in-picture when the right panel closes** (pingdotgg#11102) and **aligned floating-preview corners** (pingdotgg#10915) — both land in the hosted preview surface and both were taken; the fork's framed-runtime condition in `ThreadPreviewMiniPlayer.tsx` still covers the case upstream's `framed` check does not. - **Collapse a tool call by clicking its expanded label** (pingdotgg#11017), **provider update text fitting inside sidebar notices** (pingdotgg#11034), **no seams in the topbar scroll fade** (pingdotgg#10914), **centered PR unavailable states** (pingdotgg#11110), **no sidebar PR link icon** (pingdotgg#11179). - **Mobile** (pingdotgg#11128, pingdotgg#11127, pingdotgg#11114, pingdotgg#11115, pingdotgg#11118 / pingdotgg#11079 / reverted in pingdotgg#11098, pingdotgg#11113) — shared markdown renderer rename, composer transition and final-frame fixes, tablet close controls for files and terminal, and playback preserved across fullscreen transitions. ### Unsupported in Moatless / needs implementation - **The device hub** — the whole of pingdotgg#10677, pingdotgg#10854, pingdotgg#10855 and pingdotgg#10856: iOS simulators and Android emulators a person and an agent can share. Server side is `apps/server/src/device/` (`LocalDeviceHost.ts` drives the machine the server runs on, `SshDeviceHost.ts` drives another over SSH, `DeviceHubProxy.ts` fronts the video and accessibility streams) plus an MCP toolkit at `apps/server/src/mcp/toolkits/device/` that gives the agent tap/type/screenshot. Client side is a `device` right-panel surface (`apps/web/src/components/device/`) and a Device hosts settings page. Eight methods plus one stream, all newly declaring `UnsupportedMethodError` in `packages/contracts/src/rpc.ts`: `device.configure`, `device.list`, `device.testHost`, `device.open`, `device.close`, `device.shutdown`, `device.detail`, `device.action`, and the `subscribeDeviceState` push stream. **Nothing gates the surface on a capability.** `ChatView.tsx` passes `deviceAvailable={activeThreadRef !== null}`, so the launcher offers a Device row on every thread. `subscribeDeviceState` never resolves on Moatless, so the state stays empty, `onboardingCompleted` is false, and clicking the row opens `DeviceSetup` rather than the panel — whose first step, "Enable the device hub", calls `device.configure` and shows the refusal. A dead end a person can walk into. One additive `FEATURES.deviceHub` read on the two `deviceAvailable` props would drop the row instead; **this merge did not add it**, and it is recorded as the open work in `docs/fork/gaps.md` under _The device hub_. Implementing it on the backend is a real question rather than a stub: the hub needs Xcode or the Android SDK on whatever host it drives, and its stream is a second connection beside the RPC one. - **Label and reviewer updates without redundant reloads** (pingdotgg#11117) — optimistic cache writes in `client-runtime/src/state/pullRequests.ts` over `pullRequests.update`. Rides the `pullRequests.*` group, which Moatless does not serve and which the `pullRequests` capability already keeps off, so it changes nothing here until that group lands. - **Emphasised primary PR actions** (pingdotgg#11105) and **save a PR body with Cmd/Ctrl+Enter** (pingdotgg#10660) — same surface, same condition. - **Zed remote links accepting root paths and Windows servers** (pingdotgg#11044) — builds an SSH open target the Electron shell hands to a local editor. That path needs a desktop shell, so it does not reach this fork's browser client; `shell.openInEditor` remains unsupported. Not a fork target, listed for completeness. - **Marketing** (pingdotgg#11146, pingdotgg#11145) — `apps/marketing` is upstream's own site; inherited and inert here. ### Backend behavior to consider reproducing in Moatless Server-side fixes upstream made to its own runtime. Moatless implements the same contract, so each is worth checking against its own implementation. - **Claude launch args override the derived permission mode** (pingdotgg#11026, `apps/server/src/provider/Layers/ClaudeAdapter.ts`). Upstream derives a permission mode from the thread's settings and then appends the agent's launch args; an explicit `--permission-mode` in those args used to be overridden by the derived one instead of winning. If Moatless derives a permission mode the same way, a user who set the flag explicitly is being ignored in the same place. Cheapest of the three to check. - **Project identity resolved before legacy PR relinks** (pingdotgg#11045, `apps/server/src/orchestration/Layers/OrchestrationEngine.ts`). A legacy pull-request link is relinked to its thread on load; upstream now resolves the project's repository identity first, so a relink cannot bind a link to the wrong project when two projects share a branch name. The fork fills `thread.pullRequests` from a Task's GitHub bindings, so it has the same ordering question: the binding has to know which project it belongs to before it is attached. - **Question answers in the published activity payload** (pingdotgg#11014, `apps/server/src/orchestration/ActivityPayloadProjection.ts`). The projection now folds `projectQuestionToolInput` into the activity payload for both `mcp_tool_call` and plain tool items, which is what lets a client render the answer inside the tool call. Moatless does not report `agentActivityPublishing`, so nothing reads this today — but if it ever publishes activity, this is the shape to publish. ## Conflicts and how they were resolved 11 conflicted files, resolved on the verdicts `preflight.mjs` printed. Additive on both sides, both kept: `MessagesTimeline.tsx` (imports), `client-runtime/src/rpc/client.ts` (the fork's four subscription tags against upstream's `subscribeDeviceState`), `rightPanelStore.ts` (the fork's `sandbox` kind against upstream's `device`), `rpc.ts` and `RpcAuthorization.ts` (the fork's thread-server / sandbox / subtasks methods and scopes against upstream's eight `device.*` ones), and `ChatView.tsx` (both right-panel arms, both `onAdd*` props at the inline and sheet call sites, and upstream's extended `closePreviewPanel` under the fork's proactive preview-open effect). `PreviewEmptyState.tsx` and `ThreadPreviewMiniPlayer.tsx` took upstream's `DiscoveryList` and `rounded-[inherit]` with the fork's sandbox-read error line and framed `hasPreviewSurface` condition re-stated on top. `PreviewLocalServerCard.tsx` was a modify/delete conflict and was re-deleted. `pnpm-lock.yaml` auto-merged this time, so `--theirs` had nothing to do; it was reset to `upstream/main` and the fork edges re-derived with `vp i`. Two findings worth reading: **A `converged` delta can lose the line it was anchored to.** pingdotgg#11111 rebuilt the add-surface menu from cards into rows, and the fork's sandbox badge in `RightPanelTabs.tsx` (7 conflicts, the hard one) had no literal home left. It was re-stated on upstream's row — between the label and the `Kbd`, additively, no prop threaded and no upstream JSX re-indented — rather than replayed. The fork's placement test caught the other half: upstream's rows stopped rendering the action `description` at all, in its own Device action too, so the test was asserting on markup nobody emits. It now asserts the rendered label. **A silent auto-merge changed behaviour with no marker, no type error and no resolution-check hit.** pingdotgg#11104 and pingdotgg#11180 changed what the multi-PR badge counts and hoisted `state` onto both badge shapes with a new `draft` colour. Only the fork's `ThreadStatusIndicators.test.tsx` failed, on `+1` against `+2`. Fixture gained the now-required `state`; the expectation was updated to upstream's semantics. ## Inventory and gaps - New `pathPolicy` rows for the paths this merge decided without a cached verdict: `right-panel-surfaces`, `client-runtime-rpc-client`, `thread-status-indicators`, `fork-sandbox-components`. `inventory-check.mjs` is clean. - New gaps entry: _The device hub_, under **Methods the backend does not dispatch**. It names the nine union entries holding it open, the missing `FEATURES.deviceHub` gate, and what closing it costs. - Owned-concern sweep: 11 keyword hits, all false positives. Ten are device-hub files matching the `client-identity` concern on `host`/`proxy` — that concern is about device *pairing* identity, not simulators — and the eleventh, `McpProviderSession.test.ts`, matched on `session`. No concern entry. ## Verification `verify.mjs`: `duplicate-adds`, `tripwires`, `resolution-check`, `unsupported-methods`, `fmt:check`, `lint` and `typecheck` pass. `test` is red on **one** package, and it is not this merge: `@t3tools/desktop`'s `scripts/browser-secret-native.test.mjs > bundled libsecret helper` cannot find `libsecret-1` in this sandbox's pkg-config path. A missing system package, not a code defect — 1 file failed of 102, and the standing entry is in `docs/fork/gaps.md` under _The desktop suite needs libsecret_. One thing to know about reading that log: four packages did not finish under `vp run -r test` and were each re-run alone — mobile `157` files, `t3` `315`, web `389`, relay `30`, all passing. The truncated parallel pass reported a failure that does not exist, `shikiReviewHighlighter.test.ts > initializes source and snippet highlighting without a warmup`, which passes in the alone run and which neither side of this merge touches. The retry lines at the end of the log are the result; the parallel output above them is not. Not reported green. The fork has no CI on pull requests (`docs/fork/gaps.md`, _Nothing checks a pull request_), so this is the whole of the evidence. --- Moatless task: https://moatless.soaplabstest.com/tasks/211b4f8f-7de2-46c8-9ded-330d0cda4add

@maria-rcks

## What's Changed * fix(pr): update labels and reviewers without redundant reloads by @maria-rcks in pingdotgg/t3code#11117 * fix(chat): fold question answers into tool activity by @maria-rcks in pingdotgg/t3code#11014 * fix(usage): flag unpriced model activity instead of showing $0.00 by @maria-rcks in pingdotgg/t3code#11021 * fix(server): let Claude launch args override the derived permission mode by @maria-rcks in pingdotgg/t3code#11026 * fix(editors): accept root paths and Windows servers in Zed remote links by @maria-rcks in pingdotgg/t3code#11044 * fix(web): center pull request unavailable states by @maria-rcks in pingdotgg/t3code#11110 * fix(web): remove sidebar pull request link icon by @maria-rcks in pingdotgg/t3code#11179 * fix(ui): color linked pr counts by aggregate status by @maria-rcks in pingdotgg/t3code#11180 * fix(preview): render website favicons for browser tool activity by @maria-rcks in pingdotgg/t3code#11032 * fix(web): simplify pull request summary sections by @maria-rcks in pingdotgg/t3code#10612 * fix(web): preserve drafts when compacting context by @maria-rcks in pingdotgg/t3code#11103 * fix(server): queue messages during context compaction by @maria-rcks in pingdotgg/t3code#11107 * perf(web): format minimap previews only when opened by @juliusmarminge in pingdotgg/t3code#11181 * perf(web): reuse completed Markdown prefixes while streaming by @juliusmarminge in pingdotgg/t3code#11193 * perf(web): resume syntax highlighting from completed lines by @juliusmarminge in pingdotgg/t3code#11196 * perf(web): preserve completed code-line DOM while streaming by @juliusmarminge in pingdotgg/t3code#11198 * perf(web): huge-thread switch no longer blanks the chat pane by @juliusmarminge in pingdotgg/t3code#11169 **Full Changelog**: pingdotgg/t3code@v0.0.41-nightly.20260911.1520...v0.0.41-nightly.20260911.1533 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.41-nightly.20260911.1533

github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 10, 2026

macroscopeapp Bot approved these changes Sep 10, 2026

View reviewed changes

maria-rcks merged commit 48654c1 into pingdotgg:main Sep 11, 2026
21 checks passed

This was referenced Sep 11, 2026

feat(usage): add thread and subagent breakdown #9016

Open

feat(web): link usage rows to their threads #9017

Open

saphid mentioned this pull request Sep 11, 2026

feat(usage): surface estimated cache-write cost #9018

Open

This was referenced Sep 11, 2026

feat(web): show thread API cost in composer #9136

Open

perf(usage): serve durable snapshots during background refresh #9308

Open

feat(usage): break down usage by project #9015

Draft

Navigation Menu

Uh oh!

fix(usage): flag unpriced model activity instead of showing $0.00 - #11021

fix(usage): flag unpriced model activity instead of showing $0.00#11021
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:fix/usage-unpriced-cost-5799

maria-rcks commented Sep 10, 2026 •

edited

Loading

Uh oh!

macroscopeapp Bot commented Sep 10, 2026

Uh oh!

coderabbitai Bot commented Sep 10, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

shivamhwp commented Sep 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

maria-rcks commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

macroscopeapp Bot commented Sep 10, 2026

Approvability

Uh oh!

coderabbitai Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

shivamhwp commented Sep 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

maria-rcks commented Sep 10, 2026 •

edited

Loading

coderabbitai Bot commented Sep 10, 2026 •

edited

Loading