fix(mobile): keep Android markdown icons aligned with text - #11079
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a localized Android markdown rendering fix that keeps inline icons aligned, preserves block spacing, and cleans injected selection whitespace. Production changes stay within the markdown component and are accompanied by focused TypeScript and Robolectric tests. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughAndroid markdown rendering now uses native blocks for all chunks. Android block spacing is calculated by document structure, and copied selections remove inline images with their injected spacers. Composer documentation describes Android text selection and full-message copying. ChangesAndroid Markdown selection
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: Merge Risk: ⚪ Minimal · up to Android Markdown spacing and selection-copy behavior are covered for the changed cases, with no remaining merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 7 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Note: GPT-6 on behalf of shivam (@shivamhwp). The wrapping fix works: Go icons stay with their filenames, including wrapped and nested list items. File navigation, paragraph/list-item selection, and whole-message copy behave as expected. One minor issue remains with native selection copy. The added nonbreaking space is copied along with the label. Selecting and copying the first list item produces Consider removing the injected spacing character alongside its inline image in the native copy sanitizer, while preserving spaces authored in the message. Whole-message copy is unaffected. |
|
@shivamhwp Fixed in 66e9443. The Android copy sanitizer now removes the one injected NBSP immediately following an inline image, including when selection begins after the image. Authored whitespace and literal object-replacement characters without image spans are preserved. Added four focused Robolectric tests on API 36, all passing, and rebuilt the Android debug app successfully. The emulator still renders the wrapped Go references correctly. This native sanitizer change needs a new Android build; an older installed binary will keep the previous copy behavior. |
## What's Changed * fix(mobile): keep Android markdown icons aligned with text by @SunkenInTime in pingdotgg/t3code#11079 * Revert "fix(mobile): keep Android markdown icons aligned with text" by @juliusmarminge in pingdotgg/t3code#11098 **Full Changelog**: pingdotgg/t3code@v0.0.41-nightly.20260910.1486...v0.0.41-nightly.20260910.1507 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.41-nightly.20260910.1507
Android renders inline Go/file icons on unrelated lines in Markdown lists, even with #10983 applied. Reproduced on upstream
d29c56a5c4with a Pixel 9 Pro / Android API 36 emulator and a synthetic version of the reported message.Use the existing block renderer on Android so paragraph/list spacer line heights no longer share one native text layout. Keep the existing heading and paragraph spacing through one shared spacing helper. Add a nonbreaking space to keep each inline icon with its label when wrapping; the Android selection sanitizer removes that injected spacer together with the icon, while preserving authored whitespace. Native selection is now scoped to a paragraph or list item; the message copy button still copies the whole message. This is documented in the user guide.
The shared renderer covers messages and Markdown file previews. The change is Android-only, with no provider, wire-contract, or connection-mode changes.
Validation: clean Metro before/after bundles, repeated fixture loads, wrapped Go references, external-link icons, native text selection and file-reference navigation. Mobile typecheck and 136 focused Markdown/feed tests passed. Review follow-up verification includes all 35 Markdown tests, four Android API 36 Robolectric copy tests, and a rebuilt Android debug app. Targeted lint has no errors (two existing warnings in untouched code); formatting passed. The sanitizer change requires a new native Android build. The other reported activity-label overlaps did not reproduce on current upstream; this PR makes no claim to fix every timing-dependent overlap from the old Android release.
Model: GPT-6. Harness: Codex.
Summary by CodeRabbit
Bug Fixes
Documentation