Skip to content

feat(web): use a compact right-panel surface menu - #11111

Merged
maria-rcks merged 4 commits into
pingdotgg:mainfrom
maria-rcks:t3code/adopt-right-panel-menu
Sep 10, 2026
Merged

feat(web): use a compact right-panel surface menu#11111
maria-rcks merged 4 commits into
pingdotgg:mainfrom
maria-rcks:t3code/adopt-right-panel-menu

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Replaces the empty right-panel card grid with a compact surface list. Unavailable options show dimmed shortcut keys, with explanations available in focusable tooltips. Preserves existing actions, keyboard handling, and browser profile selection. Disables glass blur at 100% opacity and uses the shared workspace toolbar height for the diff header and toast offset.

Verified in the real web client in light and dark themes at 1280×800 and the narrow sheet at 900×700: launcher and terminal open/close, keyboard activation, and focusable unavailable-option tooltips. All 49 focused panel, toast, and settings tests and web typecheck pass; targeted lint has only existing warnings. Verified the opacity setting at 100% disables blur and returning to 80% restores it in both themes. Desktop browser profile selection is unverified.

before: right-panel cards, dark

before: right-panel cards, light

compact menu before and after disabled shortcuts, dark and light

terminal opened from the compact menu and closed through confirmation

Built with GPT-6 in Codex through T3 Code.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 10, 2026
Comment thread apps/web/src/components/RightPanelTabs.tsx Outdated
@macroscopeapp

macroscopeapp Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR changes the default right-panel surface launcher from cards to a compact menu, including its layout, disabled-option behavior, and keyboard interaction. It also adjusts shared titlebar/toast sizing and glass rendering, so the product-default change warrants human review.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 595b2f1f-d028-45ed-8bbd-c2e71454e373

📥 Commits

Reviewing files that changed from the base of the PR and between 1fb78dd and f48b40a.

📒 Files selected for processing (4)
  • apps/web/src/components/DiffPanelShell.tsx
  • apps/web/src/components/RightPanelTabs.tsx
  • apps/web/src/components/ui/toast.tsx
  • apps/web/src/routes/__root.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The right-panel empty state changes to a compact single-column list. Workspace offsets now use the topbar height variable. Glass appearance synchronization updates the blur property with opacity changes.

Changes

Workspace UI

Layer / File(s) Summary
Launcher layout and action definitions
apps/web/src/components/RightPanelTabs.tsx
The launcher removes action descriptions and card-specific styles. The empty state uses a single-column list with updated comments and heading text.
Surface rows and keyboard behavior
apps/web/src/components/RightPanelTabs.tsx
Available surfaces render as compact rows with inline shortcuts. The browser profile chooser is centered at the row edge. Unavailable surfaces render as focusable muted rows with DisabledReasonTooltip. Enter-key activation now requires launcher-container focus.
Workspace-aligned offsets
apps/web/src/components/DiffPanelShell.tsx, apps/web/src/components/ui/toast.tsx
The Electron diff header and toast viewport use --workspace-topbar-height instead of a fixed 52px offset.
Glass appearance synchronization
apps/web/src/routes/__root.tsx
GlassAppearanceSync sets --glass-blur to 0px at full opacity and removes the property otherwise.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: juliusmarminge, stienswout, t3dotgg

Merge Risk: ⚪ Minimal · up to f48b4

The PR replaces the right-panel card grid with a compact surface list and aligns workspace offsets and glass rendering with shared settings. The supplied checks show the primary web flows and tests passing, with no actionable merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the primary change: replacing the right-panel surface cards with a compact menu.
Description check ✅ Passed The description explains the main changes, verification results, UI behavior, screenshots, and video. It is mostly complete, although it does not use explicit "Why" or "Checklist" headings.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 10, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review September 10, 2026 19:24

Dismissing prior approval to re-evaluate f48b40a

@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Sep 10, 2026
@maria-rcks
maria-rcks merged commit dfa345b into pingdotgg:main Sep 10, 2026
24 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 11, 2026
## What's Changed
* fix(ui): simplify multiple linked pull request badges by @maria-rcks in pingdotgg/t3code#11104
* fix(preview): return to pip when closing the right panel by @maria-rcks in pingdotgg/t3code#11102
* fix: quiet settled threads and simplify PR badges by @juliusmarminge in pingdotgg/t3code#11101
* fix(web): emphasize primary pull request actions by @juliusmarminge in pingdotgg/t3code#11105
* fix(web): prevent seams in the topbar scroll fade by @caezium in pingdotgg/t3code#10914
* fix(web): fit provider update text inside sidebar notices by @MatthewFeroz in pingdotgg/t3code#11034
* fix(web): align floating browser preview corners by @caezium in pingdotgg/t3code#10915
* fix(web): save PR body edits with Cmd/Ctrl+Enter by @flamboh in pingdotgg/t3code#10660
* fix(web): collapse a tool call by clicking its expanded label by @maria-rcks in pingdotgg/t3code#11017
* feat(devices): add simulator and emulator support by @juliusmarminge in pingdotgg/t3code#10677
* feat(devices): scope targets and sessions to their hosts by @juliusmarminge in pingdotgg/t3code#10854
* feat(devices): target concurrent agent sessions across hosts by @juliusmarminge in pingdotgg/t3code#10855
* feat(devices): connect simulator hosts over SSH by @juliusmarminge in pingdotgg/t3code#10856
* feat(web): use a compact right-panel surface menu by @maria-rcks in pingdotgg/t3code#11111
* fix(mobile): keep Android markdown icons aligned by @none23 in pingdotgg/t3code#11118
* fix(mobile): add close controls to tablet files and terminal by @juliusmarminge in pingdotgg/t3code#11115
* fix(mobile): preserve the final composer animation frame by @juliusmarminge in pingdotgg/t3code#11114
* fix(mobile): keep composer transitions aligned by @juliusmarminge in pingdotgg/t3code#11127
* refactor(mobile): name shared markdown renderer without iOS suffixes by @SunkenInTime in pingdotgg/t3code#11128
* fix(media): preserve playback during fullscreen transitions by @maria-rcks in pingdotgg/t3code#11113
* fix(marketing): redirect /app to app.t3.codes by @t3-code[bot] in pingdotgg/t3code#11145
* chore(marketing): update to 300k users and 22k stars by @t3-code[bot] in pingdotgg/t3code#11146
* feat(command-palette): show environments in search results by @Cyberlane in pingdotgg/t3code#10722

## New Contributors
* @Cyberlane made their first contribution in pingdotgg/t3code#10722

**Full Changelog**: pingdotgg/t3code@v0.0.41-nightly.20260910.1507...v0.0.41-nightly.20260911.1520

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.41-nightly.20260911.1520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant