Skip to content

fix(web): emphasize primary pull request actions - #11105

Merged
juliusmarminge merged 1 commit into
t3code/mute-settled-thread-actionsfrom
t3code/primary-pr-actions
Sep 10, 2026
Merged

fix(web): emphasize primary pull request actions#11105
juliusmarminge merged 1 commit into
t3code/mute-settled-thread-actionsfrom
t3code/primary-pr-actions

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 10, 2026

Copy link
Copy Markdown
Member

The PR header rendered its main actions as ghost buttons, and Merge and Ready for review hid their icons at wider widths. Resolve conflicts, Ready for review, Enable auto-merge, and Merge now use primary styling with consistently visible icons. This matches the existing Merge stack action. Narrow headers retain icon-only controls and their accessible labels.

Applies to the shared web/desktop PR detail panel, including the pull request browser and thread side panel. Action selection, confirmations, and enabled/disabled behavior are unchanged.

Stacked above #11101.

Verified with web typecheck, targeted lint with existing warnings, all 100 PR-detail logic tests, and the real web app. Before and after use the same PR, viewport, and panel state. No animation or interaction behavior changed.

Before After
Before: ghost merge action without an icon After: primary merge action with a visible icon

Model: GPT-6. Harness: Codex.

@juliusmarminge
juliusmarminge added this pull request to stack #11106 September 10, 2026 18:17
@cursor

cursor Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 10, 2026
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 2af2eeca-4d7f-4cab-9e27-d5b65529bb56

📥 Commits

Reviewing files that changed from the base of the PR and between 420bdd9 and 29dabf6.

📒 Files selected for processing (1)
  • apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The pull request action buttons now use the default variant. The Ready for review and Merge buttons always display their icons, including in narrow header layouts.

Changes

Pull request action presentation

Layer / File(s) Summary
Action button presentation
apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx
Resolve conflicts, Ready for review, Enable auto-merge, and Merge now use the default button variant. Ready for review and Merge always render their icons.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: bil0000, maria-rcks

Merge Risk: ⚪ Minimal · up to d3d62

This is a presentation-only update to make primary pull request actions more prominent and keep icons visible in narrow layouts. No merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: emphasizing primary pull request actions in the web interface.
Description check ✅ Passed The description explains what changed, why it changed, the affected UI, validation performed, and includes before-and-after screenshots. It does not include the template's explicit Checklist section, …
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/primary-pr-actions

Comment @coderabbitai help to get the list of available commands.

@macroscopeapp

macroscopeapp Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 29dabf6

Macroscope's review found this PR approvable — This one-file UI change only makes existing pull-request actions more prominent and keeps icons visible across widths. Action logic, confirmation behavior, and product configuration defaults remain unchanged.

No code changes detected at d3d6246. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.6 KiB 15.1 KiB
Codex Thread snapshot wire 7.0 KiB 7.3 KiB
Codex Live turn WebSocket wire 6.5 KiB 7.8 KiB
Codex Live turn WebSocket decoded 57.0 KiB 66.4 KiB
Codex Live turn messages 8 21
Claude Total thread wire 13.6 KiB 15.1 KiB
Claude Thread snapshot wire 7.1 KiB 7.3 KiB
Claude Live turn WebSocket wire 6.5 KiB 7.8 KiB
Claude Live turn WebSocket decoded 57.8 KiB 66.4 KiB
Claude Live turn messages 9 21

Baseline: unavailable · PR result: d3d6246 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@juliusmarminge

Copy link
Copy Markdown
Member Author

Reviewed CodeRabbit's docstring-coverage warning. This diff changes button variants and icon classes inside the existing PR detail component; it adds no function or behavior requiring documentation. Per the repository guidance, I am not adding a component docstring that repeats the code solely for the coverage suggestion. Current-head checks pass or are skipped, and there are no review threads to resolve. Cursor Bugbot reported that it is paused at the team's spend limit; CodeRabbit completed and Macroscope approved.

@juliusmarminge
juliusmarminge force-pushed the t3code/primary-pr-actions branch from 29dabf6 to d3d6246 Compare September 10, 2026 18:29
@cursor

cursor Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@juliusmarminge
juliusmarminge merged commit f814983 into main Sep 10, 2026
32 of 43 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/primary-pr-actions branch September 10, 2026 18:35
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 11, 2026
## What's Changed
* fix(ui): simplify multiple linked pull request badges by @maria-rcks in pingdotgg/t3code#11104
* fix(preview): return to pip when closing the right panel by @maria-rcks in pingdotgg/t3code#11102
* fix: quiet settled threads and simplify PR badges by @juliusmarminge in pingdotgg/t3code#11101
* fix(web): emphasize primary pull request actions by @juliusmarminge in pingdotgg/t3code#11105
* fix(web): prevent seams in the topbar scroll fade by @caezium in pingdotgg/t3code#10914
* fix(web): fit provider update text inside sidebar notices by @MatthewFeroz in pingdotgg/t3code#11034
* fix(web): align floating browser preview corners by @caezium in pingdotgg/t3code#10915
* fix(web): save PR body edits with Cmd/Ctrl+Enter by @flamboh in pingdotgg/t3code#10660
* fix(web): collapse a tool call by clicking its expanded label by @maria-rcks in pingdotgg/t3code#11017
* feat(devices): add simulator and emulator support by @juliusmarminge in pingdotgg/t3code#10677
* feat(devices): scope targets and sessions to their hosts by @juliusmarminge in pingdotgg/t3code#10854
* feat(devices): target concurrent agent sessions across hosts by @juliusmarminge in pingdotgg/t3code#10855
* feat(devices): connect simulator hosts over SSH by @juliusmarminge in pingdotgg/t3code#10856
* feat(web): use a compact right-panel surface menu by @maria-rcks in pingdotgg/t3code#11111
* fix(mobile): keep Android markdown icons aligned by @none23 in pingdotgg/t3code#11118
* fix(mobile): add close controls to tablet files and terminal by @juliusmarminge in pingdotgg/t3code#11115
* fix(mobile): preserve the final composer animation frame by @juliusmarminge in pingdotgg/t3code#11114
* fix(mobile): keep composer transitions aligned by @juliusmarminge in pingdotgg/t3code#11127
* refactor(mobile): name shared markdown renderer without iOS suffixes by @SunkenInTime in pingdotgg/t3code#11128
* fix(media): preserve playback during fullscreen transitions by @maria-rcks in pingdotgg/t3code#11113
* fix(marketing): redirect /app to app.t3.codes by @t3-code[bot] in pingdotgg/t3code#11145
* chore(marketing): update to 300k users and 22k stars by @t3-code[bot] in pingdotgg/t3code#11146
* feat(command-palette): show environments in search results by @Cyberlane in pingdotgg/t3code#10722

## New Contributors
* @Cyberlane made their first contribution in pingdotgg/t3code#10722

**Full Changelog**: pingdotgg/t3code@v0.0.41-nightly.20260910.1507...v0.0.41-nightly.20260911.1520

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.41-nightly.20260911.1520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant