Skip to content

fix(preview): return to pip when closing the right panel - #11102

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/preview-close-returns-pip
Sep 10, 2026
Merged

fix(preview): return to pip when closing the right panel#11102
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/preview-close-returns-pip

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

closing the right panel with a browser selected now returns that browser to pip, including after restoring it from pip. the preview toggle shares the panel close handler, covering the panel button, keyboard toggle, and sheet dismissal while preserving browser-tab close behavior.

validation: 191 existing tests passed across chat logic, preview view, mini player state, and right panel state; web typecheck, scoped lint, and formatting passed (existing warnings). github ci passed on c4b7c8c; two independent gpt-6-astra reviews found no code issues. no unresolved github review threads.

recording: recreated browser content, as requested, rendered with the actual preview panel and mini player. the existing panel close handler returns the preview to pip twice, including after restoring it to the panel. electron guest rendering is not exercised by this recreation.

closing the right panel returns the preview to pip, twice

written by gpt-6 using codex.

Summary by CodeRabbit

  • New Features

    • Closing the preview panel now opens the preview mini player for the active resource.
  • Bug Fixes

    • Preview panel state is now cleared consistently when the panel is closed or toggled.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 10, 2026
@maria-rcks
maria-rcks marked this pull request as ready for review September 10, 2026 17:58
@macroscopeapp

macroscopeapp Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c4b7c8c

Macroscope's review found this PR approvable — This is a narrowly scoped one-file UI bug fix that preserves an active preview in the existing mini-player when the right panel closes. Other panel types and existing browser-tab cleanup behavior remain unchanged.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 01f377e8-0b1c-4957-99f1-e96ec7f41e34

📥 Commits

Reviewing files that changed from the base of the PR and between 3836890 and c4b7c8c.

📒 Files selected for processing (1)
  • apps/web/src/components/ChatView.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The preview panel close flow now opens the active preview resource in the mini player before clearing the maximized thread key and closing the right panel.

Changes

Preview panel handoff

Layer / File(s) Summary
Close preview and open mini player
apps/web/src/components/ChatView.tsx
closePreviewPanel opens the active preview resource in the mini player, clears the maximized thread key, and closes the panel. togglePreviewPanel uses this callback for its close branch and dependency list.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: t3dotgg, juliusmarminge, bil0000

Merge Risk: ⚪ Minimal · up to c4b7c

Closing a preview panel now returns the selected resource to the mini player while preserving ordinary panel-close behavior. The change is ready to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: returning the preview to PiP when the right panel closes.
Description check ✅ Passed The description explains the behavior change, affected interactions, validation results, and UI recording. It does not use the template headings or include the checklist, but it contains the required …
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@maria-rcks
maria-rcks merged commit 0882431 into pingdotgg:main Sep 10, 2026
27 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 11, 2026
## What's Changed
* fix(ui): simplify multiple linked pull request badges by @maria-rcks in pingdotgg/t3code#11104
* fix(preview): return to pip when closing the right panel by @maria-rcks in pingdotgg/t3code#11102
* fix: quiet settled threads and simplify PR badges by @juliusmarminge in pingdotgg/t3code#11101
* fix(web): emphasize primary pull request actions by @juliusmarminge in pingdotgg/t3code#11105
* fix(web): prevent seams in the topbar scroll fade by @caezium in pingdotgg/t3code#10914
* fix(web): fit provider update text inside sidebar notices by @MatthewFeroz in pingdotgg/t3code#11034
* fix(web): align floating browser preview corners by @caezium in pingdotgg/t3code#10915
* fix(web): save PR body edits with Cmd/Ctrl+Enter by @flamboh in pingdotgg/t3code#10660
* fix(web): collapse a tool call by clicking its expanded label by @maria-rcks in pingdotgg/t3code#11017
* feat(devices): add simulator and emulator support by @juliusmarminge in pingdotgg/t3code#10677
* feat(devices): scope targets and sessions to their hosts by @juliusmarminge in pingdotgg/t3code#10854
* feat(devices): target concurrent agent sessions across hosts by @juliusmarminge in pingdotgg/t3code#10855
* feat(devices): connect simulator hosts over SSH by @juliusmarminge in pingdotgg/t3code#10856
* feat(web): use a compact right-panel surface menu by @maria-rcks in pingdotgg/t3code#11111
* fix(mobile): keep Android markdown icons aligned by @none23 in pingdotgg/t3code#11118
* fix(mobile): add close controls to tablet files and terminal by @juliusmarminge in pingdotgg/t3code#11115
* fix(mobile): preserve the final composer animation frame by @juliusmarminge in pingdotgg/t3code#11114
* fix(mobile): keep composer transitions aligned by @juliusmarminge in pingdotgg/t3code#11127
* refactor(mobile): name shared markdown renderer without iOS suffixes by @SunkenInTime in pingdotgg/t3code#11128
* fix(media): preserve playback during fullscreen transitions by @maria-rcks in pingdotgg/t3code#11113
* fix(marketing): redirect /app to app.t3.codes by @t3-code[bot] in pingdotgg/t3code#11145
* chore(marketing): update to 300k users and 22k stars by @t3-code[bot] in pingdotgg/t3code#11146
* feat(command-palette): show environments in search results by @Cyberlane in pingdotgg/t3code#10722

## New Contributors
* @Cyberlane made their first contribution in pingdotgg/t3code#10722

**Full Changelog**: pingdotgg/t3code@v0.0.41-nightly.20260910.1507...v0.0.41-nightly.20260911.1520

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.41-nightly.20260911.1520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant