fix(preview): return to pip when closing the right panel - #11102
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped one-file UI bug fix that preserves an active preview in the existing mini-player when the right panel closes. Other panel types and existing browser-tab cleanup behavior remain unchanged. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe preview panel close flow now opens the active preview resource in the mini player before clearing the maximized thread key and closing the right panel. ChangesPreview panel handoff
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to Closing a preview panel now returns the selected resource to the mini player while preserving ordinary panel-close behavior. The change is ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
## What's Changed * fix(ui): simplify multiple linked pull request badges by @maria-rcks in pingdotgg/t3code#11104 * fix(preview): return to pip when closing the right panel by @maria-rcks in pingdotgg/t3code#11102 * fix: quiet settled threads and simplify PR badges by @juliusmarminge in pingdotgg/t3code#11101 * fix(web): emphasize primary pull request actions by @juliusmarminge in pingdotgg/t3code#11105 * fix(web): prevent seams in the topbar scroll fade by @caezium in pingdotgg/t3code#10914 * fix(web): fit provider update text inside sidebar notices by @MatthewFeroz in pingdotgg/t3code#11034 * fix(web): align floating browser preview corners by @caezium in pingdotgg/t3code#10915 * fix(web): save PR body edits with Cmd/Ctrl+Enter by @flamboh in pingdotgg/t3code#10660 * fix(web): collapse a tool call by clicking its expanded label by @maria-rcks in pingdotgg/t3code#11017 * feat(devices): add simulator and emulator support by @juliusmarminge in pingdotgg/t3code#10677 * feat(devices): scope targets and sessions to their hosts by @juliusmarminge in pingdotgg/t3code#10854 * feat(devices): target concurrent agent sessions across hosts by @juliusmarminge in pingdotgg/t3code#10855 * feat(devices): connect simulator hosts over SSH by @juliusmarminge in pingdotgg/t3code#10856 * feat(web): use a compact right-panel surface menu by @maria-rcks in pingdotgg/t3code#11111 * fix(mobile): keep Android markdown icons aligned by @none23 in pingdotgg/t3code#11118 * fix(mobile): add close controls to tablet files and terminal by @juliusmarminge in pingdotgg/t3code#11115 * fix(mobile): preserve the final composer animation frame by @juliusmarminge in pingdotgg/t3code#11114 * fix(mobile): keep composer transitions aligned by @juliusmarminge in pingdotgg/t3code#11127 * refactor(mobile): name shared markdown renderer without iOS suffixes by @SunkenInTime in pingdotgg/t3code#11128 * fix(media): preserve playback during fullscreen transitions by @maria-rcks in pingdotgg/t3code#11113 * fix(marketing): redirect /app to app.t3.codes by @t3-code[bot] in pingdotgg/t3code#11145 * chore(marketing): update to 300k users and 22k stars by @t3-code[bot] in pingdotgg/t3code#11146 * feat(command-palette): show environments in search results by @Cyberlane in pingdotgg/t3code#10722 ## New Contributors * @Cyberlane made their first contribution in pingdotgg/t3code#10722 **Full Changelog**: pingdotgg/t3code@v0.0.41-nightly.20260910.1507...v0.0.41-nightly.20260911.1520 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.41-nightly.20260911.1520
closing the right panel with a browser selected now returns that browser to pip, including after restoring it from pip. the preview toggle shares the panel close handler, covering the panel button, keyboard toggle, and sheet dismissal while preserving browser-tab close behavior.
validation: 191 existing tests passed across chat logic, preview view, mini player state, and right panel state; web typecheck, scoped lint, and formatting passed (existing warnings). github ci passed on c4b7c8c; two independent gpt-6-astra reviews found no code issues. no unresolved github review threads.
recording: recreated browser content, as requested, rendered with the actual preview panel and mini player. the existing panel close handler returns the preview to pip twice, including after restoring it to the panel. electron guest rendering is not exercised by this recreation.
written by gpt-6 using codex.
Summary by CodeRabbit
New Features
Bug Fixes