Skip to content

perf(web): resume syntax highlighting from completed lines - #11196

Merged
juliusmarminge merged 1 commit into
legend-perf/incremental-markdownfrom
legend-perf/streaming-highlighting
Sep 11, 2026
Merged

perf(web): resume syntax highlighting from completed lines#11196
juliusmarminge merged 1 commit into
legend-perf/incremental-markdownfrom
legend-perf/streaming-highlighting

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 11, 2026

Copy link
Copy Markdown
Member

Growing code fences tokenize every earlier line on each streamed chunk. Resume Shiki from the grammar state after the last completed line and tokenize the changing suffix. This adapts the incremental document work in Legend Code using Shiki's grammar-state API.

Completed messages keep the existing cached path. Non-append edits invalidate the prefix; CR/CRLF, plain text, ANSI and missing grammar state fall back to full highlighting. Multiline syntax and embedded languages retain their grammar context.

Five alternating production-browser runs at 1440 × 1000, each with 10 warm-up updates and 40 measured updates. The fixture starts with 200 TypeScript lines and appends one line per update.

Synchronous client update Base, including parser layer This layer
Median of run medians 170.8 ms 120.3 ms
Median of run p95s 211.5 ms 152.6 ms

The median reduction is 29.6%; every paired run improved. This is a deliberately heavy client-rendering workload, not provider throughput or typical-user latency. Probe and samples. The codeToHtmlMs counter excludes direct codeToHast work; the complete synchronous update is the comparison metric.

100 focused Markdown/highlighting tests and web typecheck pass. Actual WASM highlighting matches full output through streaming prefixes across 11 languages and two themes, including multiline comments, strings, heredocs, embedded HTML, edits, truncation and fallback languages. Targeted lint reports two warnings in unchanged code.

This improves streaming code in web and Electron's shared renderer. It does not change mobile, file/diff viewers, the wire protocol or provider adapters. Both hosted and locally served web clients use this code; no transport timing claim is made.

Before:

Before: highlighted TypeScript at the reading position

After:

After: matching highlighted TypeScript and layout

Before streaming:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/2fd3e3038ca91da9/highlight-before-realtime.webm

After streaming:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/cd992d3d57a131d6/highlight-after-realtime.webm

The videos reconstruct Chrome screenshot frames with their original timestamps, retaining gaps between paints. They are separate from the unrecorded timing runs. The same synthetic fixture and viewport are used; no private transcripts or credentials are included. No observed new blank frames or color flashes during the exercised stream.

Integration follow-up: rebased on current main; the integrated stack passes 94 focused Markdown/highlighting tests and 159 timeline tests, plus web typecheck. The timing table remains pinned to the original measured builds.

Model: GPT-6. Harness: Codex.

@juliusmarminge
juliusmarminge added this pull request to stack #11194 September 11, 2026 05:13
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 11, 2026
@juliusmarminge
juliusmarminge marked this pull request as ready for review September 11, 2026 05:35
@macroscopeapp

macroscopeapp Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The PR replaces full streaming syntax highlighting with a stateful grammar/HAST-resumption path in the production chat renderer. Tests cover many languages, themes, edits, and fallbacks, but the runtime algorithm is sufficiently nontrivial that its streaming behavior warrants human review.

No code changes detected at ba2471b. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge force-pushed the legend-perf/streaming-highlighting branch from 6ab8db7 to ba2471b Compare September 11, 2026 05:44
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.6 KiB 15.1 KiB
Codex Thread snapshot wire 7.0 KiB 7.3 KiB
Codex Live turn WebSocket wire 6.6 KiB 7.8 KiB
Codex Live turn WebSocket decoded 57.1 KiB 66.4 KiB
Codex Live turn messages 10 21
Claude Total thread wire 13.6 KiB 15.1 KiB
Claude Thread snapshot wire 7.1 KiB 7.3 KiB
Claude Live turn WebSocket wire 6.5 KiB 7.8 KiB
Claude Live turn WebSocket decoded 57.8 KiB 66.4 KiB
Claude Live turn messages 9 21

Baseline: unavailable · PR result: ba2471b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 5c212aaa-db8b-4400-8ed0-2430509ef6c0

📥 Commits

Reviewing files that changed from the base of the PR and between a660ad9 and ba2471b.

📒 Files selected for processing (3)
  • apps/web/src/components/ChatMarkdown.tsx
  • apps/web/src/lib/incrementalHighlighting.test.ts
  • apps/web/src/lib/incrementalHighlighting.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The change adds incremental syntax highlighting for streaming code blocks. It preserves grammar state across complete lines, falls back to full highlighting when needed, and adds tests for languages, themes, edits, truncation, plaintext, ANSI-like input, and line endings.

Changes

Incremental syntax highlighting

Layer / File(s) Summary
Incremental highlighter implementation
apps/web/src/lib/incrementalHighlighting.ts
createIncrementalHighlighter caches grammar state, reuses highlighted nodes, invalidates changed prefixes, and applies full-highlighter fallbacks.
Incremental highlighter validation
apps/web/src/lib/incrementalHighlighting.test.ts
Tests compare incremental output with full highlighting across languages, themes, edits, truncation, plaintext, ANSI-like input, and partial CRLF or CR endings.
Streaming code-block integration
apps/web/src/components/ChatMarkdown.tsx
Streaming blocks use the incremental highlighter. Non-streaming blocks continue to use full-document highlighting.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Refactor

Sequence Diagram(s)

sequenceDiagram
  participant UncachedShikiCodeBlock
  participant createIncrementalHighlighter
  participant DiffsHighlighter
  UncachedShikiCodeBlock->>createIncrementalHighlighter: Highlight streaming content
  createIncrementalHighlighter->>DiffsHighlighter: Highlight uncached complete lines
  DiffsHighlighter-->>createIncrementalHighlighter: Return highlighted nodes and grammar state
  createIncrementalHighlighter-->>UncachedShikiCodeBlock: Return incremental HTML
Loading

Merge Risk: ⚪ Minimal · up to ba247

The streaming highlighting change has no confirmed current-head issue requiring resolution before merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: resuming syntax highlighting from completed lines during streaming.
Description check ✅ Passed The description explains the change, motivation, implementation scope, performance results, testing, and UI evidence. It does not use the template headings or include the checklist, but it is mostly c…
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch legend-perf/streaming-highlighting

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge
juliusmarminge merged commit d7d7f8f into main Sep 11, 2026
24 checks passed
@juliusmarminge
juliusmarminge deleted the legend-perf/streaming-highlighting branch September 11, 2026 06:50
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 11, 2026
## What's Changed
* fix(pr): update labels and reviewers without redundant reloads by @maria-rcks in pingdotgg/t3code#11117
* fix(chat): fold question answers into tool activity by @maria-rcks in pingdotgg/t3code#11014
* fix(usage): flag unpriced model activity instead of showing $0.00 by @maria-rcks in pingdotgg/t3code#11021
* fix(server): let Claude launch args override the derived permission mode by @maria-rcks in pingdotgg/t3code#11026
* fix(editors): accept root paths and Windows servers in Zed remote links by @maria-rcks in pingdotgg/t3code#11044
* fix(web): center pull request unavailable states by @maria-rcks in pingdotgg/t3code#11110
* fix(web): remove sidebar pull request link icon by @maria-rcks in pingdotgg/t3code#11179
* fix(ui): color linked pr counts by aggregate status by @maria-rcks in pingdotgg/t3code#11180
* fix(preview): render website favicons for browser tool activity by @maria-rcks in pingdotgg/t3code#11032
* fix(web): simplify pull request summary sections by @maria-rcks in pingdotgg/t3code#10612
* fix(web): preserve drafts when compacting context by @maria-rcks in pingdotgg/t3code#11103
* fix(server): queue messages during context compaction by @maria-rcks in pingdotgg/t3code#11107
* perf(web): format minimap previews only when opened by @juliusmarminge in pingdotgg/t3code#11181
* perf(web): reuse completed Markdown prefixes while streaming by @juliusmarminge in pingdotgg/t3code#11193
* perf(web): resume syntax highlighting from completed lines by @juliusmarminge in pingdotgg/t3code#11196
* perf(web): preserve completed code-line DOM while streaming by @juliusmarminge in pingdotgg/t3code#11198
* perf(web): huge-thread switch no longer blanks the chat pane by @juliusmarminge in pingdotgg/t3code#11169


**Full Changelog**: pingdotgg/t3code@v0.0.41-nightly.20260911.1520...v0.0.41-nightly.20260911.1533

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.41-nightly.20260911.1533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant