refactor(allocator): fix ref_as_ptr clippy warnings#21220
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
This was referenced Apr 9, 2026
Member
Author
This was referenced Apr 9, 2026
Merging this PR will not alter performance
Comparing Footnotes
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors oxc_allocator’s bump allocator implementation to eliminate clippy::ref_as_ptr warnings by replacing reference-to-pointer casts with core::ptr::from_ref / core::ptr::from_mut, keeping the same unsafe semantics while using the modern, lint-friendly APIs.
Changes:
- Remove
clippy::ref_as_ptrfrom the file-level#![expect(...)]list. - Replace
x as *const T/x as *mut Tpatterns (wherexis a reference) withptr::from_ref(x)/ptr::from_mut(x)in unsafe pointer-based code paths. - Update a couple of
ptr::readcall sites to useptr::from_refrather than casting.
Contributor
Merge activity
|
Continuation of #21210. Replace `x as *const T` / `x as *mut T` with `ptr::from_ref(x)` / `ptr::from_mut(x)`. Note that this change does not materialize any references which did not already exist in original code.
d589299 to
87fef2d
Compare
1bd3605 to
4d0b39f
Compare
Base automatically changed from
om/04-08-refactor_allocator_fix_borrow_as_ptr_clippy_warnings
to
main
April 9, 2026 09:10
This was referenced Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Continuation of #21210.
Replace
x as *const T/x as *mut Twithptr::from_ref(x)/ptr::from_mut(x). Note that this change does not materialize any references which did not already exist in original code.