refactor(allocator): fix mut_from_ref clippy warnings#21225
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
This was referenced Apr 9, 2026
Member
Author
This was referenced Apr 9, 2026
Merging this PR will not alter performance
Comparing Footnotes
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors Bump’s Clippy lint suppression for clippy::mut_from_ref by removing the module-level suppression and scoping it to specific methods that return &mut from &self.
Changes:
- Removed
clippy::mut_from_reffrom the crate-level#![expect(...)]list inbump.rs. - Added
#[expect(clippy::mut_from_ref)]to a set ofBumpallocation helpers that return mutable references from&self.
cb28ef1 to
02c7f8e
Compare
4276ffe to
145930f
Compare
02c7f8e to
adb6b3e
Compare
adb6b3e to
40016e5
Compare
This was referenced Apr 9, 2026
Contributor
Merge activity
|
Continuation of #21210. Remove `#[expect(clippy::mut_from_ref)]`attribute from top level, and add it on all methods which take an immutable `&self` and return a `&mut` reference. This usually-unsound pattern is sound here as `Bump` uses interior mutability.
40016e5 to
52db8a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Continuation of #21210.
Remove
#[expect(clippy::mut_from_ref)]attribute from top level, and add it on all methods which take an immutable&selfand return a&mutreference. This usually-unsound pattern is sound here asBumpuses interior mutability.