refactor(allocator): fix unsafe_op_in_unsafe_fn clippy warnings#21228
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 9, 2026
Conversation
This was referenced Apr 9, 2026
This was referenced Apr 9, 2026
This was referenced Apr 9, 2026
Member
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the allocator refactor by addressing Rust’s unsafe_op_in_unsafe_fn lint in oxc_allocator’s bump allocator implementation, reducing the need to globally suppress the warning and making unsafe operations explicit at call sites.
Changes:
- Remove the file-level
unsafe_op_in_unsafe_fnlint expectation. - Wrap unsafe operations (pointer dereferences,
ptr::*ops,unreachable_unchecked, calls to unsafe fns) in explicitunsafe { ... }blocks to satisfy the lint. - Adjust several allocator trait impl methods to call internal unsafe helpers within explicit unsafe blocks.
Merging this PR will not alter performance
Comparing Footnotes
|
Contributor
Merge activity
|
40016e5 to
52db8a7
Compare
2b78e1e to
7d39e57
Compare
Base automatically changed from
om/04-08-refactor_allocator_fix_mut_from_ref_clippy_warnings
to
main
April 9, 2026 10:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Continuation of #21210.