Skip to content

refactor(allocator): fix unsafe_op_in_unsafe_fn clippy warnings#21228

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/04-08-refactor_allocator_fix_unsafe_op_in_unsafe_fn_clippy_warnings
Apr 9, 2026
Merged

refactor(allocator): fix unsafe_op_in_unsafe_fn clippy warnings#21228
graphite-app[bot] merged 1 commit intomainfrom
om/04-08-refactor_allocator_fix_unsafe_op_in_unsafe_fn_clippy_warnings

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 9, 2026

Continuation of #21210.

Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 9, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the allocator refactor by addressing Rust’s unsafe_op_in_unsafe_fn lint in oxc_allocator’s bump allocator implementation, reducing the need to globally suppress the warning and making unsafe operations explicit at call sites.

Changes:

  • Remove the file-level unsafe_op_in_unsafe_fn lint expectation.
  • Wrap unsafe operations (pointer dereferences, ptr::* ops, unreachable_unchecked, calls to unsafe fns) in explicit unsafe { ... } blocks to satisfy the lint.
  • Adjust several allocator trait impl methods to call internal unsafe helpers within explicit unsafe blocks.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 9, 2026

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/04-08-refactor_allocator_fix_unsafe_op_in_unsafe_fn_clippy_warnings (2b78e1e) with om/04-08-refactor_allocator_fix_mut_from_ref_clippy_warnings (40016e5)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 9, 2026
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Apr 9, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the om/04-08-refactor_allocator_fix_mut_from_ref_clippy_warnings branch from 40016e5 to 52db8a7 Compare April 9, 2026 10:05
@graphite-app graphite-app bot force-pushed the om/04-08-refactor_allocator_fix_unsafe_op_in_unsafe_fn_clippy_warnings branch from 2b78e1e to 7d39e57 Compare April 9, 2026 10:05
Base automatically changed from om/04-08-refactor_allocator_fix_mut_from_ref_clippy_warnings to main April 9, 2026 10:10
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 9, 2026
@graphite-app graphite-app bot merged commit 7d39e57 into main Apr 9, 2026
28 checks passed
@graphite-app graphite-app bot deleted the om/04-08-refactor_allocator_fix_unsafe_op_in_unsafe_fn_clippy_warnings branch April 9, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-allocator Area - Allocator C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants