Skip to content

refactor(allocator): fix ref_as_ptr clippy warnings #21220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Apr 9, 2026
+7 −7
Merged

refactor(allocator): fix ref_as_ptr clippy warnings #21220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions crates/oxc_allocator/src/bump.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
clippy::mut_from_ref,
clippy::ptr_as_ptr,
clippy::ptr_cast_constness,
clippy::ref_as_ptr,
clippy::undocumented_unsafe_blocks,
clippy::unnecessary_safety_comment,
unsafe_op_in_unsafe_fn
Expand Down Expand Up @@ -374,8 +373,9 @@ impl ChunkFooter {
let data = self.data.as_ptr() as *const u8;
let ptr = self.ptr.get().as_ptr() as *const u8;
debug_assert!(data <= ptr);
debug_assert!(ptr <= self as *const ChunkFooter as *const u8);
let len = unsafe { (self as *const ChunkFooter as *const u8).offset_from(ptr) as usize };
debug_assert!(ptr <= ptr::from_ref::<ChunkFooter>(self) as *const u8);
let len =
unsafe { (ptr::from_ref::<ChunkFooter>(self) as *const u8).offset_from(ptr) as usize };
(ptr, len)
}

Expand Down Expand Up @@ -1219,7 +1219,7 @@ impl<const MIN_ALIGN: usize> Bump<MIN_ALIGN> {
// since it grows backwards, it seems unlikely that we'd get
// any more than the `Result`'s discriminant this way, if
// anything at all.
&mut *(t as *mut _)
&mut *ptr::from_mut(t)
}),
Err(e) => unsafe {
// If this result was the last allocation in this arena, we can
Expand Down Expand Up @@ -1264,7 +1264,7 @@ impl<const MIN_ALIGN: usize> Bump<MIN_ALIGN> {
//
// The order between this and the deallocation doesn't matter
// because `Self: !Sync`.
Err(ptr::read(e as *const _))
Err(ptr::read(ptr::from_ref(e)))
},
}
}
Expand Down Expand Up @@ -1329,7 +1329,7 @@ impl<const MIN_ALIGN: usize> Bump<MIN_ALIGN> {
// since it grows backwards, it seems unlikely that we'd get
// any more than the `Result`'s discriminant this way, if
// anything at all.
&mut *(t as *mut _)
&mut *ptr::from_mut(t)
}),
Err(e) => unsafe {
// If this result was the last allocation in this arena, we can
Expand Down Expand Up @@ -1374,7 +1374,7 @@ impl<const MIN_ALIGN: usize> Bump<MIN_ALIGN> {
//
// The order between this and the deallocation doesn't matter
// because `Self: !Sync`.
Err(AllocOrInitError::Init(ptr::read(e as *const _)))
Err(AllocOrInitError::Init(ptr::read(ptr::from_ref(e))))
},
}
}
Expand Down
Loading