refactor(allocator): fix map_unwrap_or clippy warnings#21216
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
This was referenced Apr 9, 2026
Member
Author
This was referenced Apr 9, 2026
This was referenced Apr 9, 2026
Merging this PR will not alter performance
Comparing Footnotes
|
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the clippy::map_unwrap_or expect from the allocator bump arena implementation by rewriting the affected Option logic to use the newer Option::is_none_or helper, keeping the behavior the same while satisfying Clippy.
Changes:
- Drop
clippy::map_unwrap_orfrom the file-level#![expect(...)]list. - Refactor
chunk_fits_under_limitto useOption::is_none_orinstead ofmap(...).unwrap_or(true).
Contributor
Merge activity
|
Continuation of #21210.
654b251 to
36d4307
Compare
6177055 to
7a99bc3
Compare
Base automatically changed from
om/04-08-refactor_allocator_fix_filter_map_next_clippy_warnings
to
main
April 9, 2026 09:03
This was referenced Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Continuation of #21210.