fix(oxlint/lsp): detect `reportUnusedDisableDirectives` from oxlint config, change lsp `unusedDisableDirectives` default value to `None` by Sysix · Pull Request #20011 · oxc-project/oxc

Sysix · 2026-03-04T22:00:03Z

follow up from #19799

Defaults to None, allows Some(allow) still to override the oxlint config

Sysix · 2026-03-04T22:00:18Z

fix(oxlint/lsp): detect reportUnusedDisableDirectives from oxlint config, change lsp unusedDisableDirectives default value to None #20011 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR extends the LSP linting server to detect reportUnusedDisableDirectives from the .oxlintrc.json config file. Previously, the LSP only read this setting from the LSP initialization options (unusedDisableDirectives). Now the LSP falls back to the config file value when no LSP option is explicitly set. The default value of unusedDisableDirectives in LSP options is changed from the Allow variant to None (as an Option), allowing the system to distinguish "not configured by LSP" from an explicit "allow".

Changes:

LintOptions.unused_disable_directives changed from UnusedDisableDirectives (defaulting to Allow) to Option<UnusedDisableDirectives> (defaulting to None), so the LSP can detect when no value is explicitly set.
server_linter.rs is updated to build config_store before lint_options, then fall back to config_store.report_unused_disable_directives() when no LSP option is provided.
A new test fixture and snapshot are added to verify that reportUnusedDisableDirectives: "error" from the config file is correctly detected by the LSP.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`apps/oxlint/src/lsp/options.rs`	Changes `unused_disable_directives` field type from `UnusedDisableDirectives` to `Option<UnusedDisableDirectives>`, updates deserialization and tests accordingly, adds `test_null_options_json` test
`apps/oxlint/src/lsp/server_linter.rs`	Reorders `ConfigStore` construction before `LintOptions` construction, adds config-file fallback for `report_unused_directive`
`apps/oxlint/test/lsp/lint/lint.test.ts`	Adds `unused-disable-directive-from-config/test.ts` to the fixture-based test suite
`apps/oxlint/test/lsp/lint/fixtures/unused-disable-directive-from-config/test.ts`	New fixture TypeScript file with an unused disable directive
`apps/oxlint/test/lsp/lint/fixtures/unused-disable-directive-from-config/.oxlintrc.json`	New fixture config with `reportUnusedDisableDirectives: "error"` enabled
`apps/oxlint/test/lsp/lint/__snapshots__/lint.test.ts.snap`	Updated snapshot including the expected diagnostic for the new fixture

apps/oxlint/src/lsp/server_linter.rs

apps/oxlint/src/lsp/options.rs

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

camc314

I knew i missed something 🙂

Thanks!

camc314 · 2026-03-04T22:42:00Z

Merge activity

Mar 4, 10:42 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 4, 10:42 PM UTC: camc314 added this pull request to the Graphite merge queue.
Mar 4, 10:49 PM UTC: Merged by the Graphite merge queue.

…onfig, change lsp `unusedDisableDirectives` default value to `None` (#20011) follow up from #19799 Defaults to `None`, allows `Some(allow)` still to override the oxlint config

# Oxlint ### 🚀 Features - e6b604f oxlint: Auto-enable gitlab formatter on GitLab (#20076) (camc314) - 2488a68 linter: Add .oxlintrc.jsonc config file support (#19870) (Scott S.) - 61bf388 linter: Add `options.reportUnusedDisableDirectives` to config file (#19799) (Peter Wagenet) - c92422b oxlint: Auto-enable github formatter on GitHub Actions (#19944) (Boshen) - 0337c6d linter: Implement typescript/no-unecessary-type-conversion (#19955) (camc314) - 2919313 linter: Introduce denyWarnings config options (#19926) (camc314) - a607119 linter: Introduce maxWarnings config option (#19777) (camc314) ### 🐛 Bug Fixes - 0861d9a linter/plugins: Remove getters from `Context` (#20115) (overlookmotel) - 92cfb14 linter/plugins: Fix types for `walkProgram` and `walkProgramWithCfg` (#20081) (overlookmotel) - 10e211f oxlint/lsp: Send other code actions besides `source.fixAll` if requested (#20042) (Sysix) - 602daaa linter/plugins: Fix type definition for `VisitorObject` (#20065) (overlookmotel) - ee0491e apps,napi: Explicitly specify libs in tsconfigs (#20071) (camc314) - b6e9499 linter: Fix the logic for `unicorn/prefer-dom-node-remove` to handle literal callees as well as arguments. (#20059) (connorshea) - 3874ae1 linter: Update `unicorn/prefer-query-selector` to also catch `getElementsByName()`. (#20060) (connorshea) - 77c93fb linter: Handle array-type shorthand inside union members (#20034) (camc314) - 50eb160 linter/no-unused-vars: Allow unused type params in ambient module blocks (#19615) (Don Isaac) - 1dd0d21 linter/no-restricted-imports: Apply regex pattern checks to side-effect imports (#20028) (camc314) - 7f3d735 linter: Error when --type-check is used without --type-aware (#20025) (camc314) - eea201c unicorn/prefer-string-slice: Avoid unsafe autofix for substr-to-slice (#20010) (camc314) - 50359dc oxlint/lsp: Detect `reportUnusedDisableDirectives` from oxlint config, change lsp `unusedDisableDirectives` default value to `None` (#20011) (Sysix) - 4bc84b1 linter/plugins: Allow `null` and `undefined` for `rule.meta.fixable` (#20008) (overlookmotel) - 753e27e linter/role-supports-aria-props: Add `aria-posinset` to supported `option` ARIA properties (#20003) (JongKyung Lee) - f57b2c9 linter/plugins: Fix return types of tokens methods (#19985) (overlookmotel) - 27ee4fc linter/no-loss-of-precision: Avoid double rounding for negative exponents (#19999) (camc314) - 77a94bb linter: Avoid no-loss-of-precision false positive for 3e-308 (#19992) (camc314) - 6245c56 linter/no-unused-private-class-members: Treat logical lhs access as usage (#19991) (camc314) - 65891e3 linter: Avoid prefer-const false positive for mixed-scope destructuring (#19982) (camc314) - 89991fe linter: Avoid prefer-const false positive for operator reassignments (#19975) (camc314) - 87318e7 oxlint/lsp: Load js config with reforcing fs read (#19551) (Sysix) - d40a942 linter/no-useless-constructor: Mark fixer as suggestion (#19961) (camc314) - ccbd959 linter/prefer-code-point: Report String.fromCharCode member references (#19931) (camc314) - 14fbbfc linter: Add help text to oxc/no-rest-spread-properties rule (#19900) (Subin Kim) ### ⚡ Performance - 2baa5fb napi: Unify build-test profile to coverage for cache sharing (#20090) (Boshen) - 77f1c71 linter/plugins: Make tokens class instances (#19980) (overlookmotel) - 758b424 linter/plugins: Reduce memory copies for tokens (#19979) (overlookmotel) - 236847f linter/plugins: Cache token objects (#19978) (overlookmotel) - 94b597a linter/plugins: Store tokens as a `Box<[Token]>` (#19969) (overlookmotel) ### 📚 Documentation - 2c0010a linter/plugins: Move comment about "bivariance hack" into generated code (#20082) (overlookmotel) - 7538f09 linter: Improve `import/extensions` and `import/no-named-as-default` rule docs. (#20053) (connorshea) - 1f909cf linter: Improve docs for `unicorn/require-post-message-target-origin` rule. (#20061) (connorshea) - 12ae35c oxlint/lsp: Remove outdated ToDo for `LintOptions.run` (#20012) (Sysix) - 3be73e6 linter/plugins: Fix JSDoc comments for tokens methods (#20004) (overlookmotel) - 48ef285 linter: Update `--config` docs (#19965) (camc314) - 6ea49a0 linter: Fix some identation issues for the generated types used in `oxlint.config.ts`. (#19942) (connorshea) - 6c0e0b5 linter: Add oxlint.config.ts to the config docs. (#19941) (connorshea) - 160e423 linter: Add a note that the typeAware and typeCheck options require oxlint-tsgolint (#19940) (connorshea) - d54c275 linter: Improve rule docs for 27 unicorn rules (#19903) (connorshea) # Oxfmt ### 🚀 Features - ee26215 oxfmt: Support css-in-js substitution (#20019) (leaysgur) - 0f0ff51 oxfmt: Display default settings was used message in cli stats (#19939) (leaysgur) - 88815b8 oxfmt: Reintroduce stats line for write mode (#19938) (leaysgur) ### 🐛 Bug Fixes - ee0491e apps,napi: Explicitly specify libs in tsconfigs (#20071) (camc314) - 92f4490 oxfmt: Apply `is_ignored_dir` for glob paths too (#20056) (leaysgur) - 114f974 oxfmt/lsp: Prefer language_id over file extension when formatting (#19977) (copilot-swe-agent) ### ⚡ Performance - 2baa5fb napi: Unify build-test profile to coverage for cache sharing (#20090) (Boshen) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-bug Category - Bug labels Mar 4, 2026

Sysix changed the title ~~fix(oxlint/lsp): preferreportUnusedDisableDirectives from oxlint config instead of own lsp option~~ fix(oxlint/lsp): prefer reportUnusedDisableDirectives from oxlint config instead of own lsp option Mar 4, 2026

Sysix changed the title ~~fix(oxlint/lsp): prefer reportUnusedDisableDirectives from oxlint config instead of own lsp option~~ fix(oxlint/lsp): detect reportUnusedDisableDirectives from oxlint config, change lsp unusedDisableDirectives default value to None Mar 4, 2026

Sysix requested review from Copilot March 4, 2026 22:04

Copilot started reviewing on behalf of Sysix March 4, 2026 22:04 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

apps/oxlint/src/lsp/server_linter.rs Show resolved Hide resolved

apps/oxlint/src/lsp/options.rs Show resolved Hide resolved

Copilot AI reviewed Mar 4, 2026

View reviewed changes

Sysix force-pushed the 03-04-fix_oxlint_lsp_prefer_reportunuseddisabledirectives_from_oxlint_config_instead_of_own_lsp_option branch from 18cb648 to d0e3cf9 Compare March 4, 2026 22:24

Sysix mentioned this pull request Mar 4, 2026

chore: set oxc.unusedDisableDirectives default value to null oxc-project/oxc-vscode#115

Merged

Sysix marked this pull request as ready for review March 4, 2026 22:37

Sysix requested a review from camc314 as a code owner March 4, 2026 22:37

Sysix assigned camc314 Mar 4, 2026

camc314 approved these changes Mar 4, 2026

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 4, 2026

fix(oxlint/lsp): detect reportUnusedDisableDirectives from oxlint c…

50359dc

…onfig, change lsp `unusedDisableDirectives` default value to `None` (#20011) follow up from #19799 Defaults to `None`, allows `Some(allow)` still to override the oxlint config

graphite-app bot force-pushed the 03-04-fix_oxlint_lsp_prefer_reportunuseddisabledirectives_from_oxlint_config_instead_of_own_lsp_option branch from d0e3cf9 to 50359dc Compare March 4, 2026 22:42

graphite-app bot merged commit 50359dc into main Mar 4, 2026
19 checks passed

graphite-app bot deleted the 03-04-fix_oxlint_lsp_prefer_reportunuseddisabledirectives_from_oxlint_config_instead_of_own_lsp_option branch March 4, 2026 22:49

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 4, 2026

Boshen mentioned this pull request Mar 9, 2026

release(apps): oxlint v1.52.0 && oxfmt v0.37.0 #20143

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(oxlint/lsp): detect `reportUnusedDisableDirectives` from oxlint config, change lsp `unusedDisableDirectives` default value to `None`#20011

fix(oxlint/lsp): detect `reportUnusedDisableDirectives` from oxlint config, change lsp `unusedDisableDirectives` default value to `None`#20011
graphite-app[bot] merged 1 commit intomainfrom
03-04-fix_oxlint_lsp_prefer_reportunuseddisabledirectives_from_oxlint_config_instead_of_own_lsp_option

Sysix commented Mar 4, 2026 •

edited

Loading

Uh oh!

Sysix commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

camc314 left a comment

Uh oh!

camc314 commented Mar 4, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Sysix commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Mar 4, 2026

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

camc314 left a comment

Choose a reason for hiding this comment

Uh oh!

camc314 commented Mar 4, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sysix commented Mar 4, 2026 •

edited

Loading

camc314 commented Mar 4, 2026 •

edited by graphite-app bot

Loading