feat(linter): introduce maxWarnings config option by camc314 · Pull Request #19777 · oxc-project/oxc

camc314 · 2026-02-26T16:10:49Z

No description provided.

camc314 · 2026-02-26T16:11:04Z

feat(linter): introduce maxWarnings config option #19777 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-02-26T16:17:41Z

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks¹

_{Comparing c/02-26-feat_linter_introduce_maxwarnings_config_option (68b03e5) with main (3d7b2ec)}

52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copilot

Pull request overview

Adds support for configuring a maximum warning threshold via options.maxWarnings in oxlint configuration, aligning config-file behavior with the existing --max-warnings CLI flag.

Changes:

Introduce options.maxWarnings in the Rust config model and propagate it through config building/loading into the diagnostic service.
Update generated configuration schema/docs and JS/TS config typings to expose the new option.
Add fixtures and tests validating parsing, merging/extends behavior, root-only enforcement, and exit-code behavior.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tasks/website_linter/src/snapshots/schema_markdown.snap	Documents `options.maxWarnings` in the rendered schema markdown snapshot.
tasks/website_linter/src/snapshots/schema_json.snap	Adds `maxWarnings` to the schema JSON snapshot used by the website linter task.
npm/oxlint/configuration_schema.json	Exposes `maxWarnings` in the published JSON schema for oxlint configs.
crates/oxc_linter/src/config/oxlintrc.rs	Adds `max_warnings` to `OxlintOptions`, merge behavior, and serde tests (including invalid negative).
crates/oxc_linter/src/config/config_store.rs	Adds `ConfigStore::max_warnings()` accessor and tests for default/configured behavior.
crates/oxc_linter/src/config/config_builder.rs	Adds builder accessor and extends/override tests for `maxWarnings`.
crates/oxc_linter/fixtures/extends_config/options/max_warnings_10.json	Fixture for `extends`-based config with `maxWarnings: 10`.
crates/oxc_linter/fixtures/extends_config/options/max_warnings_0.json	Fixture for `extends`-based config with `maxWarnings: 0`.
apps/oxlint/test/fixtures/js_config_dynamic_max_warnings/oxlint.config.ts	JS config fixture demonstrating dynamic `maxWarnings` value wiring.
apps/oxlint/test/fixtures/js_config_dynamic_max_warnings/output.snap.md	Snapshot asserting exit-code/output when warnings exceed configured max (via JS config).
apps/oxlint/test/fixtures/js_config_dynamic_max_warnings/files/test.js	Fixture source producing a warning to trip the threshold.
apps/oxlint/src/lint.rs	Threads config-derived `maxWarnings` into `DiagnosticService` (with CLI override precedence) and adds snapshot tests.
apps/oxlint/src/config_loader.rs	Enforces `options.maxWarnings` as root-only (mirrors existing root-only options behavior).
apps/oxlint/src-js/package/config.generated.ts	Updates generated TS typings to include `maxWarnings`.
apps/oxlint/fixtures/linter/config-max-warnings.json	JSON config fixture for max-warnings behavior via config file.

npm/oxlint/configuration_schema.json

camc314 · 2026-03-02T12:19:26Z

Merge activity

Mar 2, 12:19 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 2, 12:19 PM UTC: camc314 added this pull request to the Graphite merge queue.
Mar 2, 12:33 PM UTC: Merged by the Graphite merge queue.

# Oxlint ### 🚀 Features - e6b604f oxlint: Auto-enable gitlab formatter on GitLab (#20076) (camc314) - 2488a68 linter: Add .oxlintrc.jsonc config file support (#19870) (Scott S.) - 61bf388 linter: Add `options.reportUnusedDisableDirectives` to config file (#19799) (Peter Wagenet) - c92422b oxlint: Auto-enable github formatter on GitHub Actions (#19944) (Boshen) - 0337c6d linter: Implement typescript/no-unecessary-type-conversion (#19955) (camc314) - 2919313 linter: Introduce denyWarnings config options (#19926) (camc314) - a607119 linter: Introduce maxWarnings config option (#19777) (camc314) ### 🐛 Bug Fixes - 0861d9a linter/plugins: Remove getters from `Context` (#20115) (overlookmotel) - 92cfb14 linter/plugins: Fix types for `walkProgram` and `walkProgramWithCfg` (#20081) (overlookmotel) - 10e211f oxlint/lsp: Send other code actions besides `source.fixAll` if requested (#20042) (Sysix) - 602daaa linter/plugins: Fix type definition for `VisitorObject` (#20065) (overlookmotel) - ee0491e apps,napi: Explicitly specify libs in tsconfigs (#20071) (camc314) - b6e9499 linter: Fix the logic for `unicorn/prefer-dom-node-remove` to handle literal callees as well as arguments. (#20059) (connorshea) - 3874ae1 linter: Update `unicorn/prefer-query-selector` to also catch `getElementsByName()`. (#20060) (connorshea) - 77c93fb linter: Handle array-type shorthand inside union members (#20034) (camc314) - 50eb160 linter/no-unused-vars: Allow unused type params in ambient module blocks (#19615) (Don Isaac) - 1dd0d21 linter/no-restricted-imports: Apply regex pattern checks to side-effect imports (#20028) (camc314) - 7f3d735 linter: Error when --type-check is used without --type-aware (#20025) (camc314) - eea201c unicorn/prefer-string-slice: Avoid unsafe autofix for substr-to-slice (#20010) (camc314) - 50359dc oxlint/lsp: Detect `reportUnusedDisableDirectives` from oxlint config, change lsp `unusedDisableDirectives` default value to `None` (#20011) (Sysix) - 4bc84b1 linter/plugins: Allow `null` and `undefined` for `rule.meta.fixable` (#20008) (overlookmotel) - 753e27e linter/role-supports-aria-props: Add `aria-posinset` to supported `option` ARIA properties (#20003) (JongKyung Lee) - f57b2c9 linter/plugins: Fix return types of tokens methods (#19985) (overlookmotel) - 27ee4fc linter/no-loss-of-precision: Avoid double rounding for negative exponents (#19999) (camc314) - 77a94bb linter: Avoid no-loss-of-precision false positive for 3e-308 (#19992) (camc314) - 6245c56 linter/no-unused-private-class-members: Treat logical lhs access as usage (#19991) (camc314) - 65891e3 linter: Avoid prefer-const false positive for mixed-scope destructuring (#19982) (camc314) - 89991fe linter: Avoid prefer-const false positive for operator reassignments (#19975) (camc314) - 87318e7 oxlint/lsp: Load js config with reforcing fs read (#19551) (Sysix) - d40a942 linter/no-useless-constructor: Mark fixer as suggestion (#19961) (camc314) - ccbd959 linter/prefer-code-point: Report String.fromCharCode member references (#19931) (camc314) - 14fbbfc linter: Add help text to oxc/no-rest-spread-properties rule (#19900) (Subin Kim) ### ⚡ Performance - 2baa5fb napi: Unify build-test profile to coverage for cache sharing (#20090) (Boshen) - 77f1c71 linter/plugins: Make tokens class instances (#19980) (overlookmotel) - 758b424 linter/plugins: Reduce memory copies for tokens (#19979) (overlookmotel) - 236847f linter/plugins: Cache token objects (#19978) (overlookmotel) - 94b597a linter/plugins: Store tokens as a `Box<[Token]>` (#19969) (overlookmotel) ### 📚 Documentation - 2c0010a linter/plugins: Move comment about "bivariance hack" into generated code (#20082) (overlookmotel) - 7538f09 linter: Improve `import/extensions` and `import/no-named-as-default` rule docs. (#20053) (connorshea) - 1f909cf linter: Improve docs for `unicorn/require-post-message-target-origin` rule. (#20061) (connorshea) - 12ae35c oxlint/lsp: Remove outdated ToDo for `LintOptions.run` (#20012) (Sysix) - 3be73e6 linter/plugins: Fix JSDoc comments for tokens methods (#20004) (overlookmotel) - 48ef285 linter: Update `--config` docs (#19965) (camc314) - 6ea49a0 linter: Fix some identation issues for the generated types used in `oxlint.config.ts`. (#19942) (connorshea) - 6c0e0b5 linter: Add oxlint.config.ts to the config docs. (#19941) (connorshea) - 160e423 linter: Add a note that the typeAware and typeCheck options require oxlint-tsgolint (#19940) (connorshea) - d54c275 linter: Improve rule docs for 27 unicorn rules (#19903) (connorshea) # Oxfmt ### 🚀 Features - ee26215 oxfmt: Support css-in-js substitution (#20019) (leaysgur) - 0f0ff51 oxfmt: Display default settings was used message in cli stats (#19939) (leaysgur) - 88815b8 oxfmt: Reintroduce stats line for write mode (#19938) (leaysgur) ### 🐛 Bug Fixes - ee0491e apps,napi: Explicitly specify libs in tsconfigs (#20071) (camc314) - 92f4490 oxfmt: Apply `is_ignored_dir` for glob paths too (#20056) (leaysgur) - 114f974 oxfmt/lsp: Prefer language_id over file extension when formatting (#19977) (copilot-swe-agent) ### ⚡ Performance - 2baa5fb napi: Unify build-test profile to coverage for cache sharing (#20090) (Boshen) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

camc314 mentioned this pull request Feb 26, 2026

linter: Support more CLI flags via config file options #15972

Open

7 tasks

github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-enhancement Category - New feature or request labels Feb 26, 2026

camc314 force-pushed the c/02-26-feat_linter_introduce_maxwarnings_config_option branch from fbad9de to 9eaf0dd Compare February 26, 2026 16:33

camc314 self-assigned this Feb 27, 2026

camc314 force-pushed the c/02-26-feat_linter_introduce_maxwarnings_config_option branch from 9eaf0dd to 68b03e5 Compare March 2, 2026 11:46

camc314 marked this pull request as ready for review March 2, 2026 11:46

camc314 requested a review from overlookmotel as a code owner March 2, 2026 11:46

Copilot AI review requested due to automatic review settings March 2, 2026 11:46

Copilot started reviewing on behalf of camc314 March 2, 2026 11:46 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

npm/oxlint/configuration_schema.json Show resolved Hide resolved

camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 2, 2026

This was referenced Mar 2, 2026

feat(oxlint): support maxWarnings in oxlintrc.json #18463

Closed

feat(oxlint): add maxWarnings config option #15118

Closed

feat(linter): introduce maxWarnings config option (#19777)

a607119

graphite-app bot force-pushed the c/02-26-feat_linter_introduce_maxwarnings_config_option branch from 68b03e5 to a607119 Compare March 2, 2026 12:27

graphite-app bot merged commit a607119 into main Mar 2, 2026
21 checks passed

graphite-app bot deleted the c/02-26-feat_linter_introduce_maxwarnings_config_option branch March 2, 2026 12:33

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 2, 2026

Boshen mentioned this pull request Mar 9, 2026

release(apps): oxlint v1.52.0 && oxfmt v0.37.0 #20143

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(linter): introduce maxWarnings config option#19777

feat(linter): introduce maxWarnings config option#19777
graphite-app[bot] merged 1 commit intomainfrom
c/02-26-feat_linter_introduce_maxwarnings_config_option

camc314 commented Feb 26, 2026

Uh oh!

camc314 commented Feb 26, 2026

Uh oh!

codspeed-hq bot commented Feb 26, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

camc314 commented Mar 2, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

camc314 commented Feb 26, 2026

Uh oh!

camc314 commented Feb 26, 2026

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

camc314 commented Mar 2, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codspeed-hq bot commented Feb 26, 2026 •

edited

Loading

camc314 commented Mar 2, 2026 •

edited by graphite-app bot

Loading