fix(oxlint/lsp): load js config with reforcing fs read by Sysix · Pull Request #19551 · oxc-project/oxc

Sysix · 2026-02-19T18:01:34Z

closes #19526

This PR fixes a bug in the LSP where JavaScript/TypeScript config files were not being reloaded when changed. The fix implements cache-busting by appending a timestamp query parameter to file URLs during import, forcing Node.js to bypass its module cache.

Sysix · 2026-02-19T18:01:48Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR fixes a bug in the LSP where JavaScript/TypeScript config files were not being reloaded when changed. The fix implements cache-busting by appending a timestamp query parameter to file URLs during import, forcing Node.js to bypass its module cache.

Changes:

Added cache-busting mechanism using timestamp query parameters to force Node.js to reload config files
Updated test utilities to normalize output by stripping cache parameters from snapshots
Updated test snapshot to reflect that config changes are now properly detected (severity change from Error to Warning)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
apps/oxlint/src-js/utils/globals.ts	Exports `DateNow` from `Date` object following TSDown conventions
apps/oxlint/src-js/js_config.ts	Implements cache-busting by appending `?cache=${timestamp}` to file URLs during config import
apps/oxlint/test/utils.ts	Adds regex to strip `?cache=...` query parameters from test output for consistent snapshots
apps/oxlint/test/lsp/file_config_change/snapshots/file_config_change.test.ts.snap	Updates snapshot showing config reload now works (Error → Warning change is detected)

apps/oxlint/src-js/js_config.ts

Sysix · 2026-02-23T22:10:36Z

Ping :) If there are any questions, I am happy to answer them

Sysix · 2026-03-03T18:04:55Z

@overlookmotel @camc314 ping again. Please tell me what needs to change for the merge :)

camc314

thanks for this - I left this because if users are making a lot of changes, i guess this can lead to memory leaks.

But considering how infrequently users change/save config files, I think it's ok?

camc314 · 2026-03-03T18:34:50Z

Merge activity

Mar 3, 6:34 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 3, 6:34 PM UTC: camc314 added this pull request to the Graphite merge queue.
Mar 3, 6:41 PM UTC: Merged by the Graphite merge queue.

closes #19526 > This PR fixes a bug in the LSP where JavaScript/TypeScript config files were not being reloaded when changed. The fix implements cache-busting by appending a timestamp query parameter to file URLs during import, forcing Node.js to bypass its module cache.

# Oxlint ### 🚀 Features - e6b604f oxlint: Auto-enable gitlab formatter on GitLab (#20076) (camc314) - 2488a68 linter: Add .oxlintrc.jsonc config file support (#19870) (Scott S.) - 61bf388 linter: Add `options.reportUnusedDisableDirectives` to config file (#19799) (Peter Wagenet) - c92422b oxlint: Auto-enable github formatter on GitHub Actions (#19944) (Boshen) - 0337c6d linter: Implement typescript/no-unecessary-type-conversion (#19955) (camc314) - 2919313 linter: Introduce denyWarnings config options (#19926) (camc314) - a607119 linter: Introduce maxWarnings config option (#19777) (camc314) ### 🐛 Bug Fixes - 0861d9a linter/plugins: Remove getters from `Context` (#20115) (overlookmotel) - 92cfb14 linter/plugins: Fix types for `walkProgram` and `walkProgramWithCfg` (#20081) (overlookmotel) - 10e211f oxlint/lsp: Send other code actions besides `source.fixAll` if requested (#20042) (Sysix) - 602daaa linter/plugins: Fix type definition for `VisitorObject` (#20065) (overlookmotel) - ee0491e apps,napi: Explicitly specify libs in tsconfigs (#20071) (camc314) - b6e9499 linter: Fix the logic for `unicorn/prefer-dom-node-remove` to handle literal callees as well as arguments. (#20059) (connorshea) - 3874ae1 linter: Update `unicorn/prefer-query-selector` to also catch `getElementsByName()`. (#20060) (connorshea) - 77c93fb linter: Handle array-type shorthand inside union members (#20034) (camc314) - 50eb160 linter/no-unused-vars: Allow unused type params in ambient module blocks (#19615) (Don Isaac) - 1dd0d21 linter/no-restricted-imports: Apply regex pattern checks to side-effect imports (#20028) (camc314) - 7f3d735 linter: Error when --type-check is used without --type-aware (#20025) (camc314) - eea201c unicorn/prefer-string-slice: Avoid unsafe autofix for substr-to-slice (#20010) (camc314) - 50359dc oxlint/lsp: Detect `reportUnusedDisableDirectives` from oxlint config, change lsp `unusedDisableDirectives` default value to `None` (#20011) (Sysix) - 4bc84b1 linter/plugins: Allow `null` and `undefined` for `rule.meta.fixable` (#20008) (overlookmotel) - 753e27e linter/role-supports-aria-props: Add `aria-posinset` to supported `option` ARIA properties (#20003) (JongKyung Lee) - f57b2c9 linter/plugins: Fix return types of tokens methods (#19985) (overlookmotel) - 27ee4fc linter/no-loss-of-precision: Avoid double rounding for negative exponents (#19999) (camc314) - 77a94bb linter: Avoid no-loss-of-precision false positive for 3e-308 (#19992) (camc314) - 6245c56 linter/no-unused-private-class-members: Treat logical lhs access as usage (#19991) (camc314) - 65891e3 linter: Avoid prefer-const false positive for mixed-scope destructuring (#19982) (camc314) - 89991fe linter: Avoid prefer-const false positive for operator reassignments (#19975) (camc314) - 87318e7 oxlint/lsp: Load js config with reforcing fs read (#19551) (Sysix) - d40a942 linter/no-useless-constructor: Mark fixer as suggestion (#19961) (camc314) - ccbd959 linter/prefer-code-point: Report String.fromCharCode member references (#19931) (camc314) - 14fbbfc linter: Add help text to oxc/no-rest-spread-properties rule (#19900) (Subin Kim) ### ⚡ Performance - 2baa5fb napi: Unify build-test profile to coverage for cache sharing (#20090) (Boshen) - 77f1c71 linter/plugins: Make tokens class instances (#19980) (overlookmotel) - 758b424 linter/plugins: Reduce memory copies for tokens (#19979) (overlookmotel) - 236847f linter/plugins: Cache token objects (#19978) (overlookmotel) - 94b597a linter/plugins: Store tokens as a `Box<[Token]>` (#19969) (overlookmotel) ### 📚 Documentation - 2c0010a linter/plugins: Move comment about "bivariance hack" into generated code (#20082) (overlookmotel) - 7538f09 linter: Improve `import/extensions` and `import/no-named-as-default` rule docs. (#20053) (connorshea) - 1f909cf linter: Improve docs for `unicorn/require-post-message-target-origin` rule. (#20061) (connorshea) - 12ae35c oxlint/lsp: Remove outdated ToDo for `LintOptions.run` (#20012) (Sysix) - 3be73e6 linter/plugins: Fix JSDoc comments for tokens methods (#20004) (overlookmotel) - 48ef285 linter: Update `--config` docs (#19965) (camc314) - 6ea49a0 linter: Fix some identation issues for the generated types used in `oxlint.config.ts`. (#19942) (connorshea) - 6c0e0b5 linter: Add oxlint.config.ts to the config docs. (#19941) (connorshea) - 160e423 linter: Add a note that the typeAware and typeCheck options require oxlint-tsgolint (#19940) (connorshea) - d54c275 linter: Improve rule docs for 27 unicorn rules (#19903) (connorshea) # Oxfmt ### 🚀 Features - ee26215 oxfmt: Support css-in-js substitution (#20019) (leaysgur) - 0f0ff51 oxfmt: Display default settings was used message in cli stats (#19939) (leaysgur) - 88815b8 oxfmt: Reintroduce stats line for write mode (#19938) (leaysgur) ### 🐛 Bug Fixes - ee0491e apps,napi: Explicitly specify libs in tsconfigs (#20071) (camc314) - 92f4490 oxfmt: Apply `is_ignored_dir` for glob paths too (#20056) (leaysgur) - 114f974 oxfmt/lsp: Prefer language_id over file extension when formatting (#19977) (copilot-swe-agent) ### ⚡ Performance - 2baa5fb napi: Unify build-test profile to coverage for cache sharing (#20090) (Boshen) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-bug Category - Bug labels Feb 19, 2026

Sysix changed the base branch from main to graphite-base/19551 February 19, 2026 19:28

Sysix force-pushed the 02-19-fix_oxlint_lsp_load_js_config_with_reforcing_fs_read branch from 7b92619 to c9afeef Compare February 19, 2026 19:28

Sysix force-pushed the graphite-base/19551 branch from 82ca5c3 to f369f67 Compare February 19, 2026 19:28

Sysix changed the base branch from graphite-base/19551 to 02-19-test_oxlint_lsp_add_test_for_.oxlintrc.json_serverity_change February 19, 2026 19:28

Sysix mentioned this pull request Feb 19, 2026

test(oxlint/lsp): add test for .oxlintrc.json config change #19552

Merged

Sysix requested a review from Copilot February 19, 2026 19:30

Copilot started reviewing on behalf of Sysix February 19, 2026 19:30 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

apps/oxlint/src-js/js_config.ts Outdated Show resolved Hide resolved

Sysix force-pushed the 02-19-fix_oxlint_lsp_load_js_config_with_reforcing_fs_read branch from c9afeef to ec39881 Compare February 19, 2026 19:45

Sysix force-pushed the 02-19-test_oxlint_lsp_add_test_for_.oxlintrc.json_serverity_change branch from f369f67 to 35e48ce Compare February 19, 2026 19:45

Sysix marked this pull request as ready for review February 19, 2026 19:45

Sysix requested review from camc314 and overlookmotel as code owners February 19, 2026 19:45

Sysix assigned camc314 and overlookmotel Feb 19, 2026

graphite-app bot changed the base branch from 02-19-test_oxlint_lsp_add_test_for_.oxlintrc.json_serverity_change to graphite-base/19551 February 20, 2026 13:22

graphite-app bot force-pushed the graphite-base/19551 branch from 35e48ce to ad43ccc Compare February 20, 2026 13:28

graphite-app bot force-pushed the 02-19-fix_oxlint_lsp_load_js_config_with_reforcing_fs_read branch from ec39881 to 0ea9bb9 Compare February 20, 2026 13:28

graphite-app bot changed the base branch from graphite-base/19551 to main February 20, 2026 13:29

graphite-app bot force-pushed the 02-19-fix_oxlint_lsp_load_js_config_with_reforcing_fs_read branch from 0ea9bb9 to 46baf0d Compare February 20, 2026 13:29

Sysix force-pushed the 02-19-fix_oxlint_lsp_load_js_config_with_reforcing_fs_read branch from 46baf0d to d17f84b Compare March 2, 2026 17:18

camc314 approved these changes Mar 3, 2026

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 3, 2026

graphite-app bot force-pushed the 02-19-fix_oxlint_lsp_load_js_config_with_reforcing_fs_read branch from d17f84b to 87318e7 Compare March 3, 2026 18:35

graphite-app bot merged commit 87318e7 into main Mar 3, 2026
19 checks passed

graphite-app bot deleted the 02-19-fix_oxlint_lsp_load_js_config_with_reforcing_fs_read branch March 3, 2026 18:41

Sysix mentioned this pull request Mar 7, 2026

Updating oxlint config rules doesn't refresh diagnostics oxc-project/oxc-vscode#128

Closed

Boshen mentioned this pull request Mar 9, 2026

release(apps): oxlint v1.52.0 && oxfmt v0.37.0 #20143

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(oxlint/lsp): load js config with reforcing fs read#19551

fix(oxlint/lsp): load js config with reforcing fs read#19551
graphite-app[bot] merged 1 commit intomainfrom
02-19-fix_oxlint_lsp_load_js_config_with_reforcing_fs_read

Sysix commented Feb 19, 2026 •

edited

Loading

Uh oh!

Sysix commented Feb 19, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Sysix commented Feb 23, 2026

Uh oh!

Sysix commented Mar 3, 2026

Uh oh!

camc314 left a comment •

edited

Loading

Uh oh!

camc314 commented Mar 3, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Sysix commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Sysix commented Feb 23, 2026

Uh oh!

Sysix commented Mar 3, 2026

Uh oh!

camc314 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camc314 commented Mar 3, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sysix commented Feb 19, 2026 •

edited

Loading

Sysix commented Feb 19, 2026 •

edited

Loading

camc314 left a comment •

edited

Loading

camc314 commented Mar 3, 2026 •

edited by graphite-app bot

Loading