Skip to content

fix(linter): add help text to oxc/no-rest-spread-properties rule#19900

Merged
camc314 merged 1 commit intooxc-project:mainfrom
hamsurang:issue-19121-oxc-no-rest-spread-properties
Mar 2, 2026
Merged

fix(linter): add help text to oxc/no-rest-spread-properties rule#19900
camc314 merged 1 commit intooxc-project:mainfrom
hamsurang:issue-19121-oxc-no-rest-spread-properties

Conversation

@sudosubin
Copy link
Contributor

@sudosubin sudosubin commented Mar 2, 2026

Summary

This pr is part of #19121.

Add .with_help to the oxc/no-rest-spread-properties rule as follows:

help: Use `Object.assign()` to combine objects instead of object spread syntax.
help: List the properties you need explicitly instead of using object rest syntax.

Snapshot

⚠ oxc(no-rest-spread-properties): object spread property are not allowed.
  ╭─[no_rest_spread_properties.tsx:1:3]
1 │ ({...a})
  ·   ────
  ╰────
help: Use `Object.assign()` to combine objects instead of object spread syntax.

⚠ oxc(no-rest-spread-properties): object rest property are not allowed.
  ╭─[no_rest_spread_properties.tsx:1:3]
1 │ ({...a} = obj)
  ·   ────
  ╰────
help: List the properties you need explicitly instead of using object rest syntax.

⚠ oxc(no-rest-spread-properties): object rest property are not allowed.
  ╭─[no_rest_spread_properties.tsx:1:7]
1 │ for ({...a} in foo) {}
  ·       ────
  ╰────
help: List the properties you need explicitly instead of using object rest syntax.

⚠ oxc(no-rest-spread-properties): object rest property are not allowed.
  ╭─[no_rest_spread_properties.tsx:1:13]
1 │ function f({...a}) {}
  ·             ────
  ╰────
help: List the properties you need explicitly instead of using object rest syntax.

⚠ oxc(no-rest-spread-properties): object spread property are not allowed. Our codebase does not allow object spread properties.
  ╭─[no_rest_spread_properties.tsx:1:3]
1 │ ({...a})
  ·   ────
  ╰────
help: Use `Object.assign()` to combine objects instead of object spread syntax.

⚠ oxc(no-rest-spread-properties): object rest property are not allowed. Our codebase does not allow object rest properties.
  ╭─[no_rest_spread_properties.tsx:1:3]
1 │ ({...a} = obj)
  ·   ────
  ╰────
help: List the properties you need explicitly instead of using object rest syntax.

Copilot AI review requested due to automatic review settings March 2, 2026 03:52
@sudosubin sudosubin requested a review from camc314 as a code owner March 2, 2026 03:52
@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Mar 2, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explanatory note text to the oxc/no-rest-spread-properties linter diagnostic so users get additional context about why object rest/spread is flagged, and updates snapshots accordingly.

Changes:

  • Add .with_note("Object rest/spread syntax may be unsupported in some target environments.") to the rule’s diagnostic.
  • Update the rule snapshot output to include the new note: line.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
crates/oxc_linter/src/rules/oxc/no_rest_spread_properties.rs Chains a new .with_note(...) onto the emitted OxcDiagnostic.
crates/oxc_linter/src/snapshots/oxc_no_rest_spread_properties.snap Updates expected diagnostic output to include the note text.

@camc314 camc314 self-assigned this Mar 2, 2026
@sudosubin sudosubin force-pushed the issue-19121-oxc-no-rest-spread-properties branch from bc0dadf to 218ff0a Compare March 2, 2026 10:12
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sudosubin sudosubin force-pushed the issue-19121-oxc-no-rest-spread-properties branch from 218ff0a to 79f9ae9 Compare March 2, 2026 10:50
@sudosubin sudosubin changed the title fix(linter): add note text to oxc/no-rest-spread-properties rule fix(linter): add help text to oxc/no-rest-spread-properties rule Mar 2, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 2, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks1


Comparing hamsurang:issue-19121-oxc-no-rest-spread-properties (fa1aeae) with main (8ec232e)

Open in CodSpeed

Footnotes

  1. 52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sudosubin sudosubin force-pushed the issue-19121-oxc-no-rest-spread-properties branch from 79f9ae9 to fa1aeae Compare March 2, 2026 11:01
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@camc314 camc314 merged commit 14fbbfc into oxc-project:main Mar 2, 2026
21 checks passed
camc314 pushed a commit that referenced this pull request Mar 9, 2026
# Oxlint
### 🚀 Features

- e6b604f oxlint: Auto-enable gitlab formatter on GitLab (#20076)
(camc314)
- 2488a68 linter: Add .oxlintrc.jsonc config file support (#19870)
(Scott S.)
- 61bf388 linter: Add `options.reportUnusedDisableDirectives` to config
file (#19799) (Peter Wagenet)
- c92422b oxlint: Auto-enable github formatter on GitHub Actions
(#19944) (Boshen)
- 0337c6d linter: Implement typescript/no-unecessary-type-conversion
(#19955) (camc314)
- 2919313 linter: Introduce denyWarnings config options (#19926)
(camc314)
- a607119 linter: Introduce maxWarnings config option (#19777) (camc314)

### 🐛 Bug Fixes

- 0861d9a linter/plugins: Remove getters from `Context` (#20115)
(overlookmotel)
- 92cfb14 linter/plugins: Fix types for `walkProgram` and
`walkProgramWithCfg` (#20081) (overlookmotel)
- 10e211f oxlint/lsp: Send other code actions besides `source.fixAll` if
requested (#20042) (Sysix)
- 602daaa linter/plugins: Fix type definition for `VisitorObject`
(#20065) (overlookmotel)
- ee0491e apps,napi: Explicitly specify libs in tsconfigs (#20071)
(camc314)
- b6e9499 linter: Fix the logic for `unicorn/prefer-dom-node-remove` to
handle literal callees as well as arguments. (#20059) (connorshea)
- 3874ae1 linter: Update `unicorn/prefer-query-selector` to also catch
`getElementsByName()`. (#20060) (connorshea)
- 77c93fb linter: Handle array-type shorthand inside union members
(#20034) (camc314)
- 50eb160 linter/no-unused-vars: Allow unused type params in ambient
module blocks (#19615) (Don Isaac)
- 1dd0d21 linter/no-restricted-imports: Apply regex pattern checks to
side-effect imports (#20028) (camc314)
- 7f3d735 linter: Error when --type-check is used without --type-aware
(#20025) (camc314)
- eea201c unicorn/prefer-string-slice: Avoid unsafe autofix for
substr-to-slice (#20010) (camc314)
- 50359dc oxlint/lsp: Detect `reportUnusedDisableDirectives` from oxlint
config, change lsp `unusedDisableDirectives` default value to `None`
(#20011) (Sysix)
- 4bc84b1 linter/plugins: Allow `null` and `undefined` for
`rule.meta.fixable` (#20008) (overlookmotel)
- 753e27e linter/role-supports-aria-props: Add `aria-posinset` to
supported `option` ARIA properties (#20003) (JongKyung Lee)
- f57b2c9 linter/plugins: Fix return types of tokens methods (#19985)
(overlookmotel)
- 27ee4fc linter/no-loss-of-precision: Avoid double rounding for
negative exponents (#19999) (camc314)
- 77a94bb linter: Avoid no-loss-of-precision false positive for 3e-308
(#19992) (camc314)
- 6245c56 linter/no-unused-private-class-members: Treat logical lhs
access as usage (#19991) (camc314)
- 65891e3 linter: Avoid prefer-const false positive for mixed-scope
destructuring (#19982) (camc314)
- 89991fe linter: Avoid prefer-const false positive for operator
reassignments (#19975) (camc314)
- 87318e7 oxlint/lsp: Load js config with reforcing fs read (#19551)
(Sysix)
- d40a942 linter/no-useless-constructor: Mark fixer as suggestion
(#19961) (camc314)
- ccbd959 linter/prefer-code-point: Report String.fromCharCode member
references (#19931) (camc314)
- 14fbbfc linter: Add help text to oxc/no-rest-spread-properties rule
(#19900) (Subin Kim)

### ⚡ Performance

- 2baa5fb napi: Unify build-test profile to coverage for cache sharing
(#20090) (Boshen)
- 77f1c71 linter/plugins: Make tokens class instances (#19980)
(overlookmotel)
- 758b424 linter/plugins: Reduce memory copies for tokens (#19979)
(overlookmotel)
- 236847f linter/plugins: Cache token objects (#19978) (overlookmotel)
- 94b597a linter/plugins: Store tokens as a `Box<[Token]>` (#19969)
(overlookmotel)

### 📚 Documentation

- 2c0010a linter/plugins: Move comment about "bivariance hack" into
generated code (#20082) (overlookmotel)
- 7538f09 linter: Improve `import/extensions` and
`import/no-named-as-default` rule docs. (#20053) (connorshea)
- 1f909cf linter: Improve docs for
`unicorn/require-post-message-target-origin` rule. (#20061) (connorshea)
- 12ae35c oxlint/lsp: Remove outdated ToDo for `LintOptions.run`
(#20012) (Sysix)
- 3be73e6 linter/plugins: Fix JSDoc comments for tokens methods (#20004)
(overlookmotel)
- 48ef285 linter: Update `--config` docs (#19965) (camc314)
- 6ea49a0 linter: Fix some identation issues for the generated types
used in `oxlint.config.ts`. (#19942) (connorshea)
- 6c0e0b5 linter: Add oxlint.config.ts to the config docs. (#19941)
(connorshea)
- 160e423 linter: Add a note that the typeAware and typeCheck options
require oxlint-tsgolint (#19940) (connorshea)
- d54c275 linter: Improve rule docs for 27 unicorn rules (#19903)
(connorshea)
# Oxfmt
### 🚀 Features

- ee26215 oxfmt: Support css-in-js substitution (#20019) (leaysgur)
- 0f0ff51 oxfmt: Display default settings was used message in cli stats
(#19939) (leaysgur)
- 88815b8 oxfmt: Reintroduce stats line for write mode (#19938)
(leaysgur)

### 🐛 Bug Fixes

- ee0491e apps,napi: Explicitly specify libs in tsconfigs (#20071)
(camc314)
- 92f4490 oxfmt: Apply `is_ignored_dir` for glob paths too (#20056)
(leaysgur)
- 114f974 oxfmt/lsp: Prefer language_id over file extension when
formatting (#19977) (copilot-swe-agent)

### ⚡ Performance

- 2baa5fb napi: Unify build-test profile to coverage for cache sharing
(#20090) (Boshen)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants