Skip to content

perf(linter/plugins): store tokens as a Box<[Token]>#19969

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/03-03-perf_linter_plugins_store_tokens_as_a_box_token_
Mar 3, 2026
Merged

perf(linter/plugins): store tokens as a Box<[Token]>#19969
graphite-app[bot] merged 1 commit intomainfrom
om/03-03-perf_linter_plugins_store_tokens_as_a_box_token_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 3, 2026

Small perf optimization.

Once tokens are collected, we have no reason to add / remove any. So store tokens as a Box<'a, [Token]> (16 bytes) instead of a Vec<'a, Token> (24 bytes).

Unlike with std's Vec<T>, converting arena Vec<'a, T> to Box<'a, [T]> is zero cost.

Also, now that it's only 16 bytes, remove the Option wrapper, as it serves little purpose except to force you to unwrap it. "No tokens" is represented as an empty slice instead.

Copy link
Member Author

overlookmotel commented Mar 3, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Mar 3, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 3, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks1


Comparing om/03-03-perf_linter_plugins_store_tokens_as_a_box_token_ (c13b437) with om/03-03-feat_allocator_add_methods_for_boxed_slices_arenabox_t_ (d8c7299)2

Open in CodSpeed

Footnotes

  1. 52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on om/03-03-feat_allocator_add_methods_for_boxed_slices_arenabox_t_ (64eee51) during the generation of this report, so 58a7847 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel marked this pull request as ready for review March 3, 2026 14:39
@overlookmotel overlookmotel requested a review from camc314 as a code owner March 3, 2026 14:39
Copilot AI review requested due to automatic review settings March 3, 2026 14:39
@overlookmotel overlookmotel self-assigned this Mar 3, 2026
@overlookmotel overlookmotel added the A-linter-plugins Area - Linter JS plugins label Mar 3, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes token storage in the linter runtime by switching from arena Vec (and an Option wrapper) to an arena Box<[Token]>, representing “no tokens” as an empty slice to reduce per-section/context memory overhead.

Changes:

  • Replace Option<ArenaVec<'a, Token>> with ArenaBox<'a, [Token]> for parser tokens across runtime/context storage.
  • Adjust parsing pipeline to convert collected tokens to a boxed slice (into_boxed_slice) and propagate it through section/module processing.
  • Update external-linter/raw-transfer preparation code paths to work with always-present (possibly empty) token slices.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
crates/oxc_linter/src/service/runtime.rs Store section tokens as ArenaBox<[Token]> and return boxed slices from parsing.
crates/oxc_linter/src/context/host.rs Persist parser tokens as ArenaBox<[Token]> and expose &[Token] / &mut ArenaBox<[Token]> APIs.
crates/oxc_linter/src/lib.rs Remove Option handling around tokens when preparing JS-plugin raw transfer.

@overlookmotel overlookmotel force-pushed the om/03-03-perf_linter_plugins_store_tokens_as_a_box_token_ branch from 6284f43 to c13b437 Compare March 3, 2026 15:19
@overlookmotel overlookmotel force-pushed the om/03-03-feat_allocator_add_methods_for_boxed_slices_arenabox_t_ branch from d8c7299 to 64eee51 Compare March 3, 2026 15:19
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 3, 2026
Copy link
Member Author

overlookmotel commented Mar 3, 2026

Merge activity

Small perf optimization.

Once tokens are collected, we have no reason to add / remove any. So store tokens as a `Box<'a, [Token]>` (16 bytes) instead of a `Vec<'a, Token>` (24 bytes).

Unlike with `std`'s `Vec<T>`, converting arena `Vec<'a, T>` to `Box<'a, [T]>` is zero cost.

Also, now that it's only 16 bytes, remove the `Option` wrapper, as it serves little purpose except to force you to unwrap it. "No tokens" is represented as an empty slice instead.
@graphite-app graphite-app bot force-pushed the om/03-03-feat_allocator_add_methods_for_boxed_slices_arenabox_t_ branch from 64eee51 to 8345318 Compare March 3, 2026 16:23
@graphite-app graphite-app bot force-pushed the om/03-03-perf_linter_plugins_store_tokens_as_a_box_token_ branch from c13b437 to 94b597a Compare March 3, 2026 16:24
Base automatically changed from om/03-03-feat_allocator_add_methods_for_boxed_slices_arenabox_t_ to main March 3, 2026 16:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 3, 2026
@graphite-app graphite-app bot merged commit 94b597a into main Mar 3, 2026
22 checks passed
@graphite-app graphite-app bot deleted the om/03-03-perf_linter_plugins_store_tokens_as_a_box_token_ branch March 3, 2026 16:31
camc314 pushed a commit that referenced this pull request Mar 9, 2026
# Oxlint
### 🚀 Features

- e6b604f oxlint: Auto-enable gitlab formatter on GitLab (#20076)
(camc314)
- 2488a68 linter: Add .oxlintrc.jsonc config file support (#19870)
(Scott S.)
- 61bf388 linter: Add `options.reportUnusedDisableDirectives` to config
file (#19799) (Peter Wagenet)
- c92422b oxlint: Auto-enable github formatter on GitHub Actions
(#19944) (Boshen)
- 0337c6d linter: Implement typescript/no-unecessary-type-conversion
(#19955) (camc314)
- 2919313 linter: Introduce denyWarnings config options (#19926)
(camc314)
- a607119 linter: Introduce maxWarnings config option (#19777) (camc314)

### 🐛 Bug Fixes

- 0861d9a linter/plugins: Remove getters from `Context` (#20115)
(overlookmotel)
- 92cfb14 linter/plugins: Fix types for `walkProgram` and
`walkProgramWithCfg` (#20081) (overlookmotel)
- 10e211f oxlint/lsp: Send other code actions besides `source.fixAll` if
requested (#20042) (Sysix)
- 602daaa linter/plugins: Fix type definition for `VisitorObject`
(#20065) (overlookmotel)
- ee0491e apps,napi: Explicitly specify libs in tsconfigs (#20071)
(camc314)
- b6e9499 linter: Fix the logic for `unicorn/prefer-dom-node-remove` to
handle literal callees as well as arguments. (#20059) (connorshea)
- 3874ae1 linter: Update `unicorn/prefer-query-selector` to also catch
`getElementsByName()`. (#20060) (connorshea)
- 77c93fb linter: Handle array-type shorthand inside union members
(#20034) (camc314)
- 50eb160 linter/no-unused-vars: Allow unused type params in ambient
module blocks (#19615) (Don Isaac)
- 1dd0d21 linter/no-restricted-imports: Apply regex pattern checks to
side-effect imports (#20028) (camc314)
- 7f3d735 linter: Error when --type-check is used without --type-aware
(#20025) (camc314)
- eea201c unicorn/prefer-string-slice: Avoid unsafe autofix for
substr-to-slice (#20010) (camc314)
- 50359dc oxlint/lsp: Detect `reportUnusedDisableDirectives` from oxlint
config, change lsp `unusedDisableDirectives` default value to `None`
(#20011) (Sysix)
- 4bc84b1 linter/plugins: Allow `null` and `undefined` for
`rule.meta.fixable` (#20008) (overlookmotel)
- 753e27e linter/role-supports-aria-props: Add `aria-posinset` to
supported `option` ARIA properties (#20003) (JongKyung Lee)
- f57b2c9 linter/plugins: Fix return types of tokens methods (#19985)
(overlookmotel)
- 27ee4fc linter/no-loss-of-precision: Avoid double rounding for
negative exponents (#19999) (camc314)
- 77a94bb linter: Avoid no-loss-of-precision false positive for 3e-308
(#19992) (camc314)
- 6245c56 linter/no-unused-private-class-members: Treat logical lhs
access as usage (#19991) (camc314)
- 65891e3 linter: Avoid prefer-const false positive for mixed-scope
destructuring (#19982) (camc314)
- 89991fe linter: Avoid prefer-const false positive for operator
reassignments (#19975) (camc314)
- 87318e7 oxlint/lsp: Load js config with reforcing fs read (#19551)
(Sysix)
- d40a942 linter/no-useless-constructor: Mark fixer as suggestion
(#19961) (camc314)
- ccbd959 linter/prefer-code-point: Report String.fromCharCode member
references (#19931) (camc314)
- 14fbbfc linter: Add help text to oxc/no-rest-spread-properties rule
(#19900) (Subin Kim)

### ⚡ Performance

- 2baa5fb napi: Unify build-test profile to coverage for cache sharing
(#20090) (Boshen)
- 77f1c71 linter/plugins: Make tokens class instances (#19980)
(overlookmotel)
- 758b424 linter/plugins: Reduce memory copies for tokens (#19979)
(overlookmotel)
- 236847f linter/plugins: Cache token objects (#19978) (overlookmotel)
- 94b597a linter/plugins: Store tokens as a `Box<[Token]>` (#19969)
(overlookmotel)

### 📚 Documentation

- 2c0010a linter/plugins: Move comment about "bivariance hack" into
generated code (#20082) (overlookmotel)
- 7538f09 linter: Improve `import/extensions` and
`import/no-named-as-default` rule docs. (#20053) (connorshea)
- 1f909cf linter: Improve docs for
`unicorn/require-post-message-target-origin` rule. (#20061) (connorshea)
- 12ae35c oxlint/lsp: Remove outdated ToDo for `LintOptions.run`
(#20012) (Sysix)
- 3be73e6 linter/plugins: Fix JSDoc comments for tokens methods (#20004)
(overlookmotel)
- 48ef285 linter: Update `--config` docs (#19965) (camc314)
- 6ea49a0 linter: Fix some identation issues for the generated types
used in `oxlint.config.ts`. (#19942) (connorshea)
- 6c0e0b5 linter: Add oxlint.config.ts to the config docs. (#19941)
(connorshea)
- 160e423 linter: Add a note that the typeAware and typeCheck options
require oxlint-tsgolint (#19940) (connorshea)
- d54c275 linter: Improve rule docs for 27 unicorn rules (#19903)
(connorshea)
# Oxfmt
### 🚀 Features

- ee26215 oxfmt: Support css-in-js substitution (#20019) (leaysgur)
- 0f0ff51 oxfmt: Display default settings was used message in cli stats
(#19939) (leaysgur)
- 88815b8 oxfmt: Reintroduce stats line for write mode (#19938)
(leaysgur)

### 🐛 Bug Fixes

- ee0491e apps,napi: Explicitly specify libs in tsconfigs (#20071)
(camc314)
- 92f4490 oxfmt: Apply `is_ignored_dir` for glob paths too (#20056)
(leaysgur)
- 114f974 oxfmt/lsp: Prefer language_id over file extension when
formatting (#19977) (copilot-swe-agent)

### ⚡ Performance

- 2baa5fb napi: Unify build-test profile to coverage for cache sharing
(#20090) (Boshen)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants