fix(oxlint): do not enable external plugin store when no external linter is passed by Sysix · Pull Request #17498 · oxc-project/oxc

Sysix · 2025-12-30T16:39:06Z

somehow the refactoring in #17463 shows some js plugin errors for CLI tests.
See https://github.com/oxc-project/oxc/actions/runs/20587373437/job/59126059421

The reason was this code part:

oxc/crates/oxc_linter/src/config/config_builder.rs

Lines 166 to 176 in 0222857

    
           // If external plugins are not enabled (language server), then skip loading JS plugins. 
        
           // This is so that a project can use JS plugins via `oxlint` CLI, and language server 
        
           // will just silently ignore them - rather than crashing. 
        
           if !external_plugins.is_empty() && external_plugin_store.is_enabled() { 
        
               let Some(external_linter) = external_linter else { 
        
                   #[expect(clippy::missing_panics_doc, reason = "infallible")] 
        
                   let first_plugin = external_plugins.iter().next().unwrap(); 
        
                   return Err(ConfigBuilderError::NoExternalLinterConfigured { 
        
                       plugin_specifier: first_plugin.specifier.clone(), 
        
                   }); 
        
               };

Sysix · 2025-12-30T16:39:23Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR fixes a bug where the external plugin store was being enabled by default even when no external linter was configured, which caused errors in CLI tests. The fix ensures that the external plugin store is only enabled when an external linter is actually provided.

Key Changes

Changed ExternalPluginStore::default() to ExternalPluginStore::new(self.external_linter.is_some()) to conditionally enable the store based on external linter presence

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

camc314 · 2025-12-31T20:55:06Z

Merge activity

Dec 31, 8:55 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 31, 8:59 PM UTC: camc314 added this pull request to the Graphite merge queue.
Dec 31, 9:05 PM UTC: Merged by the Graphite merge queue.

…ter is passed (#17498) somehow the refactoring in #17463 shows some js plugin errors for CLI tests. See https://github.com/oxc-project/oxc/actions/runs/20587373437/job/59126059421 The reason was this code part: https://github.com/oxc-project/oxc/blob/0222857e629cc286aabb388adf418c24299b1896/crates/oxc_linter/src/config/config_builder.rs#L166-L176

# Oxlint ### 💥 BREAKING CHANGES - f7da875 oxlint: [**BREAKING**] Remove oxc_language_server binary (#17457) (Boshen) ### 🚀 Features - 659c23e linter: Init note field boilerplate (#17589) (Shrey Sudhir) - 6870b64 parser: Add TS1363 error code (#17609) (Sysix) - 6154c8c linter/eslint-plugin-vitest: Implemented vitest/warn-todo rule (#17228) (Said Atrahouch) - 0043cd6 linter/eslint-plugin-vitest: Implement consistent-vitest-vi rule (#17389) (Said Atrahouch) - a6d773d linter: Add full TS support to eslint/no-useless-constructor (#17592) (camc314) - f02c0e7 linter/eslint: Implement complexity (#17569) (Nguyen Tran) - bc7aae7 linter/no-unused-vars: Add fixer to remove unused catch bindings (#17567) (Don Isaac) - 9e8ec78 linter/only-throw-error rule: Add `allowRethrowing` option for (#17554) (camc314) - b67e819 linter: Add fixer for `unicorn/prefer-response-static-json` rule (#17559) (Mikhail Baev) - 44b0361 linter/vue: Implement no-this-in-before-route-enter (#17525) (yefan) - ee34716 linter/react: Implement no-will-update-set-state (#17530) (Kenzo Wada) - 3088e1d linter/react: Implement no-this-in-sfc (#17535) (Kenzo Wada) - 29a2868 linter/jsx-a11y: Implement no-static-element-interactions (#17538) (Kenzo Wada) - eadf057 linter: Enable tsconfig auto discovery by default (#17489) (Boshen) - 12a7d6e website_linter: Add a count of rules with fixes available to rules table. (#17476) (Connor Shea) ### 🐛 Bug Fixes - a702f13 oxlint/lsp: Correct position for "disable for this file" with shebang (#17613) (Sysix) - 19fdfb6 linter: Panic in `sort-keys` rule with Unicode numeric characters (#17629) (Adel Rodríguez) - 2e8f469 vscode: Search for `node_modules/.bin/oxlint.exe` too (bun setup) (#17597) (Sysix) - be39906 linter/aria-proptypes: Allow template literals with expressions for string-type ARIA props (#17460) (Jökull Sólberg Auðunsson) - 529901c linter: Include JS plugin rules when calculating total rule count (#17520) (connorshea) - 96ef2cc linter: Print total rule # when using a single nested config (#17517) (connorshea) - 9ad0f29 oxlint: Do not enable external plugin store when no external linter is passed (#17498) (Sysix) - 174375d oxfmt,oxlint: Disable mimalloc for 32-bit Arm targets (#17473) (Yaksh Bariya) - ff70fe9 linter/no-standalone-expect: Allows expect in wrapper functions passed to test blocks (#17427) (Copilot) - dab232f linter/catch-or-return: Handle arrow functions with implicit returns correctly (#17440) (Copilot) - a38892a linter: Update no-unnecessary-template-expression docs and test case (#17453) (camc314) ### ⚡ Performance - 605dbf1 vscode: Restrict searching for oxlint/oxfmt binaries only 3 levels deep + 10s timeout (#17345) (Sysix) ### 📚 Documentation - 884fb63 linter/react: Improve docs for jsx-curly-brace-presence (#17579) (connorshea) - 1d3ee07 linter: Improve rule explanation for `vue/no-this-in-before-route-enter`. (#17581) (connorshea) - 5f189f8 linter/arrow-body-style: Correctly document default mode option (#17566) (Rägnar O'ock) - bb2e8e4 linter: Add a note to the `typescript/no-var-requires` rule about the missing `allow` option (#17551) (connorshea) - 655afc1 linter: Improve docs for `import/extensions` and add a few more tests (#17539) (connorshea) - 7e5fc90 linter: Update list of plugins that are reserved. (#17516) (connorshea) # Oxfmt ### 💥 BREAKING CHANGES - f7da875 oxlint: [**BREAKING**] Remove oxc_language_server binary (#17457) (Boshen) ### 🚀 Features - 8fd4ea9 oxfmt: `options.embeddedLanguageFormatting` is now `"auto"` by default (#17649) (leaysgur) ### 🐛 Bug Fixes - c9b5d7d formatter/sort_imports: Handle alignable_comment correctly (#17646) (leaysgur) - 453222d formatter: Missing comment handling for end-of-line comments in member chains (#17659) (Dunqing) - 0805ff2 formatter: Incorrect inline comment placement in try-catch (#17657) (Dunqing) - 3a0c782 formatter: Don't move comments into optional call parentheses (#17582) (magic-akari) - 174375d oxfmt,oxlint: Disable mimalloc for 32-bit Arm targets (#17473) (Yaksh Bariya) ### ⚡ Performance - abb28dc oxfmt: Turn of pretty print from sort-package-json (#17452) (Boshen)

github-actions bot added A-linter Area - Linter A-cli Area - CLI C-bug Category - Bug labels Dec 30, 2025

Sysix mentioned this pull request Dec 30, 2025

refactor(oxlint/lsp): move lsp code to apps/oxlint, remove lsp linter feature flag #17463

Merged

Sysix changed the title ~~fix(oxlint): do notenable external plugin store when no external linter is passed~~ fix(oxlint): do not enable external plugin store when no external linter is passed Dec 30, 2025

Sysix marked this pull request as ready for review December 30, 2025 16:53

Sysix requested a review from camc314 as a code owner December 30, 2025 16:53

Copilot AI review requested due to automatic review settings December 30, 2025 16:53

Sysix assigned camc314 Dec 30, 2025

Copilot started reviewing on behalf of Sysix December 30, 2025 16:54 View session

Copilot AI reviewed Dec 30, 2025

View reviewed changes

Sysix force-pushed the 12-30-fix_oxlint_do_notenable_external_plugin_store_when_no_external_linter_is_passed branch from bd672ad to 36e7a62 Compare December 31, 2025 20:52

camc314 approved these changes Dec 31, 2025

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 31, 2025

graphite-app bot force-pushed the 12-30-fix_oxlint_do_notenable_external_plugin_store_when_no_external_linter_is_passed branch from 36e7a62 to 9ad0f29 Compare December 31, 2025 20:59

graphite-app bot merged commit 9ad0f29 into main Dec 31, 2025
18 checks passed

graphite-app bot deleted the 12-30-fix_oxlint_do_notenable_external_plugin_store_when_no_external_linter_is_passed branch December 31, 2025 21:05

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 31, 2025

Boshen mentioned this pull request Jan 5, 2026

release(apps): oxlint v1.37.0 && oxfmt v0.22.0 #17662

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(oxlint): do not enable external plugin store when no external linter is passed#17498

fix(oxlint): do not enable external plugin store when no external linter is passed#17498
graphite-app[bot] merged 1 commit intomainfrom
12-30-fix_oxlint_do_notenable_external_plugin_store_when_no_external_linter_is_passed

Sysix commented Dec 30, 2025 •

edited

Loading

Uh oh!

Sysix commented Dec 30, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

camc314 commented Dec 31, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	// If external plugins are not enabled (language server), then skip loading JS plugins.
	// This is so that a project can use JS plugins via `oxlint` CLI, and language server
	// will just silently ignore them - rather than crashing.
	if !external_plugins.is_empty() && external_plugin_store.is_enabled() {
	let Some(external_linter) = external_linter else {
	#[expect(clippy::missing_panics_doc, reason = "infallible")]
	let first_plugin = external_plugins.iter().next().unwrap();
	return Err(ConfigBuilderError::NoExternalLinterConfigured {
	plugin_specifier: first_plugin.specifier.clone(),
	});
	};

Uh oh!

Conversation

Sysix commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Dec 30, 2025

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Uh oh!

camc314 commented Dec 31, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sysix commented Dec 30, 2025 •

edited

Loading

camc314 commented Dec 31, 2025 •

edited by graphite-app bot

Loading