feat(linter): init note field boilerplate

[spanishpear]

Consumes miette changes in oxc-project/oxc-miette#124 for #17443

For now, simple note field with appropriate note() and with_note() helpers

Haven't explicitly tested it out just yet, but putting up the PR early before weekend gets busy 😀

Though this isn't doing much now, probably a good idea to snapshot test a simple example?

[codspeed-hq]

CodSpeed Performance Report

Merging #17589 will not alter performance

_{Comparing spanishpear:17443/oxc-note-support (2da055a) with main (f0fdf83)}

Summary

✅ 42 untouched
⏩ 3 skipped¹

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[camc314]

This looks good!

Could you add the note to oxc/no-accumulating-spread just so we can check it works as expected?

diff --git a/crates/oxc_linter/src/rules/oxc/no_accumulating_spread.rs b/crates/oxc_linter/src/rules/oxc/no_accumulating_spread.rs
index e714cc4b7c..8c28dee8ce 100644
--- a/crates/oxc_linter/src/rules/oxc/no_accumulating_spread.rs
+++ b/crates/oxc_linter/src/rules/oxc/no_accumulating_spread.rs
@@ -19,7 +19,8 @@ use crate::{
 
 fn reduce_likely_array_spread_diagnostic(spread_span: Span, reduce_span: Span) -> OxcDiagnostic {
     OxcDiagnostic::warn("Do not spread accumulators in Array.prototype.reduce()")
-        .with_help("It looks like you're spreading an `Array`. Consider using the `Array.push` or `Array.concat` methods to mutate the accumulator instead.\nUsing spreads within accumulators leads to `O(n^2)` time complexity.")
+        .with_help("It looks like you're spreading an `Array`. Consider using the `Array.push` or `Array.concat` methods to mutate the accumulator instead.")
+        .with_node("Using spreads within accumulators leads to `O(n^2)` time complexity.")
         .with_labels([
             spread_span.label("From this spread"),
             reduce_span.label("For this reduce")

[spanishpear]

@camchenry Done! Added to all of them while I was there, for consistency. Let me know if there are any outstanding thoughts on this

I assume we'll need to follow #17589 (comment) this ordering of events to merge this PR, pointing to a new oxc-miette release rather than my branch 😁

[spanishpear]

@camc314 I've updated this branch to now point at the new oxc-miette release 🎉

[camc314]

thank you!