fix(oxfmt,oxlint): disable mimalloc for 32-bit Arm targets#17473
Merged
Boshen merged 1 commit intooxc-project:mainfrom Dec 30, 2025
Merged
fix(oxfmt,oxlint): disable mimalloc for 32-bit Arm targets#17473Boshen merged 1 commit intooxc-project:mainfrom
Boshen merged 1 commit intooxc-project:mainfrom
Conversation
github-actions
bot
added
A-linter
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes ARM build issues by standardizing the cfg conditions for enabling mimalloc across oxlint and oxfmt. The changes align the runtime configuration checks with the dependency declarations in Cargo.toml and match the pattern already used in the napi modules (napi/minify, napi/parser, napi/transform).
Key changes:
- Replaced
not(miri)with architecture-specific exclusions (target_arch = "arm") - Added exclusion for FreeBSD (
target_os = "freebsd") - Maintained existing WASM exclusion (
target_family = "wasm")
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxlint/src/lib.rs | Updated mimalloc cfg condition to exclude 32-bit ARM and FreeBSD, aligning with dependency conditions and other napi modules |
| apps/oxfmt/src/lib.rs | Updated mimalloc cfg condition to exclude 32-bit ARM and FreeBSD, aligning with dependency conditions and other napi modules |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Boshen
requested changes
Dec 30, 2025
Member
Boshen
left a comment
Boshen
left a comment
There was a problem hiding this comment.
Can you add back miri, we sometimes run it.
This makes the condition for enabling mimalloc the same across the entire codebase. The condition for enabling mimalloc dependency was the same across all the projects, but wasn't the same when actually enabling it.
Boshen
changed the title
Boshen
approved these changes
Dec 30, 2025
graphite-app bot
pushed a commit
that referenced
this pull request
Jan 5, 2026
# Oxlint ### 💥 BREAKING CHANGES - f7da875 oxlint: [**BREAKING**] Remove oxc_language_server binary (#17457) (Boshen) ### 🚀 Features - 659c23e linter: Init note field boilerplate (#17589) (Shrey Sudhir) - 6870b64 parser: Add TS1363 error code (#17609) (Sysix) - 6154c8c linter/eslint-plugin-vitest: Implemented vitest/warn-todo rule (#17228) (Said Atrahouch) - 0043cd6 linter/eslint-plugin-vitest: Implement consistent-vitest-vi rule (#17389) (Said Atrahouch) - a6d773d linter: Add full TS support to eslint/no-useless-constructor (#17592) (camc314) - f02c0e7 linter/eslint: Implement complexity (#17569) (Nguyen Tran) - bc7aae7 linter/no-unused-vars: Add fixer to remove unused catch bindings (#17567) (Don Isaac) - 9e8ec78 linter/only-throw-error rule: Add `allowRethrowing` option for (#17554) (camc314) - b67e819 linter: Add fixer for `unicorn/prefer-response-static-json` rule (#17559) (Mikhail Baev) - 44b0361 linter/vue: Implement no-this-in-before-route-enter (#17525) (yefan) - ee34716 linter/react: Implement no-will-update-set-state (#17530) (Kenzo Wada) - 3088e1d linter/react: Implement no-this-in-sfc (#17535) (Kenzo Wada) - 29a2868 linter/jsx-a11y: Implement no-static-element-interactions (#17538) (Kenzo Wada) - eadf057 linter: Enable tsconfig auto discovery by default (#17489) (Boshen) - 12a7d6e website_linter: Add a count of rules with fixes available to rules table. (#17476) (Connor Shea) ### 🐛 Bug Fixes - a702f13 oxlint/lsp: Correct position for "disable for this file" with shebang (#17613) (Sysix) - 19fdfb6 linter: Panic in `sort-keys` rule with Unicode numeric characters (#17629) (Adel Rodríguez) - 2e8f469 vscode: Search for `node_modules/.bin/oxlint.exe` too (bun setup) (#17597) (Sysix) - be39906 linter/aria-proptypes: Allow template literals with expressions for string-type ARIA props (#17460) (Jökull Sólberg Auðunsson) - 529901c linter: Include JS plugin rules when calculating total rule count (#17520) (connorshea) - 96ef2cc linter: Print total rule # when using a single nested config (#17517) (connorshea) - 9ad0f29 oxlint: Do not enable external plugin store when no external linter is passed (#17498) (Sysix) - 174375d oxfmt,oxlint: Disable mimalloc for 32-bit Arm targets (#17473) (Yaksh Bariya) - ff70fe9 linter/no-standalone-expect: Allows expect in wrapper functions passed to test blocks (#17427) (Copilot) - dab232f linter/catch-or-return: Handle arrow functions with implicit returns correctly (#17440) (Copilot) - a38892a linter: Update no-unnecessary-template-expression docs and test case (#17453) (camc314) ### ⚡ Performance - 605dbf1 vscode: Restrict searching for oxlint/oxfmt binaries only 3 levels deep + 10s timeout (#17345) (Sysix) ### 📚 Documentation - 884fb63 linter/react: Improve docs for jsx-curly-brace-presence (#17579) (connorshea) - 1d3ee07 linter: Improve rule explanation for `vue/no-this-in-before-route-enter`. (#17581) (connorshea) - 5f189f8 linter/arrow-body-style: Correctly document default mode option (#17566) (Rägnar O'ock) - bb2e8e4 linter: Add a note to the `typescript/no-var-requires` rule about the missing `allow` option (#17551) (connorshea) - 655afc1 linter: Improve docs for `import/extensions` and add a few more tests (#17539) (connorshea) - 7e5fc90 linter: Update list of plugins that are reserved. (#17516) (connorshea) # Oxfmt ### 💥 BREAKING CHANGES - f7da875 oxlint: [**BREAKING**] Remove oxc_language_server binary (#17457) (Boshen) ### 🚀 Features - 8fd4ea9 oxfmt: `options.embeddedLanguageFormatting` is now `"auto"` by default (#17649) (leaysgur) ### 🐛 Bug Fixes - c9b5d7d formatter/sort_imports: Handle alignable_comment correctly (#17646) (leaysgur) - 453222d formatter: Missing comment handling for end-of-line comments in member chains (#17659) (Dunqing) - 0805ff2 formatter: Incorrect inline comment placement in try-catch (#17657) (Dunqing) - 3a0c782 formatter: Don't move comments into optional call parentheses (#17582) (magic-akari) - 174375d oxfmt,oxlint: Disable mimalloc for 32-bit Arm targets (#17473) (Yaksh Bariya) ### ⚡ Performance - abb28dc oxfmt: Turn of pretty print from sort-package-json (#17452) (Boshen)
robertkirkman
added a commit
to robertkirkman/termux-packages
that referenced
this pull request
Jan 5, 2026
- Fixes termux#27918 - `disable-allocator.patch` now upstream in oxc-project/oxc#17473 - `oxc_language_server` executable removed upstream in oxc-project/oxc#17457
robertkirkman
added a commit
to termux/termux-packages
that referenced
this pull request
Jan 6, 2026
- Fixes #27918 - `disable-allocator.patch` now upstream in oxc-project/oxc#17473 - `oxc_language_server` executable removed upstream in oxc-project/oxc#17457
termux-pacman-bot
added a commit
to termux-pacman/termux-packages
that referenced
this pull request
Jan 6, 2026
- Fixes termux/termux-packages#27918 - `disable-allocator.patch` now upstream in oxc-project/oxc#17473 - `oxc_language_server` executable removed upstream in oxc-project/oxc#17457
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the condition for enabling mimalloc the same across the
entire codebase. The condition for enabling mimalloc dependency was the
same across all the projects, but wasn't the same when actually enabling
it.
Not sure if removing the miri condition is fine. But if we are rewriting this, let's just do this as well and test it on CI(miri condition added back after maintainer request)