fix(vscode): search for `node_modules/.bin/oxlint.exe` too (bun setup) by Sysix · Pull Request #17597 · oxc-project/oxc

Sysix · 2026-01-02T22:04:21Z

This PR adds support for finding .exe binaries on Windows systems, specifically to support the bun package manager which uses .exe extensions for its binaries in node_modules/.bin. The changes include fallback logic to check for both .exe and non-.exe versions of binaries, and updates glob patterns to search for both variants.

It also checks for the user defined oxc.path.oxlint/oxfmt.

closes #17596

Windows + Bun:

2026-01-03 14:24:20.362 [info] Using server binary at: C:\Users\sysix\Desktop\bun-vscode-search\node_modules\.bin\oxlint.exe
2026-01-03 14:24:20.461 [info] [Trace - 2:24:20 PM] Sending request 'initialize - (0)'.

Windows + PNPM:

2026-01-03 14:11:56.401 [error] Invalid bin path: C:\Users\sysix\Desktop\oxc\node_modules\.bin\oxlint.exe A system error occurred (ENOENT: no such file or directory, access 'C:\Users\sysix\Desktop\oxc\node_modules\.bin\oxlint.exe')
2026-01-03 14:12:39.670 [info] Using server binary at: C:\Users\sysix\Desktop\oxc\node_modules\.bin\oxlint
2026-01-03 14:12:39.682 [info] [Trace - 2:12:39 PM] Sending request 'initialize - (0)'.

not sure why it output an error for exe

Linux + Bun:

2026-01-03 14:39:23.643 [info] Using server binary at: /home/sysix/dev/bun-vscode-test/node_modules/.bin/oxlint
2026-01-03 14:39:23.735 [info] [Trace - 2:39:23 PM] Sending request 'initialize - (0)'.

Linux + PNPM:

2026-01-03 13:22:41.759 [info] Using server binary at: /home/sysix/dev/oxc/node_modules/.bin/oxlint
2026-01-03 13:22:41.767 [info] [Trace - 1:22:41 PM] Sending request 'initialize - (0)'.

Sysix · 2026-01-02T22:04:37Z

fix(vscode): search for node_modules/.bin/oxlint.exe too (bun setup) #17597 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR adds support for finding .exe binaries on Windows systems, specifically to support the bun package manager which uses .exe extensions for its binaries in node_modules/.bin. The changes include fallback logic to check for both .exe and non-.exe versions of binaries, and updates glob patterns to search for both variants.

Adds .exe extension checking logic in searchBinaryPath and searchNodeModulesBin methods
Updates glob pattern to search for files with and without .exe extension on Windows
Adds test helper functions for creating and cleaning up test files

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
`editors/vscode/client/ConfigService.ts`	Implements `.exe` extension fallback logic for Windows binary detection and updates glob search patterns
`editors/vscode/tests/unit/ConfigService.spec.ts`	Adds helper functions for file creation/deletion and updates tests to properly clean up created files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

editors/vscode/tests/unit/ConfigService.spec.ts

editors/vscode/client/ConfigService.ts

editors/vscode/tests/unit/ConfigService.spec.ts

camc314 · 2026-01-03T19:24:30Z

Merge activity

Jan 3, 7:24 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jan 3, 7:24 PM UTC: camc314 added this pull request to the Graphite merge queue.
Jan 3, 7:30 PM UTC: Merged by the Graphite merge queue.

#17597) > This PR adds support for finding .exe binaries on Windows systems, specifically to support the bun package manager which uses .exe extensions for its binaries in node_modules/.bin. The changes include fallback logic to check for both .exe and non-.exe versions of binaries, and updates glob patterns to search for both variants. It also checks for the user defined `oxc.path.oxlint/oxfmt`. closes #17596 Windows + Bun: ``` 2026-01-03 14:24:20.362 [info] Using server binary at: C:\Users\sysix\Desktop\bun-vscode-search\node_modules\.bin\oxlint.exe 2026-01-03 14:24:20.461 [info] [Trace - 2:24:20 PM] Sending request 'initialize - (0)'. ``` Windows + PNPM: ``` 2026-01-03 14:11:56.401 [error] Invalid bin path: C:\Users\sysix\Desktop\oxc\node_modules\.bin\oxlint.exe A system error occurred (ENOENT: no such file or directory, access 'C:\Users\sysix\Desktop\oxc\node_modules\.bin\oxlint.exe') 2026-01-03 14:12:39.670 [info] Using server binary at: C:\Users\sysix\Desktop\oxc\node_modules\.bin\oxlint 2026-01-03 14:12:39.682 [info] [Trace - 2:12:39 PM] Sending request 'initialize - (0)'. ``` _not sure why it output an error for exe_ Linux + Bun: ``` 2026-01-03 14:39:23.643 [info] Using server binary at: /home/sysix/dev/bun-vscode-test/node_modules/.bin/oxlint 2026-01-03 14:39:23.735 [info] [Trace - 2:39:23 PM] Sending request 'initialize - (0)'. ``` Linux + PNPM: ``` 2026-01-03 13:22:41.759 [info] Using server binary at: /home/sysix/dev/oxc/node_modules/.bin/oxlint 2026-01-03 13:22:41.767 [info] [Trace - 1:22:41 PM] Sending request 'initialize - (0)'. ```

# Oxlint ### 💥 BREAKING CHANGES - f7da875 oxlint: [**BREAKING**] Remove oxc_language_server binary (#17457) (Boshen) ### 🚀 Features - 659c23e linter: Init note field boilerplate (#17589) (Shrey Sudhir) - 6870b64 parser: Add TS1363 error code (#17609) (Sysix) - 6154c8c linter/eslint-plugin-vitest: Implemented vitest/warn-todo rule (#17228) (Said Atrahouch) - 0043cd6 linter/eslint-plugin-vitest: Implement consistent-vitest-vi rule (#17389) (Said Atrahouch) - a6d773d linter: Add full TS support to eslint/no-useless-constructor (#17592) (camc314) - f02c0e7 linter/eslint: Implement complexity (#17569) (Nguyen Tran) - bc7aae7 linter/no-unused-vars: Add fixer to remove unused catch bindings (#17567) (Don Isaac) - 9e8ec78 linter/only-throw-error rule: Add `allowRethrowing` option for (#17554) (camc314) - b67e819 linter: Add fixer for `unicorn/prefer-response-static-json` rule (#17559) (Mikhail Baev) - 44b0361 linter/vue: Implement no-this-in-before-route-enter (#17525) (yefan) - ee34716 linter/react: Implement no-will-update-set-state (#17530) (Kenzo Wada) - 3088e1d linter/react: Implement no-this-in-sfc (#17535) (Kenzo Wada) - 29a2868 linter/jsx-a11y: Implement no-static-element-interactions (#17538) (Kenzo Wada) - eadf057 linter: Enable tsconfig auto discovery by default (#17489) (Boshen) - 12a7d6e website_linter: Add a count of rules with fixes available to rules table. (#17476) (Connor Shea) ### 🐛 Bug Fixes - a702f13 oxlint/lsp: Correct position for "disable for this file" with shebang (#17613) (Sysix) - 19fdfb6 linter: Panic in `sort-keys` rule with Unicode numeric characters (#17629) (Adel Rodríguez) - 2e8f469 vscode: Search for `node_modules/.bin/oxlint.exe` too (bun setup) (#17597) (Sysix) - be39906 linter/aria-proptypes: Allow template literals with expressions for string-type ARIA props (#17460) (Jökull Sólberg Auðunsson) - 529901c linter: Include JS plugin rules when calculating total rule count (#17520) (connorshea) - 96ef2cc linter: Print total rule # when using a single nested config (#17517) (connorshea) - 9ad0f29 oxlint: Do not enable external plugin store when no external linter is passed (#17498) (Sysix) - 174375d oxfmt,oxlint: Disable mimalloc for 32-bit Arm targets (#17473) (Yaksh Bariya) - ff70fe9 linter/no-standalone-expect: Allows expect in wrapper functions passed to test blocks (#17427) (Copilot) - dab232f linter/catch-or-return: Handle arrow functions with implicit returns correctly (#17440) (Copilot) - a38892a linter: Update no-unnecessary-template-expression docs and test case (#17453) (camc314) ### ⚡ Performance - 605dbf1 vscode: Restrict searching for oxlint/oxfmt binaries only 3 levels deep + 10s timeout (#17345) (Sysix) ### 📚 Documentation - 884fb63 linter/react: Improve docs for jsx-curly-brace-presence (#17579) (connorshea) - 1d3ee07 linter: Improve rule explanation for `vue/no-this-in-before-route-enter`. (#17581) (connorshea) - 5f189f8 linter/arrow-body-style: Correctly document default mode option (#17566) (Rägnar O'ock) - bb2e8e4 linter: Add a note to the `typescript/no-var-requires` rule about the missing `allow` option (#17551) (connorshea) - 655afc1 linter: Improve docs for `import/extensions` and add a few more tests (#17539) (connorshea) - 7e5fc90 linter: Update list of plugins that are reserved. (#17516) (connorshea) # Oxfmt ### 💥 BREAKING CHANGES - f7da875 oxlint: [**BREAKING**] Remove oxc_language_server binary (#17457) (Boshen) ### 🚀 Features - 8fd4ea9 oxfmt: `options.embeddedLanguageFormatting` is now `"auto"` by default (#17649) (leaysgur) ### 🐛 Bug Fixes - c9b5d7d formatter/sort_imports: Handle alignable_comment correctly (#17646) (leaysgur) - 453222d formatter: Missing comment handling for end-of-line comments in member chains (#17659) (Dunqing) - 0805ff2 formatter: Incorrect inline comment placement in try-catch (#17657) (Dunqing) - 3a0c782 formatter: Don't move comments into optional call parentheses (#17582) (magic-akari) - 174375d oxfmt,oxlint: Disable mimalloc for 32-bit Arm targets (#17473) (Yaksh Bariya) ### ⚡ Performance - abb28dc oxfmt: Turn of pretty print from sort-package-json (#17452) (Boshen)

github-actions bot added A-editor Area - Editor and Language Server C-bug Category - Bug labels Jan 2, 2026

Sysix force-pushed the 01-02-fix_vscode_search_for_node_modules_.bin_oxlint.exe_too_bun_setup_ branch from a2a1ef9 to 2bbf3c0 Compare January 3, 2026 12:35

Sysix requested a review from Copilot January 3, 2026 12:37

Copilot started reviewing on behalf of Sysix January 3, 2026 12:37 View session

Copilot AI reviewed Jan 3, 2026

View reviewed changes

Sysix force-pushed the 01-02-fix_vscode_search_for_node_modules_.bin_oxlint.exe_too_bun_setup_ branch from 2bbf3c0 to 8ea398b Compare January 3, 2026 13:41

Sysix marked this pull request as ready for review January 3, 2026 13:45

Sysix requested a review from camc314 as a code owner January 3, 2026 13:45

camc314 approved these changes Jan 3, 2026

View reviewed changes

camc314 self-assigned this Jan 3, 2026

camc314 added the 0-merge Merge with Graphite Merge Queue label Jan 3, 2026

graphite-app bot force-pushed the 01-02-fix_vscode_search_for_node_modules_.bin_oxlint.exe_too_bun_setup_ branch from 8ea398b to 2e8f469 Compare January 3, 2026 19:24

graphite-app bot merged commit 2e8f469 into main Jan 3, 2026
19 checks passed

graphite-app bot deleted the 01-02-fix_vscode_search_for_node_modules_.bin_oxlint.exe_too_bun_setup_ branch January 3, 2026 19:30

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 3, 2026

Boshen mentioned this pull request Jan 5, 2026

release(apps): oxlint v1.37.0 && oxfmt v0.22.0 #17662

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(vscode): search for `node_modules/.bin/oxlint.exe` too (bun setup)#17597

fix(vscode): search for `node_modules/.bin/oxlint.exe` too (bun setup)#17597
graphite-app[bot] merged 1 commit intomainfrom
01-02-fix_vscode_search_for_node_modules_.bin_oxlint.exe_too_bun_setup_

Sysix commented Jan 2, 2026 •

edited

Loading

Uh oh!

Sysix commented Jan 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camc314 commented Jan 3, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Sysix commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Jan 2, 2026

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camc314 commented Jan 3, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sysix commented Jan 2, 2026 •

edited

Loading

camc314 commented Jan 3, 2026 •

edited by graphite-app bot

Loading