fix(formatter): don't move comments into optional call parentheses

[magic-akari]

• Closes: formatter: Diff with Prettier on optional method chain with this #17570

Known Limitations

This PR only fixes the comment placement issue.

Line breaking behavior when comments are present is not addressed and may be handled in a follow-up PR.

[codspeed-hq]

CodSpeed Performance Report

Merging #17582 will not alter performance

_{Comparing magic-akari:fix/issue-17570 (2ce28f3) with main (bc7aae7)¹}

Summary

✅ 38 untouched
⏩ 7 skipped²

Footnotes

1. No successful run was found on main (7005873) during the generation of this report, so bc7aae7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR fixes a formatter bug where comments were incorrectly moved into optional call parentheses. The issue occurred when formatting code like this.getParameters /* comment */ ?.(), which was being incorrectly transformed to this.getParameters?.(/* comment */) instead of keeping the comment outside: this.getParameters /* comment */?.().

Key Changes:

• Modified the condition in chain_member.rs to exclude optional calls from the comment movement logic
• Added comprehensive test cases covering various scenarios with optional chaining and comments

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
crates/oxc_formatter/src/utils/member_chain/chain_member.rs	Added && !call.optional condition to prevent trailing comments from being moved into optional call parentheses
crates/oxc_formatter/tests/fixtures/ts/member-chains/issue-17570.ts	Added test input with four scenarios testing optional calls with comments in different contexts
crates/oxc_formatter/tests/fixtures/ts/member-chains/issue-17570.ts.snap	Added expected output snapshot showing comments remain outside optional call parentheses

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Dunqing]

Thank you!

[graphite-app]

Merge activity

• Jan 3, 3:31 PM UTC: @magic-akari we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

[PeterCardenas]

why do we have this logic anyways? can we just remove it? i feel comment positions in principle should always be preserved

[Dunqing]

why do we have this logic anyways? can we just remove it? i feel comment positions in principle should always be preserved

Unfortunately, we can't; we are aligning the Prettier behavior, which handles comments inconsistently for optional here.

Input:

a /**/ (a)

a /**/ ()

a /**/ ?. ()

Output:

a(/**/ a);

a /**/();

a /**/?.();