Skip to content

refactor(oxlint/lsp): move lsp code to apps/oxlint, remove lsp linter feature flag#17463

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-29-refactor_oxlint_lsp_move_lsp_code_to_apps_oxlint_remove_lsp_linter_feature_flag
Dec 31, 2025
Merged

refactor(oxlint/lsp): move lsp code to apps/oxlint, remove lsp linter feature flag#17463
graphite-app[bot] merged 1 commit intomainfrom
12-29-refactor_oxlint_lsp_move_lsp_code_to_apps_oxlint_remove_lsp_linter_feature_flag

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Dec 29, 2025

closes #15119

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-editor Area - Editor and Language Server A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 29, 2025
Copy link
Member Author

Sysix commented Dec 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 29, 2025

CodSpeed Performance Report

Merging #17463 will not alter performance

Comparing 12-29-refactor_oxlint_lsp_move_lsp_code_to_apps_oxlint_remove_lsp_linter_feature_flag (eb8bf94) with main (5cc2db6)1

Summary

✅ 42 untouched
⏩ 3 skipped2

Footnotes

  1. No successful run was found on main (9ad0f29) during the generation of this report, so 5cc2db6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app bot changed the base branch from 12-29-refactor_oxfmt_lsp_move_lsp_code_to_apps_oxfmt_remove_lsp_formatter_feature_flag to graphite-base/17463 December 30, 2025 02:18
@graphite-app graphite-app bot force-pushed the graphite-base/17463 branch from d404ffa to 435e955 Compare December 30, 2025 02:29
@graphite-app graphite-app bot force-pushed the 12-29-refactor_oxlint_lsp_move_lsp_code_to_apps_oxlint_remove_lsp_linter_feature_flag branch from f110194 to 4608d36 Compare December 30, 2025 02:29
@graphite-app graphite-app bot changed the base branch from graphite-base/17463 to main December 30, 2025 02:30
@graphite-app graphite-app bot force-pushed the 12-29-refactor_oxlint_lsp_move_lsp_code_to_apps_oxlint_remove_lsp_linter_feature_flag branch from 4608d36 to a68da80 Compare December 30, 2025 02:30
@Sysix Sysix changed the base branch from main to graphite-base/17463 December 30, 2025 16:39
@Sysix Sysix force-pushed the 12-29-refactor_oxlint_lsp_move_lsp_code_to_apps_oxlint_remove_lsp_linter_feature_flag branch from a68da80 to 0f201d0 Compare December 30, 2025 16:39
@Sysix Sysix changed the base branch from graphite-base/17463 to 12-30-fix_oxlint_do_notenable_external_plugin_store_when_no_external_linter_is_passed December 30, 2025 16:39
@Sysix Sysix marked this pull request as ready for review December 30, 2025 16:53
@Sysix Sysix requested a review from camc314 as a code owner December 30, 2025 16:53
@Sysix Sysix force-pushed the 12-30-fix_oxlint_do_notenable_external_plugin_store_when_no_external_linter_is_passed branch from bd672ad to 36e7a62 Compare December 31, 2025 20:52
@Sysix Sysix force-pushed the 12-29-refactor_oxlint_lsp_move_lsp_code_to_apps_oxlint_remove_lsp_linter_feature_flag branch from 0f201d0 to 25698dd Compare December 31, 2025 20:52
@graphite-app graphite-app bot changed the base branch from 12-30-fix_oxlint_do_notenable_external_plugin_store_when_no_external_linter_is_passed to graphite-base/17463 December 31, 2025 20:59
@graphite-app graphite-app bot force-pushed the graphite-base/17463 branch from 36e7a62 to 9ad0f29 Compare December 31, 2025 21:05
@graphite-app graphite-app bot force-pushed the 12-29-refactor_oxlint_lsp_move_lsp_code_to_apps_oxlint_remove_lsp_linter_feature_flag branch from 25698dd to 52117f8 Compare December 31, 2025 21:05
@graphite-app graphite-app bot changed the base branch from graphite-base/17463 to main December 31, 2025 21:06
@graphite-app graphite-app bot force-pushed the 12-29-refactor_oxlint_lsp_move_lsp_code_to_apps_oxlint_remove_lsp_linter_feature_flag branch from 52117f8 to eb8bf94 Compare December 31, 2025 21:06
@camc314 camc314 self-assigned this Dec 31, 2025
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 31, 2025
Copy link
Contributor

camc314 commented Dec 31, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 12-29-refactor_oxlint_lsp_move_lsp_code_to_apps_oxlint_remove_lsp_linter_feature_flag branch from eb8bf94 to 99b0834 Compare December 31, 2025 21:12
@graphite-app graphite-app bot merged commit 99b0834 into main Dec 31, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 12-29-refactor_oxlint_lsp_move_lsp_code_to_apps_oxlint_remove_lsp_linter_feature_flag branch December 31, 2025 21:18
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-editor Area - Editor and Language Server A-formatter Area - Formatter A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

language_server: rearchitect lsp for oxlint, oxfmt and vscode

2 participants