Bug 1880591: 9-30-2020 merge by trozet · Pull Request #297 · openshift/ovn-kubernetes

trozet · 2020-09-30T13:43:48Z

Fixes:

Upgrade by ensuring reject ACLs get removed.
logical route policy deletion when nodes are deleted.

run the conformance suite bump kubernetes to 1.19 and go to 1.15.1 use the new HA mode in kind for OVN Signed-off-by: Antonio Ojea <aojea@redhat.com>

When test cases are compiled, the arguments provided to them via the testrun function do not get embedded in the binary. Therefore we lose verbose output, test reporting etc... This commit fixes the test script so all tests are provided with the correct options and have uniform output. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>

The informer package won't process updates under test conditions when the informers have been started. This is due to a check to ensure the objects K8s revision number has incremented and therefore this is genuine work that we want to enqueue. That revision number isn't implemented in the fakeClient. Rather than implement this, which would be a lot of work, I introduced the EventHandlerFactory type, and allowed a function that matches this signature to be passed in to the NewNode and NewMaster functions. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>

This fixes flakes by doing the following: 1. Ensuring that each test has a clean instance of FakeExec so they do not leak between tests 2. Forcing all tests to wait until the informer cache is in sync before performing test logic. This reduces the likelihood of errors caused by events not being processed in time. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>

Fix test flakes in Hybrid Overlay Master Test Suite

Update periodic Job

Considering the jobs takes about 25 mins to run, in average, we have limited the CI jobs to timeout after 1 hour. However, this implies that the test are running in parallel. Signed-off-by: Antonio Ojea <aojea@redhat.com>

Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>

Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <support@github.com>

run periodic tests in parallel

Previously we were just checking if there as a known ACL which existed in the cache. If the cache is ever out of sync, we could accidentally leave stale reject ACLs configured in OVN. This patch adds checking during service sync for any known stale ACLs with reject actions belonging to a service. During regular reject ACL delete a new check is added to see if cache is in an invalid state, and if so attempt to remove the ACL by querying OVN. Signed-off-by: Tim Rozet <trozet@redhat.com>

Remove reject ACLs regardless of cache

This reverts commit 658f605.

trozet · 2020-09-30T13:46:14Z

@dcbw @danwinship

openshift-ci-robot · 2020-09-30T13:47:15Z

@trozet: This pull request references Bugzilla bug 1880591, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1880591: 9-30-2020 merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexanderConstantinescu · 2020-09-30T14:03:28Z

/lgtm

openshift-bot · 2020-09-30T15:47:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T18:21:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T19:01:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T19:52:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T20:57:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T06:54:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T08:12:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T08:38:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T09:04:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T09:56:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T10:09:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T11:01:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T11:27:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T12:19:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T12:45:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T13:11:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

knobunc · 2020-10-01T13:11:17Z

/retest

openshift-bot · 2020-10-01T14:16:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

dcbw · 2020-10-01T14:25:49Z

azure is still failing due to capacity issues

openshift-bot · 2020-10-01T14:42:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

knobunc · 2020-10-01T16:36:40Z

/test e2e-gcp-ovn

openshift-ci-robot · 2020-10-01T18:06:30Z

@trozet: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-azure-ovn	`b93f6d4`	link	`/test e2e-azure-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-10-01T18:38:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T18:49:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

trozet · 2020-10-01T19:16:34Z

/override ci/prow/e2e-gcp-ovn

openshift-ci-robot · 2020-10-01T19:17:05Z

@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-gcp-ovn

Details

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-10-01T19:21:12Z

@trozet: All pull requests linked via external trackers have merged:

Bugzilla bug 1880591 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1880591: 9-30-2020 merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Antonio Ojea and others added 14 commits September 23, 2020 22:33

update dual stack periodic e2e job

7fd9a8b

run the conformance suite bump kubernetes to 1.19 and go to 1.15.1 use the new HA mode in kind for OVN Signed-off-by: Antonio Ojea <aojea@redhat.com>

Merge pull request openshift#1728 from dave-tucker/fix-test-output

7088f8f

Fix test flakes in Hybrid Overlay Master Test Suite

Merge pull request openshift#1702 from aojea/duale2e

aa9455a

Update periodic Job

run periodic tests in parallel

8b05c78

Considering the jobs takes about 25 mins to run, in average, we have limited the CI jobs to timeout after 1 hour. However, this implies that the test are running in parallel. Signed-off-by: Antonio Ojea <aojea@redhat.com>

minor fixes in egress firewall code

f48cece

Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>

Merge pull request openshift#1739 from aojea/fix2

273400a

run periodic tests in parallel

Merge pull request openshift#1738 from trozet/fix_reject_acl_removal

9b281b1

Remove reject ACLs regardless of cache

Revert "HACK force local gateway mode"

5bbfa71

This reverts commit 658f605.

Merge remote-tracking branch 'upstream_ovn/master' into 9-30-2020-merge

3f6013a

openshift-ci-robot requested review from abhat and aojea September 30, 2020 13:44

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2020

trozet changed the title ~~9-30-2020 merge~~ Bug 1880591: 9-30-2020 merge Sep 30, 2020

openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 30, 2020

openshift-ci-robot assigned alexanderConstantinescu Sep 30, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2020

This comment has been minimized.

Sign in to view

openshift-merge-robot merged commit 358045f into openshift:master Oct 1, 2020

This was referenced Oct 27, 2020

Bug 1880591: Adds missing check for ovs-config-executed openshift/cluster-network-operator#836

Merged

Bug 1880591: Fixes race during 4.5->4.6 upgrade with ovn node and master #307

Merged

Conversation

trozet commented Sep 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trozet commented Sep 30, 2020

Uh oh!

openshift-ci-robot commented Sep 30, 2020

Uh oh!

alexanderConstantinescu commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

knobunc commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

dcbw commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

This comment has been minimized.

knobunc commented Oct 1, 2020

Uh oh!

This comment has been minimized.

openshift-ci-robot commented Oct 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

trozet commented Oct 1, 2020

Uh oh!

openshift-ci-robot commented Oct 1, 2020

Uh oh!

openshift-ci-robot commented Oct 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

trozet commented Sep 30, 2020 •

edited

Loading

openshift-ci-robot commented Oct 1, 2020 •

edited

Loading