Bug 1880591: Allow local no bridge#281
Bug 1880591: Allow local no bridge#281openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
@trozet: This pull request references Bugzilla bug 1880591, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
added
the
approved
We have now switched back to using local gateway mode in ovn-kubernetes. This is currently forced in ovn-k8s with a hack. This patch sets it correctly in CNO and we will revert the hack in ovn-k8s. Additionally, this passes the gateway-interface of "none" when ovs-configuration is not available. This allows us to do upgrade via openshift/ovn-kubernetes#281 Signed-off-by: Tim Rozet <trozet@redhat.com>
|
@danwinship @pliurh @dcbw this will allow us to launch local gw mode with no shared gw bridge for upgrade and openshift-sdn-> ovn-k8s conversion. I have a corresponding PR for CNO: and another PR that forces gateway-interface to be none just to ensure functionality still works in this mode: |
|
cluster-botAPP 5:26 PM |
trozet
force-pushed
the
allow_local_no_bridge
branch
from
d0e548c to
d4e9bb8
Compare
trozet
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
trozet
force-pushed
the
allow_local_no_bridge
branch
from
d4e9bb8 to
6b909e0
Compare
Since local gateway mode only needs the shared gateway bridge for egress gw and potentially egress IP features, we can disable it by passing a gateway-interface of "none". We need this temporarily to be able to upgrade from a previous local gateway cluster to a local gateway mode using the shared topology. Signed-off-by: Tim Rozet <trozet@redhat.com>
trozet
force-pushed
the
allow_local_no_bridge
branch
from
6b909e0 to
3e850d9
Compare
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-gcp-ovn |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-gcp-ovn |
|
@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-gcp-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@trozet: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
@trozet: All pull requests linked via external trackers have merged: Bugzilla bug 1880591 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
For OCP we upgrade CNO before MCO. This means that ovn-k8s will get upgraded first when 4.5->4.6 upgrade happens and will try to create a bridge for local gateway mode now. We have to have an intermediate step where we do not create a shared gateway bridge until after the node reboots with ovs-configuration. Therefore this downstream only patch allows us to launch local gateway mode with no shared gateway bridge, and it should still function during upgrade.