Conversation
Recently we added the network-controller-manager flag mode for supporting deployments where master will run separately from cluster-manager. From ovn-kubernetes/ovn-kubernetes#3366 we have renamed the container to be more generic: `ovnkube-controller`. Since we are still early and only merged this flag a few weeks ago, let's make sure we stay consistent moving forward and rename this flag to ovnkube-controller before bringing this flag downstream into CNO. NOTE: All exisiting internal code can call this NetworkControllerManager. On a user facing level, I'd like to keep this simple and say anything programming ovnkube and OVN DB is the ovnkube-controller similar to ovn-controller container. If we don't do this change now we are going to end up with confusion and mismatch between ncm flag and ovnkube-controller container. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com> (cherry picked from commit 402e62b3c3a00e18d5d0e3e9e97f86c960c7efd4)
This commit renames the subsystem from `master` to `ovnkube-controller` Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com> (cherry picked from commit 93e9bd4a9e78c6ad4b1d1f411ae38211dd963a8b)
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricky-rav The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@ricky-rav: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
2 participants
Using this until the next CI image is available to build the latest code from master branch