Bug 1880591: Adds missing check for ovs-config-executed by trozet · Pull Request #836 · openshift/cluster-network-operator

trozet · 2020-10-09T15:58:36Z

Signed-off-by: Tim Rozet trozet@redhat.com

Signed-off-by: Tim Rozet <trozet@redhat.com>

openshift-ci-robot · 2020-10-09T15:58:37Z

@trozet: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Adds missing check for ovs-config-executed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-10-09T16:00:03Z

@trozet: This pull request references Bugzilla bug 1880591, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1885344 is in the state VERIFIED, which is one of the valid states (MODIFIED, VERIFIED)
dependent Bugzilla bug 1885344 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

Details

In response to this:

Bug 1880591: Adds missing check for ovs-config-executed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

danwinship · 2020-10-09T16:03:00Z

/lgtm

openshift-ci-robot · 2020-10-09T16:04:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [danwinship,trozet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

trozet · 2020-10-09T20:50:14Z

/retest

openshift-bot · 2020-10-10T00:56:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

vrutkovs · 2020-10-10T10:36:07Z

/retest

pliurh · 2020-10-14T01:21:25Z

bindata/network/ovn-kubernetes/ovnkube-master.yaml

          # Check to see if ovs is provided by the node. This is only for upgrade from 4.5->4.6 or
          # openshift-sdn to ovn-kube conversion
-          if grep -q OVNKubernetes /etc/systemd/system/ovs-configuration.service ; then
+          if grep -q OVNKubernetes /etc/systemd/system/ovs-configuration.service && [ -f /host/var/run/ovs-config-executed ]; then


I don’t think it’ll impact the SDN migration. But I doubt if we really need to check the existence of ovs-config-executed here. Since the ovs-configuration.service will always run before the ovn-kube pods. So I think checking grep -q OVNKubernetes /etc/systemd/system/ovs-configuration.service is sufficient.

openshift-bot · 2020-10-26T13:16:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-26T13:29:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-26T13:55:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-26T14:47:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-26T21:17:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sdodson · 2020-10-26T23:38:13Z

/retest

openshift-bot · 2020-10-27T01:50:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-27T06:23:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-27T09:12:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

squeed · 2020-10-27T13:09:56Z

/override ci/prow/e2e-aws-sdn-multi

This CI run is faulty, tracked in bz 1890130

openshift-ci-robot · 2020-10-27T13:10:22Z

@squeed: Overrode contexts on behalf of squeed: ci/prow/e2e-aws-sdn-multi

Details

In response to this:

/override ci/prow/e2e-aws-sdn-multi

This CI run is faulty, tracked in bz 1890130

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-27T15:42:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-27T15:55:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sdodson · 2020-10-27T17:17:29Z

/override ci/prow/e2e-aws-sdn-multi

openshift-ci-robot · 2020-10-27T17:17:38Z

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-sdn-multi

Details

In response to this:

/override ci/prow/e2e-aws-sdn-multi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-27T17:26:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-27T18:58:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sdodson · 2020-10-27T19:03:31Z

/override ci/prow/e2e-aws-sdn-multi
once more

openshift-ci-robot · 2020-10-27T19:03:41Z

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-sdn-multi

Details

In response to this:

/override ci/prow/e2e-aws-sdn-multi
once more

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdodson · 2020-10-27T19:19:05Z

/override ci/prow/e2e-gcp
/override ci/prow/e2e-agnostic-upgrade
These have passed multiple times on a previous run.

openshift-ci-robot · 2020-10-27T19:19:13Z

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-agnostic-upgrade, ci/prow/e2e-gcp

Details

In response to this:

/override ci/prow/e2e-gcp
/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-10-27T19:21:29Z

@trozet: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/ovn-kubernetes#307 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1880591 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1880591: Adds missing check for ovs-config-executed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Adds missing check for ovs-config-executed

14185ce

Signed-off-by: Tim Rozet <trozet@redhat.com>

openshift-ci-robot requested review from JacobTanenbaum and aojea October 9, 2020 15:58

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2020

trozet changed the title ~~Adds missing check for ovs-config-executed~~ Bug 1880591: Adds missing check for ovs-config-executed Oct 9, 2020

openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 9, 2020

openshift-ci-robot assigned danwinship Oct 9, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020

pliurh reviewed Oct 14, 2020

View reviewed changes

vrutkovs mentioned this pull request Oct 15, 2020

[Tracking] OKD 4.6 Stable okd-project/okd#348

Closed

6 tasks

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 26, 2020

openshift-merge-robot merged commit 26111b2 into openshift:release-4.6 Oct 27, 2020

openshift-ci-robot mentioned this pull request Oct 29, 2020

Bug 1880591: Fixes race during 4.5->4.6 upgrade with ovn node and master openshift/ovn-kubernetes#307

Merged

Conversation

trozet commented Oct 9, 2020

Uh oh!

openshift-ci-robot commented Oct 9, 2020

Uh oh!

openshift-ci-robot commented Oct 9, 2020

Uh oh!

danwinship commented Oct 9, 2020

Uh oh!

openshift-ci-robot commented Oct 9, 2020

Uh oh!

trozet commented Oct 9, 2020

Uh oh!

openshift-bot commented Oct 10, 2020

Uh oh!

vrutkovs commented Oct 10, 2020

Uh oh!

pliurh Oct 14, 2020

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Oct 26, 2020

Uh oh!

openshift-bot commented Oct 26, 2020

Uh oh!

openshift-bot commented Oct 26, 2020

Uh oh!

openshift-bot commented Oct 26, 2020

Uh oh!

openshift-bot commented Oct 26, 2020

Uh oh!

sdodson commented Oct 26, 2020

Uh oh!

openshift-bot commented Oct 27, 2020

Uh oh!

openshift-bot commented Oct 27, 2020

Uh oh!

openshift-bot commented Oct 27, 2020

Uh oh!

squeed commented Oct 27, 2020

Uh oh!

openshift-ci-robot commented Oct 27, 2020

Uh oh!

openshift-bot commented Oct 27, 2020

Uh oh!

openshift-bot commented Oct 27, 2020

Uh oh!

sdodson commented Oct 27, 2020

Uh oh!

openshift-ci-robot commented Oct 27, 2020

Uh oh!

openshift-bot commented Oct 27, 2020

Uh oh!

openshift-bot commented Oct 27, 2020

Uh oh!

sdodson commented Oct 27, 2020

Uh oh!

openshift-ci-robot commented Oct 27, 2020

Uh oh!

sdodson commented Oct 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 27, 2020

Uh oh!

openshift-ci-robot commented Oct 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

sdodson commented Oct 27, 2020 •

edited

Loading