Bug 1880591: Make ovs-configuration write a file by trozet · Pull Request #2140 · openshift/machine-config-operator

trozet · 2020-10-06T14:10:42Z

In CNO, we have no reliable way to detect if OVS should be running in
systemd or not. Using systemd or dbus is unreliable from the containers.
Checking for file existence is not foolproof because MCO lays the files
down before it reboots into 4.6. This patch makes ovs-configuration
write a file when it executes. We can use this to detect if we should
expect OVS to be running in systemd.

Signed-off-by: Tim Rozet trozet@redhat.com

In CNO, we have no reliable way to detect if OVS should be running in systemd or not. Using systemd or dbus is unreliable from the containers. Checking for file existence is not foolproof because MCO lays the files down before it reboots into 4.6. This patch makes ovs-configuration write a file when it executes. We can use this to detect if we should expect OVS to be running in systemd. Signed-off-by: Tim Rozet <trozet@redhat.com>

openshift-ci-robot · 2020-10-06T14:10:45Z

@trozet: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Make ovs-configuration write a file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

juanluisvaladas · 2020-10-06T14:12:39Z

I don't think I can do it in this repo but:
/lgtm

openshift-ci-robot · 2020-10-06T14:17:53Z

@trozet: This pull request references Bugzilla bug 1883521, which is invalid:

expected Bugzilla bug 1883521 to depend on a bug targeting a release in 4.7.0 and in one of the following states: MODIFIED, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1883521: Make ovs-configuration write a file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

danwinship · 2020-10-06T14:18:18Z

/lgtm
too. Note that there's no corresponding git master PR because this is only needed for 4.5→4.6 upgrade

openshift-ci-robot · 2020-10-06T14:18:45Z

@trozet: This pull request references Bugzilla bug 1880591, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1885344 is in the state VERIFIED, which is one of the valid states (MODIFIED, VERIFIED)
dependent Bugzilla bug 1885344 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

Details

In response to this:

Bug 1880591: Make ovs-configuration write a file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

runcom · 2020-10-06T14:20:26Z

Thanks @dcbw and @trozet 🙏 hopefully this flow is now validated and should be the correct behavior on both ovn/mco sides (this still needs a CNO fix but I'm sure @trozet 's working on it already)

/approve

openshift-ci-robot · 2020-10-06T14:20:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, juanluisvaladas, runcom, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-10-06T14:36:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-06T15:33:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-06T16:07:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-06T17:38:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

trozet · 2020-10-06T17:56:08Z

/hold

trozet · 2020-10-06T20:32:39Z

/hold cancel

trozet · 2020-10-06T20:33:09Z

/retest

openshift-bot · 2020-10-06T21:45:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-06T22:50:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-06T23:55:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-07T00:21:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-07T01:00:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-07T01:52:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-07T02:44:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-07T03:49:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-07T05:02:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-07T05:15:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-07T05:28:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-07T06:37:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-07T07:38:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-07T07:51:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-07T08:04:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-07T08:43:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-07T09:35:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-07T10:01:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-07T10:53:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

runcom · 2020-10-07T12:33:18Z

those two jobs seem broken by something happened for sure elsewhere in the past - we should investigate (cc @cgwalters for the cluster-bootimages)

/override cluster-bootimages
/override e2e-aws-proxy

openshift-ci-robot · 2020-10-07T12:33:37Z

@runcom: /override requires a failed status context to operate on.
The following unknown contexts were given:

cluster-bootimages
e2e-aws-proxy

Only the following contexts were expected:

ci/prow/cluster-bootimages
ci/prow/e2e-aws
ci/prow/e2e-aws-proxy
ci/prow/e2e-aws-workers-rhel7
ci/prow/e2e-gcp-op
ci/prow/e2e-metal-ipi
ci/prow/e2e-ovn-step-registry
ci/prow/e2e-upgrade
ci/prow/images
ci/prow/unit
ci/prow/verify
tide

Details

In response to this:

those two jobs seem broken by something happened for sure elsewhere in the past - we should investigate (cc @cgwalters for the cluster-bootimages)

/override cluster-bootimages
/override e2e-aws-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

runcom · 2020-10-07T12:34:03Z

/override ci/prow/cluster-bootimages
/override ci/prow/e2e-aws-proxy

openshift-ci-robot · 2020-10-07T12:34:52Z

@runcom: Overrode contexts on behalf of runcom: ci/prow/cluster-bootimages, ci/prow/e2e-aws-proxy

Details

In response to this:

/override ci/prow/cluster-bootimages
/override ci/prow/e2e-aws-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-10-07T12:58:02Z

@trozet: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/cluster-network-operator#825 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1880591 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1880591: Make ovs-configuration write a file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from ashcrow and ericavonb October 6, 2020 14:11

openshift-ci-robot assigned juanluisvaladas Oct 6, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2020

trozet changed the title ~~Make ovs-configuration write a file~~ Bug 1883521: Make ovs-configuration write a file Oct 6, 2020

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 6, 2020

openshift-ci-robot assigned danwinship Oct 6, 2020

trozet changed the title ~~Bug 1883521: Make ovs-configuration write a file~~ Bug 1880591: Make ovs-configuration write a file Oct 6, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 6, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020

trozet mentioned this pull request Oct 6, 2020

Bug 1880591: 4.6 Use ovs-configuration file to determine if OVS is running in systemd openshift/cluster-network-operator#825

Merged

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2020

ashcrow added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Oct 7, 2020

openshift-merge-robot merged commit 8f6ba2c into openshift:release-4.6 Oct 7, 2020

openshift-ci-robot mentioned this pull request Oct 9, 2020

Bug 1880591: Fix service sync reject ACL name matching openshift/ovn-kubernetes#305

Merged

This was referenced Oct 27, 2020

Bug 1880591: Adds missing check for ovs-config-executed openshift/cluster-network-operator#836

Merged

Bug 1880591: Fixes race during 4.5->4.6 upgrade with ovn node and master openshift/ovn-kubernetes#307

Merged

Conversation

trozet commented Oct 6, 2020

Uh oh!

openshift-ci-robot commented Oct 6, 2020

Uh oh!

juanluisvaladas commented Oct 6, 2020

Uh oh!

openshift-ci-robot commented Oct 6, 2020

Uh oh!

danwinship commented Oct 6, 2020

Uh oh!

openshift-ci-robot commented Oct 6, 2020

Uh oh!

runcom commented Oct 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 6, 2020

Uh oh!

openshift-bot commented Oct 6, 2020

Uh oh!

openshift-bot commented Oct 6, 2020

Uh oh!

openshift-bot commented Oct 6, 2020

Uh oh!

openshift-bot commented Oct 6, 2020

Uh oh!

trozet commented Oct 6, 2020

Uh oh!

trozet commented Oct 6, 2020

Uh oh!

trozet commented Oct 6, 2020

Uh oh!

openshift-bot commented Oct 6, 2020

Uh oh!

openshift-bot commented Oct 6, 2020

Uh oh!

openshift-bot commented Oct 6, 2020

Uh oh!

openshift-bot commented Oct 7, 2020

Uh oh!

openshift-bot commented Oct 7, 2020

Uh oh!

openshift-bot commented Oct 7, 2020

Uh oh!

openshift-bot commented Oct 7, 2020

Uh oh!

openshift-bot commented Oct 7, 2020

Uh oh!

openshift-bot commented Oct 7, 2020

Uh oh!

openshift-bot commented Oct 7, 2020

Uh oh!

openshift-bot commented Oct 7, 2020

Uh oh!

openshift-bot commented Oct 7, 2020

Uh oh!

openshift-bot commented Oct 7, 2020

Uh oh!

openshift-bot commented Oct 7, 2020

Uh oh!

openshift-bot commented Oct 7, 2020

Uh oh!

openshift-bot commented Oct 7, 2020

Uh oh!

openshift-bot commented Oct 7, 2020

Uh oh!

openshift-bot commented Oct 7, 2020

Uh oh!

openshift-bot commented Oct 7, 2020

Uh oh!

runcom commented Oct 7, 2020

Uh oh!

openshift-ci-robot commented Oct 7, 2020

Uh oh!

runcom commented Oct 7, 2020

Uh oh!

openshift-ci-robot commented Oct 7, 2020

Uh oh!

openshift-ci-robot commented Oct 7, 2020

Uh oh!

runcom commented Oct 6, 2020 •

edited

Loading