[release-4.13] OCPBUGS-15496: Fix default GW IPs retrieval by kyrtapz · Pull Request #1738 · openshift/ovn-kubernetes

kyrtapz · 2023-07-04T13:15:37Z

Backport of ovn-kubernetes/ovn-kubernetes#3570
There were conflicts in go-controller/pkg/node/helper_linux.go

…ual-stack cluster Previously it was allowed to have the IPv6 default GW without having the IPv4 one, we should allow the same in the oposite scenario. Signed-off-by: Patryk Diak <pdiak@redhat.com> (cherry picked from commit 1fbcc39)

Only add the gw IP if it is not empty, the previous approach resulted in adding a `<nil>` IP when there was no default GW: next-hops":["<nil>","fe80::5054:ff:fedf:631e"] Signed-off-by: Patryk Diak <pdiak@redhat.com> (cherry picked from commit e70b35b)

…tewayInterfaceDetails This commit additionally refactors getDefaultGatewayInterfaceDetails to make it independent of the global config. Signed-off-by: Patryk Diak <pdiak@redhat.com> (cherry picked from commit 03ea2c4)

openshift-ci-robot · 2023-07-04T13:15:42Z

@kyrtapz: This pull request references Jira Issue OCPBUGS-15496, which is invalid:

expected the bug to target the "4.13.z" version, but no target version was set
expected Jira Issue OCPBUGS-15496 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Backport of ovn-kubernetes/ovn-kubernetes#3570
There was one conflict in go-controller/pkg/node/helper_linux.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kyrtapz · 2023-07-04T13:16:55Z

/jira refresh

openshift-ci-robot · 2023-07-04T13:16:58Z

@kyrtapz: This pull request references Jira Issue OCPBUGS-15496, which is invalid:

expected Jira Issue OCPBUGS-15496 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kyrtapz · 2023-07-04T13:27:41Z

/jira refresh

openshift-ci-robot · 2023-07-04T13:27:44Z

@kyrtapz: This pull request references Jira Issue OCPBUGS-15496, which is invalid:

expected dependent Jira Issue OCPBUGS-7875 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead
expected dependent Jira Issue OCPBUGS-7875 to target a version in 4.14.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-07-04T13:29:43Z

@kyrtapz: This pull request references Jira Issue OCPBUGS-15496, which is invalid:

expected dependent Jira Issue OCPBUGS-7875 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Backport of ovn-kubernetes/ovn-kubernetes#3570
There were conflicts in go-controller/pkg/node/helper_linux.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-07-04T16:33:35Z

@kyrtapz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack-ovn	`b332d91`	link	false	`/test e2e-openstack-ovn`
ci/prow/e2e-vsphere-ovn	`b332d91`	link	false	`/test e2e-vsphere-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jcaamano · 2023-07-05T11:22:53Z

/lgtm
/approve
/label backport-risk-assessed

openshift-ci · 2023-07-05T11:24:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jcaamano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

asood-rh · 2023-07-05T11:45:41Z

/label cherry-pick-approved

kyrtapz · 2023-07-11T07:13:30Z

/retest-required

rbbratta · 2023-08-02T14:17:08Z

/jira refresh

openshift-ci-robot · 2023-08-02T14:17:15Z

@rbbratta: This pull request references Jira Issue OCPBUGS-15496, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.z) matches configured target version for branch (4.13.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-7875 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-7875 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
bug has dependents

Requesting review from QA contact:
/cc @rbbratta

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-08-02T16:29:19Z

/retest-required

Remaining retests: 0 against base HEAD a7e2297 and 2 for PR HEAD b332d91 in total

openshift-ci-robot · 2023-08-02T18:29:17Z

/retest-required

Remaining retests: 0 against base HEAD 2be24c3 and 1 for PR HEAD b332d91 in total

openshift-ci-robot · 2023-08-03T00:44:15Z

@kyrtapz: Jira Issue OCPBUGS-15496: All pull requests linked via external trackers have merged:

openshift/ovn-kubernetes#1738

Jira Issue OCPBUGS-15496 has been moved to the MODIFIED state.

Details

In response to this:

Backport of ovn-kubernetes/ovn-kubernetes#3570
There were conflicts in go-controller/pkg/node/helper_linux.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2023-08-03T09:58:05Z

Fix included in accepted release 4.13.0-0.nightly-2023-08-03-045759

kyrtapz added 3 commits July 4, 2023 14:43

openshift-ci bot requested review from abhat and dcbw July 4, 2023 13:19

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 5, 2023

openshift-ci bot assigned anuragthehatter, asood-rh, huiran0826, jechen0648, mffiedler, qiowang721, rbbratta, weliang1, yingwang-0320 and zhaozhanqi Jul 5, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 5, 2023

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 2, 2023

openshift-ci bot requested a review from rbbratta August 2, 2023 14:17

openshift-merge-robot merged commit b1774d7 into openshift:release-4.13 Aug 3, 2023

Conversation

kyrtapz commented Jul 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 4, 2023

Uh oh!

kyrtapz commented Jul 4, 2023

Uh oh!

openshift-ci-robot commented Jul 4, 2023

Uh oh!

kyrtapz commented Jul 4, 2023

Uh oh!

openshift-ci-robot commented Jul 4, 2023

Uh oh!

openshift-ci-robot commented Jul 4, 2023

Uh oh!

openshift-ci bot commented Jul 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jcaamano commented Jul 5, 2023

Uh oh!

openshift-ci bot commented Jul 5, 2023

Uh oh!

asood-rh commented Jul 5, 2023

Uh oh!

kyrtapz commented Jul 11, 2023

Uh oh!

rbbratta commented Aug 2, 2023

Uh oh!

openshift-ci-robot commented Aug 2, 2023

Uh oh!

openshift-ci-robot commented Aug 2, 2023

Uh oh!

openshift-ci-robot commented Aug 2, 2023

Uh oh!

openshift-ci-robot commented Aug 3, 2023

Uh oh!

openshift-merge-robot commented Aug 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

kyrtapz commented Jul 4, 2023 •

edited

Loading

openshift-ci bot commented Jul 4, 2023 •

edited

Loading