Skip to content

OCPBUGS-14787: Dockerfile: stop installing CNI plugins RPM#1702

Merged
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
dcbw:no-cni-plugins
Oct 13, 2023
Merged

OCPBUGS-14787: Dockerfile: stop installing CNI plugins RPM#1702
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
dcbw:no-cni-plugins

Conversation

@dcbw
Copy link
Contributor

@dcbw dcbw commented Jun 7, 2023

We used to use it for the loopback plugin, but CRI-O (via ocicni) has configured the loopback interface for years already.

We used to use it for the loopback plugin, but CRI-O (via ocicni)
has configured the loopback interface for years already.
@openshift-ci openshift-ci bot requested review from abhat and tssurya June 7, 2023 21:12
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2023
@dougbtv
Copy link

dougbtv commented Jun 8, 2023

/retest-required

1 similar comment
@dcbw
Copy link
Contributor Author

dcbw commented Jun 8, 2023

/retest-required

@dcbw dcbw changed the title Dockerfile: stop installing CNI plugins RPM OCPBUGS-14787: Dockerfile: stop installing CNI plugins RPM Jun 8, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 8, 2023
@openshift-ci-robot
Copy link
Contributor

@dcbw: This pull request references Jira Issue OCPBUGS-14787, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

We used to use it for the loopback plugin, but CRI-O (via ocicni) has configured the loopback interface for years already.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from anuragthehatter June 8, 2023 15:36
@dougbtv
Copy link

dougbtv commented Jun 8, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, dougbtv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8f60d82 and 2 for PR HEAD 46aaa6b in total

@jupierce
Copy link
Contributor

/retest

@tssurya
Copy link
Contributor

tssurya commented Jun 12, 2023

/hold
if its not urgent because the downstream merge's pool will churn. Once that goes in will remove this.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2023
@dcbw
Copy link
Contributor Author

dcbw commented Jun 22, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2023
@dcbw
Copy link
Contributor Author

dcbw commented Jun 22, 2023

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c3f8a1c and 2 for PR HEAD 46aaa6b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD fb1c565 and 1 for PR HEAD 46aaa6b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 083b00f and 0 for PR HEAD 46aaa6b in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 46aaa6b was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2023
@dcbw
Copy link
Contributor Author

dcbw commented Jun 30, 2023

/hold cancel
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-upgrade-local-gateway

{  error occurred handling build src: build not successful after 5 attempts: [the build src failed after 38s with reason FetchImageContentFailed: Failed to extract image content., the build src failed after 39s with reason FetchImageContentFailed: Failed to extract image content., the build src failed after 37s with reason FetchImageContentFailed: Failed to extract image content.]}

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2023

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-upgrade-local-gateway

Details

In response to this:

/hold cancel
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-upgrade-local-gateway

{  error occurred handling build src: build not successful after 5 attempts: [the build src failed after 38s with reason FetchImageContentFailed: Failed to extract image content., the build src failed after 39s with reason FetchImageContentFailed: Failed to extract image content., the build src failed after 37s with reason FetchImageContentFailed: Failed to extract image content.]}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 46aaa6b was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2023
@zshi-redhat
Copy link
Contributor

/hold cancel
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 239955b and 2 for PR HEAD 46aaa6b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f05d79a and 1 for PR HEAD 46aaa6b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 06c951c and 0 for PR HEAD 46aaa6b in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 46aaa6b was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2023
@openshift-bot
Copy link
Contributor

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 8, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Jira Issue OCPBUGS-14787, which is invalid:

  • expected the bug to target the "4.15.0" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor Author

dcbw commented Oct 9, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 9, 2023
@openshift-ci-robot
Copy link
Contributor

@dcbw: This pull request references Jira Issue OCPBUGS-14787, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor Author

dcbw commented Oct 9, 2023

/retest-required

@tssurya
Copy link
Contributor

tssurya commented Oct 11, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 243e0a0 and 2 for PR HEAD 46aaa6b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD beacd61 and 1 for PR HEAD 46aaa6b in total

@tssurya
Copy link
Contributor

tssurya commented Oct 12, 2023

/retest

@tssurya
Copy link
Contributor

tssurya commented Oct 12, 2023

/tide refresh

@flavio-fernandes
Copy link
Contributor

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2023

@dcbw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-kubevirt 46aaa6b link false /test e2e-aws-ovn-kubevirt

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 1cf6c03 into openshift:master Oct 13, 2023
@openshift-ci-robot
Copy link
Contributor

@dcbw: Jira Issue OCPBUGS-14787: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14787 has been moved to the MODIFIED state.

Details

In response to this:

We used to use it for the loopback plugin, but CRI-O (via ocicni) has configured the loopback interface for years already.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-10-17-065657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants