Bug 1880591: Fix service sync reject ACL name matching by trozet · Pull Request #305 · openshift/ovn-kubernetes

trozet · 2020-10-08T17:59:17Z

Fix service sync reject ACL name matching

The generateACLName function was including backslash escapes for the ACL
name for use in OVN commands that have trouble with literal ":". That
was causing a mismatch when services were syncing because the name
actually returned from an OVN command does not include any backslashes
so the names would not match.

Signed-off-by: Tim Rozet <trozet@redhat.com>

openshift-ci-robot · 2020-10-08T17:59:20Z

@trozet: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Fix service sync reject ACL name matching

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-10-08T18:42:50Z

@trozet: This pull request references Bugzilla bug 1880591, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1885344 is in the state VERIFIED, which is one of the valid states (MODIFIED, VERIFIED)
dependent Bugzilla bug 1885344 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

Details

In response to this:

Bug 1880591: Fix service sync reject ACL name matching

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knobunc · 2020-10-08T18:51:03Z

/lgtm

knobunc · 2020-10-08T18:54:20Z

/hold

Pending upstream merge. @trozet feel free to pull this hold when you are comfortable

The generateACLName function was including backslash escapes for the ACL name for use in OVN commands that have trouble with literal ":". That was causing a mismatch when services were syncing because the name actually returned from an OVN command does not include any backslashes so the names would not match. Signed-off-by: Tim Rozet <trozet@redhat.com> (cherry picked from commit 5359ab7)

knobunc · 2020-10-08T19:22:03Z

/lgtm

openshift-ci-robot · 2020-10-08T19:22:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [knobunc,trozet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knobunc · 2020-10-08T20:31:52Z

/test e2e-azure-ovn

trozet · 2020-10-08T21:30:04Z

/hold cancel

trozet · 2020-10-08T21:33:39Z

/override ci/prow/e2e-vsphere-ovn

openshift-ci-robot · 2020-10-08T21:33:56Z

@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-vsphere-ovn

Details

In response to this:

/override ci/prow/e2e-vsphere-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-08T21:37:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-08T22:55:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

knobunc · 2020-10-09T00:00:08Z

/override ci/prow/e2e-azure-ovn

openshift-ci-robot · 2020-10-09T00:00:28Z

@knobunc: Overrode contexts on behalf of knobunc: ci/prow/e2e-azure-ovn

Details

In response to this:

/override ci/prow/e2e-azure-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-10-09T00:03:39Z

@trozet: All pull requests linked via external trackers have merged:

Bugzilla bug 1880591 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1880591: Fix service sync reject ACL name matching

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from juanluisvaladas and rcarrillocruz October 8, 2020 17:59

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2020

trozet force-pushed the fix_reject_acl_naming_downstream branch from fa4a712 to 8a9f12c Compare October 8, 2020 18:42

trozet changed the title ~~Fix service sync reject ACL name matching~~ Bug 1880591: Fix service sync reject ACL name matching Oct 8, 2020

openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 8, 2020

openshift-ci-robot assigned knobunc Oct 8, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2020

knobunc added staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Oct 8, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2020

trozet force-pushed the fix_reject_acl_naming_downstream branch from 8a9f12c to 1740990 Compare October 8, 2020 19:14

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2020

openshift-merge-robot merged commit dc6798a into openshift:release-4.6 Oct 9, 2020

This was referenced Oct 27, 2020

Bug 1880591: Adds missing check for ovs-config-executed openshift/cluster-network-operator#836

Merged

Bug 1880591: Fixes race during 4.5->4.6 upgrade with ovn node and master #307

Merged

Conversation

trozet commented Oct 8, 2020

Uh oh!

openshift-ci-robot commented Oct 8, 2020

Uh oh!

openshift-ci-robot commented Oct 8, 2020

Uh oh!

knobunc commented Oct 8, 2020

Uh oh!

knobunc commented Oct 8, 2020

Uh oh!

knobunc commented Oct 8, 2020

Uh oh!

openshift-ci-robot commented Oct 8, 2020

Uh oh!

knobunc commented Oct 8, 2020

Uh oh!

trozet commented Oct 8, 2020

Uh oh!

trozet commented Oct 8, 2020

Uh oh!

openshift-ci-robot commented Oct 8, 2020

Uh oh!

openshift-bot commented Oct 8, 2020

Uh oh!

openshift-bot commented Oct 8, 2020

Uh oh!

knobunc commented Oct 9, 2020

Uh oh!

openshift-ci-robot commented Oct 9, 2020

Uh oh!

openshift-ci-robot commented Oct 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants