Skip to content

Comments

Auto sync upstream 2022 08 04 07 47#35

Closed
nunnatsa wants to merge 64 commits intoopenshift:mainfrom
nunnatsa:auto_sync_upstream_2022-08-04-07-47
Closed

Auto sync upstream 2022 08 04 07 47#35
nunnatsa wants to merge 64 commits intoopenshift:mainfrom
nunnatsa:auto_sync_upstream_2022-08-04-07-47

Conversation

@nunnatsa
Copy link

@nunnatsa nunnatsa commented Aug 4, 2022

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release notes:

Auto sync upstream 2022-08-04

Isaac Dorfman and others added 30 commits April 27, 2022 15:26
added integration with the image-builder kubevirt image
9d7d45d
@k8s-ci-robot
Merge pull request kubernetes-sigs#108 from isaacdorfman/image-builde…
5850b33 
…r-integration

Added integration with the image-builder kubevirt image
@nirarg
kubevirtci: Add option to interact with the tenant cluster and improv…
c5b9ccc 
…e usage (help)
@nunnatsa
Add failure printout to the e2e test RunCmd function
fa1c7cf 
In order to debug e2e test failures, add failure printout to the RunCmd
function, so we could understand what went wrong in case of a failure.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@k8s-ci-robot
Merge pull request kubernetes-sigs#134 from nunnatsa/debug-e2e
f89a85c 
Add failure printout to the e2e test RunCmd function
added docs for creating the image-builder image
93595d8
clusterctl integration
e5c71d0
Fixed a linting problem
7f597e1
@k8s-ci-robot
Merge pull request kubernetes-sigs#113 from isaacdorfman/clusterctl-i…
879a4cb 
…ntegration

Clusterctl integration
@k8s-ci-robot
Merge pull request kubernetes-sigs#135 from isaacdorfman/image-builde…
682b649 
…r-docs

added docs for creating the image-builder image
@nunnatsa
Move to golang 1.18
cf80b5a 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@k8s-ci-robot
Merge pull request kubernetes-sigs#136 from nunnatsa/move-to-go-1.18
a6326da 
Move to golang 1.18
@k8s-ci-robot
Merge pull request kubernetes-sigs#133 from nirarg/kubevirtci-tenant-…
27cedcf 
…access

kubevirtci: Add option to interact with the tenant cluster and improve usage (help)
@davidvossel
Add namespace to kubectl-tenant command
ed7eb9e 
Signed-off-by: David Vossel <davidvossel@gmail.com>
@davidvossel
Add ssh commands for infra and tenant nodes
0857b5f 
Signed-off-by: David Vossel <davidvossel@gmail.com>
@davidvossel
add kubevirtci destroy-cluster command
f01885d 
Signed-off-by: David Vossel <davidvossel@gmail.com>
@davidvossel
make separate kubevirtci command for simulating external clusters
60a0162 
Signed-off-by: David Vossel <davidvossel@gmail.com>
@k8s-ci-robot
Merge pull request kubernetes-sigs#140 from davidvossel/kubevirtci-up…
4c4743d 
…dates

Kubevirtci updates
@nirarg
Add tenant cluster verification to createcluster test
62c6aae 
Add the ability to access the tenant cluster during the test
Currently checking only the Nodes exist, need to add more functionality
(For example adding new operators/workloads using the network and storage)
In order to have this ability, added the following:
1. Using virtctl client for kubevirt resources
2. Performing Virtctl portforward and modifying the tenant cluster
   kubeconfig
@davidvossel
Add kubevirtci option for installing metallb
c620757 
Signed-off-by: David Vossel <davidvossel@gmail.com>
@davidvossel
Adds command to curl a load balancer within infra cluster
f706284 
Signed-off-by: David Vossel <davidvossel@gmail.com>
@davidvossel
Add kubevirtci command to install capk from upstream release
8099067 
Signed-off-by: David Vossel <davidvossel@gmail.com>
@davidvossel
Add kubevirtci function to clean local cache
138541e 
Signed-off-by: David Vossel <davidvossel@gmail.com>
@k8s-ci-robot
Merge pull request kubernetes-sigs#141 from davidvossel/kubevirtci-me…
435fc16 
…tal-lb

Kubevirtci metal lb support
@k8s-ci-robot
Merge pull request kubernetes-sigs#139 from nirarg/e2e-test
3457e8e 
Add tenant cluster verification to create-cluster test
@davidvossel
add install calico to kubevirtci and update cluster-up git hash
a6e4584 
Signed-off-by: David Vossel <davidvossel@gmail.com>
@davidvossel
offset tenant network settings from default infra kubeadm settings
7880b04 
The domain and cidr ranges of the tenant cluster need to be offset
from the default kubeadm settings or else they will likely conflict
and overlap with the infra network's settings

Signed-off-by: David Vossel <davidvossel@gmail.com>
@davidvossel
Install cni and verify pod/node status in e2e tests
7c2ee63 
Signed-off-by: David Vossel <davidvossel@gmail.com>
@k8s-ci-robot
Merge pull request kubernetes-sigs#143 from davidvossel/network-fixes
7bc78d3 
Network fixes
@davidvossel
Fix flaky e2e test
d534fcb 
The test occasionally failed because the Update() vmi call
returned an err. This err occurred because the vmi would mutate
between the Get and Update calls. To fix this, we use a Patch

Signed-off-by: David Vossel <davidvossel@gmail.com>
pjaton and others added 14 commits July 28, 2022 06:05
@pjaton
Use gomega matcher to check labels
528668f
@k8s-ci-robot
Merge pull request kubernetes-sigs#159 from pjaton/fix-capk-user-add
58dcd70 
Add capk user properly when users already defined.
@pjaton
Refactor setup-scheme into shared functions.
abde9dd
@pjaton
Look for the infrastructure secret in the owner namespace by default.
a9e7e11 
Also, add unit-test for the infracluster package.
@k8s-ci-robot
Merge pull request kubernetes-sigs#164 from pjaton/add-secret-labels
f648582 
Copy Kubeadm userdata secret labels to CAPK secret.
@k8s-ci-robot
Merge pull request kubernetes-sigs#167 from pjaton/fix-infra-secret-l…
5aa3a3d 
…ookup

Fix infra secret lookup so that it defaults to the namespace of the referencing resource
@nunnatsa
Graceful deletion of a VirtualMachineInstance
160f5dc 
When a host node is deleted, the guest VMIs are evicted, killing the
running tenant node in this VMI.

This PR gracefully delete the VMI, by first drain the guest node. Only
if the drain successful, CAPK will delete the VMI.

The PR is based on a feature in KubeVirt, where by setting the eviction
strategy to "external" KubeVirt will not delete the VMI, but will set
the `vmi.Status.EvacuationNodeName` field to signal to the external
controller (CAPK in this case) that the VMI should be evicted.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
Apply code-review comments
b9d14c9 
Also, add unit tests. Needed to changed the logic to get the guest
cluster client, to use the workloadClient type, because the previous
code was not testable.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
Drain node: add timeout
210fd52 
If drain is failing for more than 10 minutes, delete the VMI anyway.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
Add VMI eviction functional test
d8b2b98 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
fix bug in the vmi eviction controller - wrong predicate
8c89b7c 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
Fix code review comments
8a5e0df 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@k8s-ci-robot
Merge pull request kubernetes-sigs#145 from nunnatsa/drain-node
48c632e 
Graceful deletion of a VirtualMachineInstance
@nunnatsa
Merge remote-tracking branch 'auto-sync-script-upstream/main' into au…
b0ddcf1 
…to_sync_upstream_2022-08-04-07-47

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@openshift-ci openshift-ci bot requested review from davidvossel and nirarg August 4, 2022 07:51
@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2022
@davidvossel
Copy link

davidvossel commented Aug 9, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2022

@nunnatsa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/cluster-api-provider-kubevirt-e2e b0ddcf1 link true /test cluster-api-provider-kubevirt-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@davidvossel
Copy link

davidvossel commented Aug 11, 2022

ci is failing

+ sleep 60
+ oc wait pod --for=condition=Ready -l cluster.x-k8s.io/provider=infrastructure-kubevirt -n capk-system --timeout=120s
error: no matching resources found

@openshift-bot
Copy link

openshift-bot commented Nov 10, 2022

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 10, 2022
@openshift-bot
Copy link

openshift-bot commented Dec 10, 2022

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 10, 2022
@nunnatsa
Copy link
Author

nunnatsa commented Jan 8, 2023

too old
/close

@openshift-ci openshift-ci bot closed this Jan 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 8, 2023

@nunnatsa: Closed this PR.

Details

In response to this:

too old
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa nunnatsa deleted the auto_sync_upstream_2022-08-04-07-47 branch January 8, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidvossel davidvossel Awaiting requested review from davidvossel

@nirarg nirarg Awaiting requested review from nirarg

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nunnatsa @davidvossel @openshift-bot @k8s-ci-robot @nirarg @agradouski @pjaton @qinqon