Skip to content

Kubevirtci updates#140

Merged
k8s-ci-robot merged 4 commits into
kubernetes-sigs:mainfrom
davidvossel:kubevirtci-updates
May 26, 2022
Merged

Kubevirtci updates#140
k8s-ci-robot merged 4 commits into
kubernetes-sigs:mainfrom
davidvossel:kubevirtci-updates

Conversation

@davidvossel
Copy link
Copy Markdown
Contributor

This updates the kubevirtci script to include the following changes

  • adds ssh commands for accessing tenant and infra nodes
  • adds a destroy-cluster command
  • separates create-cluster into two commands, create-cluster and create-external-cluster. The new create-external-cluster command simulates an external cluster using the clusterkubevirtadm command. The normal create-cluster commands treats the infra and management as the same cluster.
  • adds the namespace to the create-cluster command so clusters are created in the $TENANT_CLUSTER_NAMESPACE instead of the default namespace.
  • fixes the new kubectl-tenant command to look in the $TENANT_CLUSTER_NAMESPACE when finding the guest cluster's kubeconfig
NONE

Signed-off-by: David Vossel <davidvossel@gmail.com>
Signed-off-by: David Vossel <davidvossel@gmail.com>
Signed-off-by: David Vossel <davidvossel@gmail.com>
Signed-off-by: David Vossel <davidvossel@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 25, 2022
@k8s-ci-robot k8s-ci-robot requested review from cchengleo and rmohr May 25, 2022 20:50
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 25, 2022
@davidvossel
Copy link
Copy Markdown
Contributor Author

/cc @nirarg

maybe you can take a look at this?

@k8s-ci-robot k8s-ci-robot requested a review from nirarg May 25, 2022 20:50
@davidvossel
Copy link
Copy Markdown
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 25, 2022
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2387060883

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 45.93%

Totals Coverage Status
Change from base Build 2380315759: 0.0%
Covered Lines: 711
Relevant Lines: 1548

💛 - Coveralls

@nirarg
Copy link
Copy Markdown
Contributor

nirarg commented May 26, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4c4743d into kubernetes-sigs:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants