Fix infra secret lookup so that it defaults to the namespace of the referencing resource#167
Merged
k8s-ci-robot merged 2 commits intoAug 1, 2022
Conversation
Pull Request Test Coverage Report for Build 2775158040
💛 - Coveralls |
Also, add unit-test for the infracluster package.
Contributor
|
/ok-to-test |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidvossel, pjaton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change fixes where the
GenerateInfraClusterClientfunction looks up for the infrastructure secret referenced in aKubevirtClusterorKubevirtMachine, when no namespace is specified in theObjectReference.This corrects the current logic by ensuring that, in this case, the code looks for the secret in the same namespace than the referencing resource; which aligns with the default behavior that CAPI follows for other
ObjectReferences.To validate this change of behavior, this PR also introduce a set of tests for the
infraclusterpackage.Which issue this PR fixes:
fixes #165
Special notes for your reviewer:
Note that this change is split in two commits:
setupScheme()function into as single function in thetestingpackage.infraclusterpackage.Release notes: