Skip to content

Add failure printout to the e2e test RunCmd function#134

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
nunnatsa:debug-e2e
May 2, 2022
Merged

Add failure printout to the e2e test RunCmd function#134
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
nunnatsa:debug-e2e

Conversation

@nunnatsa
Copy link
Copy Markdown
Contributor

@nunnatsa nunnatsa commented May 2, 2022

In order to debug e2e test failures, add failure printout to the RunCmd
function, so we could understand what went wrong in case of a failure.

Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

-->

None

In order to debug e2e test failures, add failure printout to the RunCmd
function, so we could understand what went wrong in case of a failure.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from davidvossel and rmohr May 2, 2022 06:13
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2022
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2256328295

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.035%

Totals Coverage Status
Change from base Build 2234201174: 0.0%
Covered Lines: 714
Relevant Lines: 1551

💛 - Coveralls

@nunnatsa
Copy link
Copy Markdown
Contributor Author

nunnatsa commented May 2, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 2, 2022
@nirarg
Copy link
Copy Markdown
Contributor

nirarg commented May 2, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit f89a85c into kubernetes-sigs:main May 2, 2022
@nunnatsa nunnatsa deleted the debug-e2e branch May 2, 2022 08:38
nunnatsa pushed a commit to nunnatsa/cluster-api-provider-kubevirt that referenced this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants