Skip to content

Move to golang 1.18#136

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
nunnatsa:move-to-go-1.18
May 12, 2022
Merged

Move to golang 1.18#136
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
nunnatsa:move-to-go-1.18

Conversation

@nunnatsa
Copy link
Copy Markdown
Contributor

Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release notes:

Move to golang version 1.18

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 12, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 12, 2022
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2311444290

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 45.93%

Totals Coverage Status
Change from base Build 2301624566: 0.0%
Covered Lines: 711
Relevant Lines: 1548

💛 - Coveralls

@nunnatsa
Copy link
Copy Markdown
Contributor Author

ok-to-test

@nunnatsa
Copy link
Copy Markdown
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 12, 2022
Copy link
Copy Markdown
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [davidvossel,nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a6326da into kubernetes-sigs:main May 12, 2022
@nunnatsa nunnatsa deleted the move-to-go-1.18 branch May 12, 2022 13:35
qinqon pushed a commit to qinqon/cluster-api-provider-kubevirt that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants