kubevirtci: Add option to interact with the tenant cluster and improve usage (help)#133
Merged
k8s-ci-robot merged 1 commit intoMay 24, 2022
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirarg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Pull Request Test Coverage Report for Build 2253188400
💛 - Coveralls |
Contributor
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
davidvossel
reviewed
May 24, 2022
| trap 'kill $(jobs -p) > /dev/null 2>&1' EXIT | ||
| rm -f .${TENANT_CLUSTER_NAME}-kubeconfig | ||
| $CLUSTERCTL_PATH get kubeconfig ${TENANT_CLUSTER_NAME} > .${TENANT_CLUSTER_NAME}-kubeconfig | ||
| sleep 0.1 |
Contributor
There was a problem hiding this comment.
why is this sleep here?
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR add option to access tenant cluster created on kubevirtci infra cluster, using virtctl port-forward
Also added better usage display, can be printed by calling
./kubevirtci help